Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 14 Oct 2022 10:00:57 -0700
From:   Ira Weiny <ira.weiny@intel.com>
To:     Davidlohr Bueso <dave@stgolabs.net>
CC:     Dan Williams <dan.j.williams@intel.com>,
        Alison Schofield <alison.schofield@intel.com>,
        Vishal Verma <vishal.l.verma@intel.com>,
        "Ben Widawsky" <bwidawsk@kernel.org>,
        Steven Rostedt <rostedt@goodmis.org>,
        Jonathan Cameron <Jonathan.Cameron@huawei.com>,
        <linux-kernel@vger.kernel.org>, <linux-cxl@vger.kernel.org>
Subject: Re: [RFC V2 PATCH 01/11] cxl/mbox: Add debug of hardware error code
Message-ID: <Y0mVyQVx5t08IPaX@iweiny-mobl>
References: <20221010224131.1866246-1-ira.weiny@intel.com>
 <20221010224131.1866246-2-ira.weiny@intel.com>
 <20221014162921.oth2ing7gv3ofuha@offworld>
 <20221014163149.6zwx6nrbzfbc5pps@offworld>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20221014163149.6zwx6nrbzfbc5pps@offworld>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?HseGH4Tc41rn+694noL3V683GTr/1hlTllrXPHLctlsOqToZr9I0Dw56kxf8?=
 =?us-ascii?Q?vDGTaOcIMPwUb1wZAg8oQN3RZiFA5sejklU/iU/kGNYEHwe0ghZltapr4VGM?=
 =?us-ascii?Q?3lKT2L+q8cKMLQn5VROcJPsNn3AZx4Qyrxg5CS+rQvT4U64Ls18Kg+WziJc7?=
 =?us-ascii?Q?B/Bhj+Ih3kt78IHpUJ6Gd39zZ/imnwxusAzeSIL+cHMxu8wd7CmCo5067sdi?=
 =?us-ascii?Q?1z02NeldHO+Rm1z104+OCErt3G50f4aNxQnqP2B5VZps2vKp0Kc9jd7Qamw7?=
 =?us-ascii?Q?18S93k6Lupd7KQd5heo2Q0d/aibBv8qnBzyM5Re7Sx1iM/i07NNsbcXMO8yh?=
 =?us-ascii?Q?XHuWwx7LmtVgr83QOmu/SNfu0h0I5DNinImQ7xzqkRO6CYk1b2Ov+z7hmU4J?=
 =?us-ascii?Q?61D8FDul75dpUNXypBXQIXT8bvAP+2ICyMRiLTh/IT1dI0Z1Ax+8LhdWDVtP?=
 =?us-ascii?Q?djtKjOzBUtVRILz5zSPVCW5Bl/k7T44c0RX6wRvMfa0P5DtOnER/3Aph347k?=
 =?us-ascii?Q?wTnlA3DeuBRPYwZHSvMgSywUOrgnOoAzN+0WclFbMJqKdZta1AJOcmVr1BVF?=
 =?us-ascii?Q?coc0jZ1a1Lb8l8QUjjLgK1SxfBa2/Tw0mufGy/3S0Vp8EY9VfjCI9QIsUp5t?=
 =?us-ascii?Q?k58q1K1KBH63BcbS0ahaQuVruH479j0n7SKg3237wLMsIinBxCAwhLfYaJYM?=
 =?us-ascii?Q?FUeM1DF5zcKJm9hSk0/UvC+Vmq+b8CGXs9EyQOWQwrH/Jo8/q5nIkDYXGtsz?=
 =?us-ascii?Q?mGxFkvyk1l7/uF29MW1BOln2TUYAbts8l46JYFbDfB2umtUvxXuVlRFYcuHQ?=
 =?us-ascii?Q?Ceq42/jT2qOEpabxw0LTVoc/RR8mNBwXJwvZOyef4P2viN/HfVaYyOsJJDMv?=
 =?us-ascii?Q?bQXUWn+xZh/FXMv4EcSHQVgNOtJB2ZSffZvSHOQX5s5fbrkJFeBjcucT7/OO?=
 =?us-ascii?Q?fK3bM8Xy+nBSpgXphrkqxEHCaeHx5TvNO2/ELhniWxX1zlc6hoGuCAhsAkUj?=
 =?us-ascii?Q?U99miwXrlgJBrnJyOMi2sWr2KiJjg2bPxcih2KjngmZQKdH2ON9Sb2KxqcAk?=
 =?us-ascii?Q?MQGxkiPOdcSydnF78/uRsRsbWRXl1aLyT5LGgRT+dRWut28ByITbS6rl1CHC?=
 =?us-ascii?Q?sgssVgIbgsf8jrnSCuWuYn5tyirMO4QW82K7W/+G6QBt7M8FNT4JqjHTiGJ1?=
 =?us-ascii?Q?SmVLDujJwD3owpaye0lEvySGVwhJ6h3aMVrc7rI046kwI2pqBSIERjHND3bl?=
 =?us-ascii?Q?SGF59zISCU1a48NuejOi54IidIqub1vLytA9/bshcNsQsxNGTMePRX/GAbJN?=
 =?us-ascii?Q?tuuffqJ37ClREqaHfNJN6U6fV5VbxDUkfg2taXgM7PgaXPwUxXhX4sLuCn5F?=
 =?us-ascii?Q?buE4KCFopoJ3Q6Ss7eaIdtk1724RVaTUVHlrEjfkD416SDEtCI3OxYN1GIVx?=
 =?us-ascii?Q?YR1cqH35Y1srcTABzMEc6YBxYc5/gpEHTKcPCQKbR6oqp5l56XzJPerWGsnv?=
 =?us-ascii?Q?+I/nQ7ZHEmYKFvQL8j7W4MhfGMSavzYrk7RmUpW/J6BJ1XHGlt8ZhFC5iIuh?=
 =?us-ascii?Q?S7LcONhhExnBCQkUSWQrZEFkZUsWrZLhtPorJf25?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 1334bfc5-8482-4c33-6e5d-08daae05abdc
X-MS-Exchange-CrossTenant-AuthSource: SA1PR11MB6733.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Oct 2022 17:01:00.9797
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 8AxdqdqXHWEFXxHRz4j15PlQscYbN1flPFFqLMCqYffQKfPAFxDjfiToVPYjARzskM3/DVgr8K3kX/XGxyoZJA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR11MB6606
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI,
        SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Oct 14, 2022 at 09:31:49AM -0700, Davidlohr Bueso wrote:
> On Fri, 14 Oct 2022, Davidlohr Bueso wrote:
> > > -	if (mbox_cmd.return_code != CXL_MBOX_CMD_RC_SUCCESS)
> > > +	if (mbox_cmd.return_code != CXL_MBOX_CMD_RC_SUCCESS) {
> > > +		dev_dbg(cxlds->dev, "MB error : %s\n",
> > 
> > Maybe s/MB/mbox?
> 
> Actually 'Mailbox' seems to be the standard:

Good point!  Changed.

Thanks!
Ira

> 
> core/regs.c:			dev_dbg(dev, "found Mailbox capability (0x%x)\n", offset);
> core/regs.c:			dev_dbg(dev, "found Secondary Mailbox capability (0x%x)\n", offset);
> pci.c:		dev_dbg(dev, "Mailbox operation had an error\n");
> pci.c:		dev_err(cxlds->dev, "Mailbox is too small (%zub)",
> pci.c:	dev_dbg(cxlds->dev, "Mailbox payload sized %zu",