Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20221004184625.10076-1-olof@lixom.net> <CANiq72mFGoDySLHNyakOnJMDpRVmvCRUAAuiKw1B2KrMhFteCA@mail.gmail.com>
In-Reply-To: <CANiq72mFGoDySLHNyakOnJMDpRVmvCRUAAuiKw1B2KrMhFteCA@mail.gmail.com>
From:   Olof Johansson <olof@lixom.net>
Date:   Fri, 14 Oct 2022 11:44:30 -0700
Message-ID: <CAOesGMhBnBrrJuT49V64nSN=UyvAdh1n9mXKYbxAexi1FC1_DA@mail.gmail.com>
Subject: Re: [PATCH] scripts: rust_is_available.sh: Provide hints on how to
 fix missing pieces
To:     Miguel Ojeda <miguel.ojeda.sandonis@gmail.com>
Cc:     Miguel Ojeda <ojeda@kernel.org>,
        Alex Gaynor <alex.gaynor@gmail.com>,
        Wedson Almeida Filho <wedsonaf@gmail.com>,
        Boqun Feng <boqun.feng@gmail.com>, Gary Guo <gary@garyguo.net>,
        =?UTF-8?Q?Bj=C3=B6rn_Roy_Baron?= <bjorn3_gh@protonmail.com>,
        rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Fri, Oct 14, 2022 at 9:21 AM Miguel Ojeda
<miguel.ojeda.sandonis@gmail.com> wrote:
>
> On Tue, Oct 4, 2022 at 8:47 PM Olof Johansson <olof@lixom.net> wrote:
> >
> > This might be a bit bikesheddy, but it saves a few roundtrips to the
> > documentation when getting the `make LLVM=1 rustavailable` run to pass.
>
> It is faster for someone that already knows how things work, but it
> may make newcomers skip the docs and it duplicates the information
> there. In addition, for the non-error case, it makes it more verbose
> which may not be appreciated. So maybe we should point to the docs
> instead? What do you think?

I don't really have a preference. This patch would have helped me, so
I figured I would post it. My interest isn't really high enough to
spend more effort on it at this time -- I got my setup working by now.

Refactoring the script to have a shared message on non-successful exit
with a reference to the doc would achieve what you're suggesting
though.


> Also, the patch doesn't add instructions for all the cases, so
> somebody that may have hit one of the documented ones + not have read
> the docs may wonder where to find them the solution or why they are
> missing.

Sure.


-Olof