Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <0259a530-32af-f6be-b2e5-fcfbda80a052@gmx.de>
Date:   Fri, 14 Oct 2022 21:58:06 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.2
Subject: Re: Possible regression: unable to mount CIFS 1.0 shares from older
 machines since 76a3c92ec9e0668e4cd0e9ff1782eb68f61a179c
To:     Steve French <smfrench@gmail.com>,
        Thorsten Leemhuis <regressions@leemhuis.info>
Cc:     Davyd McColl <davydm@gmail.com>,
        "lsahlber@redhat.com" <lsahlber@redhat.com>,
        "stfrench@microsoft.com" <stfrench@microsoft.com>,
        "linux-cifs@vger.kernel.org" <linux-cifs@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "regressions@lists.linux.dev" <regressions@lists.linux.dev>
References: <D58238A4-F04E-458E-AB05-4A74235B2C65@getmailspring.com>
 <ff982786-4033-7450-c10c-8ce71c28d6eb@leemhuis.info>
 <CAH2r5mtE-EjNbF3OhCLmbGQFMbJgRZphQHS+hHLBiWRJPEBqKA@mail.gmail.com>
From:   Carsten Langer <carsten.langer@gmx.de>
In-Reply-To: <CAH2r5mtE-EjNbF3OhCLmbGQFMbJgRZphQHS+hHLBiWRJPEBqKA@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

 > We have been looking to see if we could setup some VMs for something
 > that old, and we are willing to test against it if it could
 > realistically be setup, but it has been harder than expected. Ronnie
 > had some ideas and we are willing to experiment more but realistically
 > it is very hard to deal with 'legacy museum style' unless we have some
 > VMs available for old systems.
 >
 > Feel free to contact Ronnie and me or Shyam etc (offline if easier) if
 > you have ideas on how to setup something like this.=C2=A0=C2=A0 We don'=
t want to
 > be encouraging SMB1, but certainly not NTLMv1 auth with SMB1 given its
 > security weaknesses (especially given the particular uses hackers have
 > made of 25+ year old NTLMv1 weaknesses).

I would be willing to try to set up a VM for testing.

The issue was further discussed in
https://bugzilla.kernel.org/show_bug.cgi?id=3D215375
I think we could split the topic. The part important for me and others
affected
by this bug is that this regression introduced a protocol violation of
the SMB1
protocol, even for the case where users want to use SMB1 in guest mode,
i.e. without any authentication. At least in this case IMHO we do not need
to discuss NTLMv1 etc., but just make sure that the SMB1 protocol is
again correctly
followed for the case that no user/password is needed. That is what the
proposed patch is
about.

Thus my idea would be to set up an old-enough Samba server providing the
SMB1 protocol
(just) for guest mode, without user/password. If I could then prove that
without patch
the error against that VM occurs and with the patch it works fine, would
that be enough?

But I wonder what you understand by VM? A VirtualBox OVA file? Vmware?
Some Dockerfile
to create an image?
And as this will be a test against a simulated server in a network, are
there standard
requirements how the network is set up between test system and the VM?

- Carsten