Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 14 Oct 2022 15:19:39 -0500
From:   David Vernet <void@manifault.com>
To:     bpf@vger.kernel.org
Cc:     ast@kernel.org, daniel@iogearbox.net, andrii@kernel.org,
        martin.lau@linux.dev, song@kernel.org, yhs@fb.com,
        john.fastabend@gmail.com, kpsingh@kernel.org, sdf@google.com,
        haoluo@google.com, jolsa@kernel.org, linux-kernel@vger.kernel.org,
        kernel-team@fb.com, tj@kernel.org, memxor@gmail.com
Subject: Re: [PATCH v3 1/3] bpf: Allow trusted pointers to be passed to
 KF_TRUSTED_ARGS kfuncs
Message-ID: <Y0nEW14JcWPqRCMO@maniforge.dhcp.thefacebook.com>
References: <20221014201427.2435461-1-void@manifault.com>
 <20221014201427.2435461-2-void@manifault.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20221014201427.2435461-2-void@manifault.com>
User-Agent: Mutt/2.2.7 (2022-08-07)
Precedence: bulk

On Fri, Oct 14, 2022 at 03:14:25PM -0500, David Vernet wrote:

[...]

> @@ -5768,6 +5778,9 @@ static int check_reg_type(struct bpf_verifier_env *env, u32 regno,
>  	if (arg_type & PTR_MAYBE_NULL)
>  		type &= ~PTR_MAYBE_NULL;
>  
> +	if (!(arg_type & ARG_PTR_TO_BTF_ID))
> +		type &= ~PTR_NESTED;
> +

Argh, I added while debugging something and I meant to remove it before
sending out the next version.  I'll send out v4 shortly without this,
apologies for the noise.