Received: by 2002:a05:6358:1087:b0:cb:c9d3:cd90 with SMTP id j7csp1209236rwi; Fri, 14 Oct 2022 14:49:36 -0700 (PDT) X-Google-Smtp-Source: AMsMyM69dk2nKE4uERm23x55QwBuZtWWHEtKwhDy3pEgt/7DXtC4FqNuMb1Ki+CKTeDqbpQ/Ilbx X-Received: by 2002:a17:907:7f1c:b0:78d:ddc7:dfb1 with SMTP id qf28-20020a1709077f1c00b0078dddc7dfb1mr7597ejc.189.1665784176267; Fri, 14 Oct 2022 14:49:36 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1665784176; cv=none; d=google.com; s=arc-20160816; b=s2D4FZ/E5E2XXDOF5CkuoOWR/NQTyhrzGw1YX+gc5yCqDS1viB1fOtRqsp85ACpZhP DIzxxJQLBeqsWBrByofjeR9AIQtJak5ip3bsTeqTXB9Dn+YQ8Rq0uFLBEF09S/WOYvdP izSqrnTGo+w6WVrXtOBlvNCh1vxPHkKMR3crvq8EanOE1S1SUxn6BrvKZJovFteYz1I9 RkQojPPkemRou85q4K8z4YjH8RMqEoxQXvBkC/fhH8BiPOj0EXAvkFZcZPE8uHCMel5C zmiYsS/my3SuxtXhr9+vwNJwLIj6qpP4YU8fnIhWxk9p/ta53FyCnwfHcS0AwpimYLOD taZg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=lSl/i3L1amkU7PAt1gsHNq5hGOQuC/XIP8WX0hUexIY=; b=k8bkYem1VLYYScryXgsTQqHN55aHktohL52yujS7h5F1eBmAr3AAEm5pTbkfQZwfrF Kbipbqa0sayt/HFAwM006lurkmiK+yOU07Z4M2EViMIkLeqOCWOimFMYbDF4XTWFUJxu dSbYsa2rTm1UwhHjPOOOZ3006ivod7iDNHyGynz0Zlmi/B4SgyAUL6POOHvA+HRKxZSq zUYyfS6+0EeTt4BpVXbcs9Hqe1atl7KVyTYnR5lf+UeeULGozm8oNA5CBCkM9JAevLfI sOJr1ddWzZg28+Bw09H/G+CetYiXJdljbX0xqfj++Zh8/VxlgIAwXHqOmtgcGraYTGnI yRMA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id n19-20020a170906165300b0077c5ec87ec2si196817ejd.297.2022.10.14.14.49.09; Fri, 14 Oct 2022 14:49:36 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229962AbiJNVYD (ORCPT + 99 others); Fri, 14 Oct 2022 17:24:03 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55452 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229956AbiJNVXp (ORCPT ); Fri, 14 Oct 2022 17:23:45 -0400 Received: from mx01.omp.ru (mx01.omp.ru [90.154.21.10]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 84FE81DDC22 for ; Fri, 14 Oct 2022 14:23:34 -0700 (PDT) Received: from localhost.localdomain (178.176.75.138) by msexch01.omp.ru (10.188.4.12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.2.986.14; Sat, 15 Oct 2022 00:23:07 +0300 From: Sergey Shtylyov To: Oleg Nesterov , Dinh Nguyen , CC: Andrew Morton Subject: [PATCH 07/13] nios2: ptrace: user_regset_copyin_ignore() always returns 0 Date: Sat, 15 Oct 2022 00:22:29 +0300 Message-ID: <20221014212235.10770-8-s.shtylyov@omp.ru> X-Mailer: git-send-email 2.26.3 In-Reply-To: <20221014212235.10770-1-s.shtylyov@omp.ru> References: <20221014212235.10770-1-s.shtylyov@omp.ru> MIME-Version: 1.0 Content-Transfer-Encoding: 7BIT Content-Type: text/plain; charset=US-ASCII X-Originating-IP: [178.176.75.138] X-ClientProxiedBy: msexch01.omp.ru (10.188.4.12) To msexch01.omp.ru (10.188.4.12) X-KSE-ServerInfo: msexch01.omp.ru, 9 X-KSE-AntiSpam-Interceptor-Info: scan successful X-KSE-AntiSpam-Version: 5.9.20, Database issued on: 10/14/2022 21:00:39 X-KSE-AntiSpam-Status: KAS_STATUS_NOT_DETECTED X-KSE-AntiSpam-Method: none X-KSE-AntiSpam-Rate: 0 X-KSE-AntiSpam-Info: Lua profiles 173137 [Oct 14 2022] X-KSE-AntiSpam-Info: Version: 5.9.20.0 X-KSE-AntiSpam-Info: Envelope from: s.shtylyov@omp.ru X-KSE-AntiSpam-Info: LuaCore: 500 500 6cc86d8f5638d79810308830d98d6b6279998c49 X-KSE-AntiSpam-Info: {rep_avail} X-KSE-AntiSpam-Info: {Tracking_from_domain_doesnt_match_to} X-KSE-AntiSpam-Info: omp.ru:7.1.1;127.0.0.199:7.1.2;d41d8cd98f00b204e9800998ecf8427e.com:7.1.1 X-KSE-AntiSpam-Info: ApMailHostAddress: 178.176.75.138 X-KSE-AntiSpam-Info: Rate: 0 X-KSE-AntiSpam-Info: Status: not_detected X-KSE-AntiSpam-Info: Method: none X-KSE-AntiSpam-Info: Auth:dmarc=temperror header.from=omp.ru;spf=temperror smtp.mailfrom=omp.ru;dkim=none X-KSE-Antiphishing-Info: Clean X-KSE-Antiphishing-ScanningType: Heuristic X-KSE-Antiphishing-Method: None X-KSE-Antiphishing-Bases: 10/14/2022 21:03:00 X-KSE-AttachmentFiltering-Interceptor-Info: protection disabled X-KSE-Antivirus-Interceptor-Info: scan successful X-KSE-Antivirus-Info: Clean, bases: 10/14/2022 3:23:00 PM X-KSE-BulkMessagesFiltering-Scan-Result: InTheLimit X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_NONE, SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org user_regset_copyin_ignore() always returns 0, so checking its result seems pointless -- don't do this anymore... Signed-off-by: Sergey Shtylyov --- arch/nios2/kernel/ptrace.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/arch/nios2/kernel/ptrace.c b/arch/nios2/kernel/ptrace.c index cd62f310778b..9221c15972e6 100644 --- a/arch/nios2/kernel/ptrace.c +++ b/arch/nios2/kernel/ptrace.c @@ -54,7 +54,7 @@ static int genregs_set(struct task_struct *target, #define REG_IGNORE_RANGE(START, END) \ if (!ret) \ - ret = user_regset_copyin_ignore(&pos, &count, &kbuf, &ubuf, \ + user_regset_copyin_ignore(&pos, &count, &kbuf, &ubuf, \ START * 4, (END * 4) + 4); #define REG_IN_ONE(PTR, LOC) \ @@ -80,8 +80,8 @@ static int genregs_set(struct task_struct *target, REG_IN_ONE(®s->ra, PTR_RA); REG_IN_ONE(®s->ea, PTR_PC); /* use ea for PC */ if (!ret) - ret = user_regset_copyin_ignore(&pos, &count, &kbuf, &ubuf, - PTR_STATUS * 4, -1); + user_regset_copyin_ignore(&pos, &count, &kbuf, &ubuf, + PTR_STATUS * 4, -1); return ret; } -- 2.26.3