Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <cb1474f7-b1fd-f22a-4250-77f2e931a742@kernel.org>
Date:   Sat, 15 Oct 2022 10:50:02 +0800
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.3
Subject: Re: [PATCH] erofs: shouldn't churn the mapping page for duplicated
 copies
Content-Language: en-US
To:     Gao Xiang <hsiangkao@linux.alibaba.com>,
        linux-erofs@lists.ozlabs.org
Cc:     LKML <linux-kernel@vger.kernel.org>
References: <20221012045056.13421-1-hsiangkao@linux.alibaba.com>
From:   Chao Yu <chao@kernel.org>
In-Reply-To: <20221012045056.13421-1-hsiangkao@linux.alibaba.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 2022/10/12 12:50, Gao Xiang wrote:
> If other duplicated copies exist in one decompression shot, should
> leave the old page as is rather than replace it with the new duplicated
> one.  Otherwise, the following cold path to deal with duplicated copies
> will use the invalid bvec.  It impacts compressed data deduplication.
> 
> Also, shift the onlinepage EIO bit to avoid touching the signed bit.
> 
> Fixes: 267f2492c8f7 ("erofs: introduce multi-reference pclusters (fully-referenced)")
> Signed-off-by: Gao Xiang <hsiangkao@linux.alibaba.com>

Reviewed-by: Chao Yu <chao@kernel.org>

Thanks,