Received: by 2002:a05:6358:1087:b0:cb:c9d3:cd90 with SMTP id j7csp1485661rwi; Fri, 14 Oct 2022 20:28:27 -0700 (PDT) X-Google-Smtp-Source: AMsMyM4reaZsyzRmVPRtDVDinqWsbMiZY5ShMs7RTgkOSfENaGkZhtbtfey35E/b6kXfpTa7Db4b X-Received: by 2002:a05:6a00:1406:b0:565:dc13:bb36 with SMTP id l6-20020a056a00140600b00565dc13bb36mr1126222pfu.46.1665804506636; Fri, 14 Oct 2022 20:28:26 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1665804506; cv=none; d=google.com; s=arc-20160816; b=Ivux5tNGzfa5qr6M9lGyYj66pTQQxuUF4GHVo+WjDewAXceiBfRITmpQ7ma++ybO5t RY7d54CnszYALw4e6quYradZpy9Lt50mTfYEN7NXyiKg976RPJikqsLKjYi67DCEZnww Pc7DZEHWldkg94qcwL4pIbmsS0LBANfJbP9DaodVmTQhmu2OmHci/YZrBNffWM2ufNhG /DfLzEXp3vmGcoRnMLL5vTEEgxCX+4ZHw6yQOWFulfB+03b6dGfkEmErrM8kO+SuqkKz Lqm8Ks1qUPyOvveeH33cngUU2/CSAdUGMz8qln+pigiznI6CgiTwP0Bod7lcdJuhZ5QJ 8iUA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:dkim-signature; bh=eTqHK2wxDwGZG5+dWyF0+JUWVCFHf6Z7GjsnV9VxI9w=; b=s0rCbVzKa3iBERDUsBBDKxFx+2pjsk6TFIRlKZ/sj7igfQeO0ZzXoxUYFjoCaWZG33 ghd4PZFj6SvsMHqXkAi5iVrdTv84uE6fX6nQRQoJJ+Pb7GIvCom4mv7LinzgSOyyM7ju TxiOrxLFiarMvQFK5LeLfkIN4HTgfLp2cLJ46qm8dPB2zRRN2yDlUfaEzzQ2ax0CjnlN BsOaVJH7vZ6Rxq3kq5YsGY1CEZ+s/S3iC5mUeCHeoLzK1m7moFyP/Kmowrs36LvU1log ikMV3J6Qmpuqx38GxcKenJD3dTzFQQx7zJm4PWFxQfTScr8k/8OxbY8dWFb9uRctBOEB fyaQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=rPiCtlEZ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id m10-20020a1709026bca00b00171311470f7si4614996plt.3.2022.10.14.20.28.13; Fri, 14 Oct 2022 20:28:26 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=rPiCtlEZ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229661AbiJOCr0 (ORCPT + 99 others); Fri, 14 Oct 2022 22:47:26 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49276 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229493AbiJOCrY (ORCPT ); Fri, 14 Oct 2022 22:47:24 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C75107B1D8 for ; Fri, 14 Oct 2022 19:47:23 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 54A4F61CE8 for ; Sat, 15 Oct 2022 02:47:23 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 80363C433D6; Sat, 15 Oct 2022 02:47:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1665802042; bh=/BEvo3ho6FYtrscyZeC1vth4Xpjqk5rZmS+7kUDD5OI=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=rPiCtlEZtQiGq1E7XrZhAFA0O1qzqF0/xQsfUhdnrJWJFMRs92ye+mRMP9RqTkADU rjanlnZIcpQeHSAfYkfgonyFALyXv2CSbr02cdf9OBOD9FQVSADMug3/hvY0V5UNYQ S1cnh84h9L/IetZ2gT0YnFgimWtPgM+tw9CUqu5c7xKjvuNnwTdxWJ0ETQQQLRh7AP jOblHNxziYCd9Cng2eDsfll80ma6Z/IAkM4sztnu27TE7umLDQWhvact1FaIQ7IjfH ceSdsTGFfwQO0UBnIm1DQ/FNs1YPl/GIPJmZlI4u821v69TgAsZrIdyMY+YyN5qjuG F1rgGf9e+cX2A== Message-ID: <21f00900-92da-f70f-2dc7-bbaab05be529@kernel.org> Date: Sat, 15 Oct 2022 10:47:19 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.3.3 Subject: Re: [PATCH v2] erofs: fix invalid unmapped accesses in z_erofs_fill_inode_lazy() To: Yue Hu , xiang@kernel.org Cc: linux-erofs@lists.ozlabs.org, linux-kernel@vger.kernel.org, zhangwen@coolpad.com, Yue Hu References: <20221005013528.62977-1-zbestahu@163.com> Content-Language: en-US From: Chao Yu In-Reply-To: <20221005013528.62977-1-zbestahu@163.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-10.0 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A, RCVD_IN_DNSWL_HI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2022/10/5 9:35, Yue Hu wrote: > From: Yue Hu > > Note that we are still accessing 'h_idata_size' and 'h_fragmentoff' > after calling erofs_put_metabuf(), that is not correct. Fix it. > > Fixes: ab92184ff8f1 ("erofs: add on-disk compressed tail-packing inline support") > Fixes: b15b2e307c3a ("erofs: support on-disk compressed fragments data") > Signed-off-by: Yue Hu Reviewed-by: Chao Yu Thanks,