Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <48b4a5a1-2a52-4159-699b-9db73a012892@gmail.com>
Date:   Sat, 15 Oct 2022 13:06:36 +0900
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.2.2
To:     Carlos Bilbao <carlos.bilbao@amd.com>
Cc:     bilbao@vt.edu, corbet@lwn.net, linux-doc@vger.kernel.org,
        linux-kernel@vger.kernel.org, Akira Yokosawa <akiyks@gmail.com>,
        miguel.ojeda.sandonis@gmail.com
References: <20221014142454.871196-2-carlos.bilbao@amd.com>
Subject: Re: [PATCH v2 1/2] Documentation: Start translations to Spanish
Content-Language: en-US
From:   Akira Yokosawa <akiyks@gmail.com>
In-Reply-To: <20221014142454.871196-2-carlos.bilbao@amd.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hi,
Minor nit on language code.

On Fri, 14 Oct 2022 09:24:53 -0500, Carlos Bilbao wrote:
> Start the process of translating kernel documentation to Spanish. Create
> sp_SP/ and include an index and a disclaimer, following the approach of
> prior translations. Add Carlos Bilbao as MAINTAINER of this translation
> effort.
IIUC, the language code for "Spanish (Spain)" should be "es-ES", as is
listed at e.g., http://www.lingoes.net/en/translator/langcode.htm.

The other translations use directory names found in the table, with
"-" replaced with "_".  It would be better to be consistent.

Just my two cents.

        Thanks, Akira

> 
> Signed-off-by: Carlos Bilbao <carlos.bilbao@amd.com>
> ---
>  Documentation/translations/index.rst          |  1 +
>  .../translations/sp_SP/disclaimer-sp.rst      |  6 ++
>  Documentation/translations/sp_SP/index.rst    | 72 +++++++++++++++++++
>  MAINTAINERS                                   |  5 ++
>  4 files changed, 84 insertions(+)
>  create mode 100644 Documentation/translations/sp_SP/disclaimer-sp.rst
>  create mode 100644 Documentation/translations/sp_SP/index.rst
> 
> diff --git a/Documentation/translations/index.rst b/Documentation/translations/index.rst
> index 1175a47d07f0..b826c34791c0 100644
> --- a/Documentation/translations/index.rst
> +++ b/Documentation/translations/index.rst
> @@ -12,6 +12,7 @@ Translations
>     it_IT/index
>     ko_KR/index
>     ja_JP/index
> +   sp_SP/index
>  
>