Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Sat, 15 Oct 2022 11:07:24 +0200
From:   Miquel Raynal <miquel.raynal@bootlin.com>
To:     yexingchen116@gmail.com
Cc:     richard@nod.at, vigneshr@ti.com, wsa+renesas@sang-engineering.com,
        linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org,
        ye xingchen <ye.xingchen@zte.com.cn>
Subject: Re: [PATCH linux-next] mtd: replace strcmp with sysfs_streq
Message-ID: <20221015110724.5c535807@xps-13>
In-Reply-To: <20221008074643.308969-1-ye.xingchen@zte.com.cn>
References: <20221008074643.308969-1-ye.xingchen@zte.com.cn>
Organization: Bootlin
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Hi yexingchen116@gmail.com,

yexingchen116@gmail.com wrote on Sat,  8 Oct 2022 07:46:43 +0000:

> From: ye xingchen <ye.xingchen@zte.com.cn>
>=20
> Replace the open-code with sysfs_streq().
>=20
> Signed-off-by: ye xingchen <ye.xingchen@zte.com.cn>
> ---
>  drivers/mtd/parsers/cmdlinepart.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>=20
> diff --git a/drivers/mtd/parsers/cmdlinepart.c
> b/drivers/mtd/parsers/cmdlinepart.c
> index b34856def816..6a401e0b1b95 100644
> --- a/drivers/mtd/parsers/cmdlinepart.c
> +++ b/drivers/mtd/parsers/cmdlinepart.c
> @@ -154,7 +154,7 @@ static struct mtd_partition * newpart(char *s,
>  	}
> =20
>  	/* if slc is found use emulated SLC mode on this partition*/
> -	if (!strncmp(s, "slc", 3)) {
> +	if (sysfs_streq(s, "slc")) {

I'm sorry but, why this would be a use for sysfs_streq? The point of
this helper is to consider "\n" null, which is not relevant here. Or do
I miss something?

>  		add_flags |=3D MTD_SLC_ON_MLC_EMULATION;
>  		s +=3D 3;
>  	}


Thanks,
Miqu=C3=A8l