Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Thomas Gleixner <tglx@linutronix.de>
To:     Victor Hassan <victor@allwinnertech.com>,
        daniel.lezcano@linaro.org, wens@csie.org, jernej.skrabec@gmail.com,
        samuel@sholland.org, maxime@cerno.tech
Cc:     linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        linux-sunxi@lists.linux.dev
Subject: Re: [RESEND] clocksource: sun4i: Fix the bug that tick_resume stucks
In-Reply-To: <20221009032507.39145-1-victor@allwinnertech.com>
References: <20221009032507.39145-1-victor@allwinnertech.com>
Date:   Sat, 15 Oct 2022 11:04:47 +0200
Message-ID: <87zgdxa24w.ffs@tglx>
MIME-Version: 1.0
Content-Type: text/plain
Precedence: bulk

On Sun, Oct 09 2022 at 11:25, Victor Hassan wrote:
> Currently syscore_resume() will stuck on tick_resume().

This lacks a clear explanation of the problem, i.e. WHY the current
implementation is not working.

> Fix this by changing  `.tick_resume` from
> sun4i_clkevt_shutdown() to a new function sun4i_tick_resume().
>  
> -static struct timer_of to = {
> -	.flags = TIMER_OF_IRQ | TIMER_OF_CLOCK | TIMER_OF_BASE,

How is switching from a statically allocated struct to a runtime
allocated struct related to the problem?

Thanks,

        tglx