Received: by 2002:a05:6358:1087:b0:cb:c9d3:cd90 with SMTP id j7csp2332579rwi; Sat, 15 Oct 2022 11:49:46 -0700 (PDT) X-Google-Smtp-Source: AMsMyM74purWKk/8AnD7vDyj6xgD+izDMcBHqu1Ss4NCI5L2spKksSwlPshE5ufqxVbmVy2I1S/5 X-Received: by 2002:a17:906:fe04:b0:777:b13d:30a6 with SMTP id wy4-20020a170906fe0400b00777b13d30a6mr2864512ejb.248.1665859786163; Sat, 15 Oct 2022 11:49:46 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1665859786; cv=none; d=google.com; s=arc-20160816; b=L9DbDPrEeChJ70vTjKSrir2N+pkvfuACYvjT4uypKDD/qjSC0pn0EMN3YvNfHiXjLc cvzsj4S5OO3UrRcZ9p8dKKxZMZOaxfuXvgVncrkk/Sgqfu6kb6YAmUTb3i4bOiAVVBFh kdGxW8yCDqz83YSCRY8cZmEB6diqXREC4IEn7zK7N3JwPiIxiMxTzxdowZN1Z8/YX0f5 ZNU/Yum7WBrFaUCRsvrIU0S1GZuPe5yEax8QeOQIKlj+ayF/ioOVfSXgTzt8PtTSgPJE 6mA2HhRdavwozmIpaQMcXa0XbCzST2YyGSgQGD6S+ZZwdFx79wNy1TC/eSdn2a1ES9+q prcw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=uOGrKq48pAhL+qglwCxaxJfFmKuwNLsg1Hsvuj84mPo=; b=VwVFUO+7RgG6VBj4U4C0nZtWC+UeNtbIL68w7ss4+t1JCWZrK30JEmRlZPqH49Mt5M cMIGrSnnybI4vB2s50W2gmSwS4WJbQ5BeUYxbpARToMHSpIPWr/zGO9EBOKcywpvbHKB +GhNpIo5P1Zyr37V7ojh2sc9scSnCk0hVkCwHPA/Hvm2uqZngRkIiN5n1JuTRTME3W2I nv1qLn5iDGhoEPT2Z2rwS20l8nzwgbtr3i/HjMCziICZrwewT6WEuUKu6QAriRdSUQCa GSS0goD8l099PnUM9AjP/SOrjxyHHGGUmIy/DNhijjNjNe2h6FCWkI1o6Gp7WaBnhVu/ 6W6g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass (test mode) header.i=@ideasonboard.com header.s=mail header.b=WFb6t8g5; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id gt11-20020a1709072d8b00b007771bc8dbb4si5838818ejc.781.2022.10.15.11.49.18; Sat, 15 Oct 2022 11:49:46 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass (test mode) header.i=@ideasonboard.com header.s=mail header.b=WFb6t8g5; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229709AbiJOS2g (ORCPT + 99 others); Sat, 15 Oct 2022 14:28:36 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58702 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229700AbiJOS2f (ORCPT ); Sat, 15 Oct 2022 14:28:35 -0400 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5860E4C627; Sat, 15 Oct 2022 11:28:31 -0700 (PDT) Received: from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi [62.78.145.57]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id CF4FB480; Sat, 15 Oct 2022 20:28:28 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1665858509; bh=DG8PAbn5t9CS/s216yD46tH3E1t5E7pFPMUouWzS9lk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=WFb6t8g5ctr85iLoXBcLRRGBZg5EQ+jk1m7b/q1URNisFSD8V/LHmUiE9PxST++ZS Mxk+hInELQ024/FGGBm+6aov2R949RTZwj+n6YbBklst6gngb/P++Y8hfQBMhm+QjA 1H5ZtQQB5bhOCxyHz9X1kAX3dXqiUFuVWXegMRx0= Date: Sat, 15 Oct 2022 21:28:06 +0300 From: Laurent Pinchart To: allen.chen@ite.com.tw Cc: robh@kernel.org, treapking@chromium.org, Jau-Chih.Tseng@ite.com.tw, Kenneth.Hung@ite.com.tw, Hermes.Wu@ite.com.tw, andrzej.hajda@intel.com, narmstrong@baylibre.com, robert.foss@linaro.org, jonas@kwiboo.se, jernej.skrabec@gmail.com, airlied@linux.ie, daniel@ffwll.ch, krzysztof.kozlowski+dt@linaro.org, dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v4 1/2] dt-bindings: it6505: add properties to restrict output bandwidth Message-ID: References: <20221013105116.180380-1-allen.chen@ite.com.tw> <20221013105116.180380-2-allen.chen@ite.com.tw> <20221013192016.GA95717-robh@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_PASS,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello, On Fri, Oct 14, 2022 at 03:28:31AM +0000, allen.chen@ite.com.tw wrote: > On Friday, October 14, 2022 3:20 AM, Rob Herring wrote: > > On Thu, Oct 13, 2022 at 02:05:45PM +0300, Laurent Pinchart wrote: > > > On Thu, Oct 13, 2022 at 06:51:13PM +0800, allen wrote: > > > > From: allen chen > > > > > > > > Add properties to restrict dp output data-lanes and clock. > > > > > > > > Signed-off-by: Pin-Yen Lin > > > > Signed-off-by: Allen Chen > > > > --- > > > > .../bindings/display/bridge/ite,it6505.yaml | 43 +++++++++++++++++++ > > > > 1 file changed, 43 insertions(+) > > > > > > > > diff --git a/Documentation/devicetree/bindings/display/bridge/ite,it6505.yaml b/Documentation/devicetree/bindings/display/bridge/ite,it6505.yaml > > > > index 833d11b2303a7..f2c3d1d10359e 100644 > > > > --- a/Documentation/devicetree/bindings/display/bridge/ite,it6505.yaml > > > > +++ b/Documentation/devicetree/bindings/display/bridge/ite,it6505.yaml > > > > @@ -52,10 +52,51 @@ properties: > > > > maxItems: 1 > > > > description: extcon specifier for the Power Delivery > > > > > > > > + data-lanes: > > > > + oneOf: > > > > + - minItems: 1 > > > > + maxItems: 1 > > > > + uniqueItems: true > > > > + items: > > > > + enum: > > > > + - 0 > > > > + - 1 > > > > + description: For one lane operation. > > > > + > > > > + - minItems: 2 > > > > + maxItems: 2 > > > > + uniqueItems: true > > > > + items: > > > > + enum: > > > > + - 0 > > > > + - 1 > > > > + description: For two lanes operation. > > > > + > > > > + - minItems: 4 > > > > + maxItems: 4 > > > > + uniqueItems: true > > > > + items: > > > > + enum: > > > > + - 0 > > > > + - 1 > > > > + - 2 > > > > + - 3 > > > > + description: For four lanes operation. > > > > > > The data lanes should be in the output endpoint. If there's no output > > > port, one should be added. > > ==> In this dt-binding, our output point is "extcon" so doesn't have output endpoint. > I don't know how to add the endpoint. > If need to add the endpoint to this dt-binding, what is your recommend about adding the endpoint? You will also need to add a port to the USB-C connector. Then endpoints can be added to connect the two. > By the way, Krzysztof Kozlowski said > we could put "data-lanes" here. If I read him correctly, Krzysztof said we have a standard property for the data lanes (and that's true, we do), but I don't think he implied it could be put outside of the endpoint (Krzysztof, please correct me if I'm wrong). > > > > + > > > > port: > > > > $ref: /schemas/graph.yaml#/properties/port > > > > To fix the error, this must be: > > > > $ref: /schemas/graph.yaml#/$defs/port-base > > unevaluatedProperties: false > > > > > > description: A port node pointing to DPI host port node > > > > > > > > + properties: > > > > + endpoint: > > > > + $ref: /schemas/graph.yaml#/$defs/endpoint-base > > > > + > > > > + properties: > > > > + link-frequencies: > > > > + minItems: 1 > > > > + maxItems: 1 > > > > + description: Allowed max link frequencies in Hz. > > > > + > > > > required: > > > > - compatible > > > > - ovdd-supply > > > > @@ -84,10 +125,12 @@ examples: > > > > pwr18-supply = <&it6505_pp18_reg>; > > > > reset-gpios = <&pio 179 1>; > > > > extcon = <&usbc_extcon>; > > > > + data-lanes = <0 1>; > > > > > > > > port { > > > > it6505_in: endpoint { > > > > remote-endpoint = <&dpi_out>; > > > > + link-frequencies = /bits/ 64 <150000000>; > > > > }; > > > > }; > > > > }; -- Regards, Laurent Pinchart