Received: by 2002:a05:6358:1087:b0:cb:c9d3:cd90 with SMTP id j7csp2477485rwi; Sat, 15 Oct 2022 15:03:34 -0700 (PDT) X-Google-Smtp-Source: AMsMyM4N2Z6ttShk+SzBFxESZhpCiliyfxoWy2JFTj9Tc8X+IHrb7kSkcSpczCjzUGeK/MBaiB5e X-Received: by 2002:a17:906:cc57:b0:78e:d09:500a with SMTP id mm23-20020a170906cc5700b0078e0d09500amr3360936ejb.396.1665871414110; Sat, 15 Oct 2022 15:03:34 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1665871414; cv=none; d=google.com; s=arc-20160816; b=RPAHbRMu0dsp3h8zPNO8K6AKFjC6TG2gCnaNeL60X1SmYhoyIfKGLbwSSB1XU8+F9j 6+hgyXLaE0YvlSZupQJyULAWzyTxf9tVb9pjg+YBZQcJrVzefJZFZR4MVduJydvGC9wF mDWXc7o+ksLyUuMRZezzoqeYwBkMizkQLvYudAur8Bvm55JCb9pxdJTdnvSdVBiAHEsV pdVzUGdli980O6+ZKgTc1/iamokGkZDWIQ1c9N3RnzCNkSpo4RyTds18xIOFzBqq3xgw xSfjLbLdCIProLUTEpBV+Zaq+eZiiiTFVKTD/ZVZHpMMrCUvA1ERQsSjt+sECp4PycBP 3sQQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:date:subject:cc:to:from:message-id :dkim-signature; bh=/ynhneD3j0dnbSPLYCvJs/d10Int+5lPSKHCEwL7c0s=; b=FLCfht17o7KzQ+64aWjhsSUYbn9BBKdinYipltP6/0WL/G2OmIY8zZcwYlYanNr2NK LEvRMVqiaGkqnH+06NlhHnXQ8uDaMoemmYrxboDDVN0VjeRjEFqbssaA4M+5iHb/mVUi 9/l5eDczhhT0IXZVgi00LmlnLZ0SakdKoOpJF5ojsOY8L9kU0cvOo5Esd1WOO21OSvgj jgjhpMkSSYTYZU1b2htku87CCEgyAphFaBhWhqP13/WRL7KwzVZCAyMNyrvgu4X3ADca 66f/3XBgJ8IwO8CCfCR0rYH+VHpGcpYcxmQ3WITNYYfRh2efazFeAOk4foZUtmXK8qAB xp+g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=lq7wqZRy; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id j30-20020a508a9e000000b0044dbb9afe1fsi5089553edj.467.2022.10.15.15.03.08; Sat, 15 Oct 2022 15:03:34 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=lq7wqZRy; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229595AbiJOUHg (ORCPT + 99 others); Sat, 15 Oct 2022 16:07:36 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45470 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229594AbiJOUHe (ORCPT ); Sat, 15 Oct 2022 16:07:34 -0400 Received: from mail-qk1-x729.google.com (mail-qk1-x729.google.com [IPv6:2607:f8b0:4864:20::729]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B273844557; Sat, 15 Oct 2022 13:07:33 -0700 (PDT) Received: by mail-qk1-x729.google.com with SMTP id x13so4548546qkg.11; Sat, 15 Oct 2022 13:07:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to:date :subject:cc:to:from:message-id:from:to:cc:subject:date:message-id :reply-to; bh=/ynhneD3j0dnbSPLYCvJs/d10Int+5lPSKHCEwL7c0s=; b=lq7wqZRy8VrRcpRgq4ZuJYbmIdjrAljfPMqaxAFeeUWiey5ujd40mtKW69vj7ncYU2 x2Qegj3iILVktYvjp2IdmJ3mbO2wWJHrKa26hV7UB93wAt7DxWgPHYLH1o1RUM6gn2p9 zx+zkGPP7Wrzvgsg5hJ/F4TEpwwh5OrwIdzQPPI1Dw5gqh1/4kaVxQC86wb23OsJYDPX q5CNNVN7P3Hqwjb7ggTlgDk3ZOT1FE4IwA4GJiUlJIDdlJDzjeDifkNnL8hv4Mk2o/Zb gRETxviroj0YsXP7j5NHnjlnGNQXy6MTbypuBLBxoZ0DkLQzov7++dvcYHfR7Rfl36p8 DaRA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to:date :subject:cc:to:from:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=/ynhneD3j0dnbSPLYCvJs/d10Int+5lPSKHCEwL7c0s=; b=WWaoF+XBGhWELyTAizerTUjKfaHko/w/s/+OBTt/E79Kco0UHbqyyMTEqeZRpkeW7m QL7tgr8wmB376IkunbmyojJvqJdxT+Jl4wscFmeTJbwZpAPaOgiH3OQllQ4+84uetq8l D/mS2lkwuFKiLd6isJwaAvpGMsd4UnJsFw9sHs4Pnc8+1Feryn6h1RlnA22ZqxFAlRkC 0t9jY2+mfRnpQS01b+BP7P1z/37s1r7xlvp4DSDz6i52qSxWqQ9cFbZcbmK0JHAEzo+O WklSXseFD9fCH0LcZFBWoz3p3ZMgQPG9lFwQNFVR3WUR8gc9EmPjdh5gKRo4nEuCV0ky +yNg== X-Gm-Message-State: ACrzQf131SvRTx0GvegUSBeLq8hfwpZfAYy8Br5EdV5OzuGUc/XHRw2t 8GBTY1gQ1s5n1vQrshIc4aU= X-Received: by 2002:a05:620a:95b:b0:6ec:90d2:5fe7 with SMTP id w27-20020a05620a095b00b006ec90d25fe7mr2780802qkw.425.1665864452850; Sat, 15 Oct 2022 13:07:32 -0700 (PDT) Received: from pop-os.attlocal.net ([2600:1700:65a0:ab60:b8b9:b1cd:e6fc:2d50]) by smtp.gmail.com with ESMTPSA id 3-20020ac84e83000000b0039c7b9522ecsm4815812qtp.35.2022.10.15.13.07.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 15 Oct 2022 13:07:32 -0700 (PDT) Message-ID: <634b1304.c80a0220.cedc6.e007@mx.google.com> X-Google-Original-Message-ID: (raw) From: Cong Wang X-Google-Original-From: Cong Wang To: edumazet@google.com Cc: cong.wang@bytedance.com, davem@davemloft.net, dsahern@kernel.org, kuba@kernel.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, pabeni@redhat.com, peilin.ye@bytedance.com, yepeilin.cs@gmail.com, yoshfuji@linux-ipv6.org Subject: Re: [PATCH net-next] net/sock: Introduce trace_sk_data_ready() Date: Sat, 15 Oct 2022 13:07:29 -0700 X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220928221514.27350-1-yepeilin.cs@gmail.com> References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Sep 29, 2022 at 09:19:34AM -0700, Eric Dumazet wrote: > Second patch adding the tracing point once in the helper ? > > Alternatively, why not add the tracepoint directly in the called > functions (we have few of them), > instead of all call points ? Why do we want to give implementations of sk_data_ready() freedom to not to call this trace_sk_data_ready()? Thanks.