Received: by 2002:a05:6358:1087:b0:cb:c9d3:cd90 with SMTP id j7csp2831247rwi; Sat, 15 Oct 2022 23:47:48 -0700 (PDT) X-Google-Smtp-Source: AMsMyM701hXCcdNbS6WwyQ4KhLLAFnbsqYNw9Ku4vfLaPeZKd1ukwYxmbpeUm/sb/m/kCHIxf0GF X-Received: by 2002:a05:6402:254f:b0:45d:3044:d679 with SMTP id l15-20020a056402254f00b0045d3044d679mr5193875edb.137.1665902868492; Sat, 15 Oct 2022 23:47:48 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1665902868; cv=none; d=google.com; s=arc-20160816; b=lwo5VWH2UBLVNZqSRBkP74gPz7EOsA+6sJR4+mUhuyoxP6SWLc+1YUlydCsyn/lAVO SJMZn4w3/gAqHEsG6XVF5KVReUu+nR/ESYTSt6O3Bz3Vamrb6ETMrcUAoUaR++4bnhAL V2bMiKvFTab6Nzq16EHpGx2aqEnQYq99et06+F5Sa+5WvjBzIpSwg4F8fPxI6UfP1yju 2zvkUD/S+dN669fDpQRAz/K743SkvKVeKYgu15/UrEXduwE4G70fDGTTJ82dixGCUyLe /zA97oFF376ziKGuMJOWsrY0RdPmI/C9DVQ286u4uifkTBhEKDcgbsGMooJhonaAlC1o qIKQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=uIDeXx9iAFY6kfTEi1ro93fsdK9aeob0O2v3ZTlEnyQ=; b=J5Bqh9AWB9+bAJEVO5ukRAH2bUxTlx963z4IOYzda0vMUE9eV1dQMsIsFsN2J96Gk2 Ipm+uvVYqNuDPygAeP6VscSU130/FDfg3EF+4sLQpWSVNgvsR6PezJzVMmCaw/Vw/jrx Ru3Vl/HhFpEKmZTMJFYelzIP5mYDOx2WTDBP+Dr5VbgCvzCH6ib8Ar3wT7HMt1wRmL54 SJu2JVjDQBVs7T2INifjn22cB+KOC2bTp4BuKhYWQXlCx3pxarTdg7nHZUPN/ZjOqbLe pSHCg6gPGiiuZe4B0Eza1SpHCK9OU4LrK9aRFRTqSGuNhxD+gaXxQl426u8yXifU5lgf TBCQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=dksST5ma; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id g11-20020a170906520b00b0078334ccc570si6019484ejm.328.2022.10.15.23.47.23; Sat, 15 Oct 2022 23:47:48 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=dksST5ma; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229818AbiJPGpu (ORCPT + 99 others); Sun, 16 Oct 2022 02:45:50 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38866 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229802AbiJPGpo (ORCPT ); Sun, 16 Oct 2022 02:45:44 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6794A3743B; Sat, 15 Oct 2022 23:45:42 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id C08DDB80B65; Sun, 16 Oct 2022 06:45:40 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3220EC433C1; Sun, 16 Oct 2022 06:45:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1665902739; bh=wJQ0U41KLRy5gUD5LL0D8LqduAlTFDOlhxPc+h6eaFI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=dksST5maNe3bQNWUDD2pVGfR5qfSyR2G9gBGUksi2ggllnISIr938ceIJQy497l5A NZJsjCe8MtPHFPrmfVkQyiXkxFt70G0lu07PjzxjvHa5QHM5RH3TEPcMt6M6y69Lkn CUJOR38YHAeWhVW6HTbL4nnvf6RJwwJpeFQko0V8= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Johannes Berg Subject: [PATCH 5.10 3/4] wifi: mac80211: dont parse mbssid in assoc response Date: Sun, 16 Oct 2022 08:46:13 +0200 Message-Id: <20221016064454.487620750@linuxfoundation.org> X-Mailer: git-send-email 2.38.0 In-Reply-To: <20221016064454.382206984@linuxfoundation.org> References: <20221016064454.382206984@linuxfoundation.org> User-Agent: quilt/0.67 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Johannes Berg This is simply not valid and simplifies the next commit. I'll make a separate patch for this in the current main tree as well. Signed-off-by: Johannes Berg Signed-off-by: Greg Kroah-Hartman --- net/mac80211/mlme.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) --- a/net/mac80211/mlme.c +++ b/net/mac80211/mlme.c @@ -3300,7 +3300,7 @@ static bool ieee80211_assoc_success(stru } capab_info = le16_to_cpu(mgmt->u.assoc_resp.capab_info); ieee802_11_parse_elems(pos, len - (pos - (u8 *)mgmt), false, elems, - mgmt->bssid, assoc_data->bss->bssid); + mgmt->bssid, NULL); if (elems->aid_resp) aid = le16_to_cpu(elems->aid_resp->aid); @@ -3708,7 +3708,7 @@ static void ieee80211_rx_mgmt_assoc_resp return; ieee802_11_parse_elems(pos, len - (pos - (u8 *)mgmt), false, &elems, - mgmt->bssid, assoc_data->bss->bssid); + mgmt->bssid, NULL); if (status_code == WLAN_STATUS_ASSOC_REJECTED_TEMPORARILY && elems.timeout_int &&