Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <4702a242-da55-f0c7-eab6-5329b8e400ae@manjaro.org>
Date:   Sun, 16 Oct 2022 11:56:59 +0200
MIME-Version: 1.0
Subject: Re: [PATCH v3 00/13] Add support for the Hardkernel ODROID-M1 board
Content-Language: da-DK
From:   Dan Johansen <strit@manjaro.org>
To:     Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Heiko Stuebner <heiko@sntech.de>,
        "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
        <devicetree@vger.kernel.org>,
        "moderated list:ARM/Rockchip SoC support" 
        <linux-arm-kernel@lists.infradead.org>,
        "open list:ARM/Rockchip SoC support" 
        <linux-rockchip@lists.infradead.org>,
        open list <linux-kernel@vger.kernel.org>,
        Dongjin Kim <tobetter@gmail.com>
References: <20220930051246.391614-1-aurelien@aurel32.net>
 <8e84786d-8ae9-0f51-3438-24fb340199c6@manjaro.org>
 <Y0GA92rYss1Wslgr@aurel32.net> <Y0sAXpecR7AVSOBI@aurel32.net>
 <b50af49c-7ef7-4377-7505-ef6163a12e4e@manjaro.org>
Organization: Manjaro ARM
In-Reply-To: <b50af49c-7ef7-4377-7505-ef6163a12e4e@manjaro.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk


Den 16.10.2022 kl. 11.35 skrev Dan Johansen:
> Trying to apply the patchset, but patch 3 does not seem to apply on 
> top of patch 2 for me.
>
> We do patch in other rk3568 boards, which is messing up the Makefile 
> patching, so I needed to redo patch 2 to fit.
>
> So it might an error on my part.

Yes. This was an error on my part. Not applying the other rk3568 board 
patches we have, this does apply cleanly.

Sorry for the noise/confusion on that. Will reply shortly with an answer 
to the original question.

>
> Den 15.10.2022 kl. 20.47 skrev Aurelien Jarno:
>> On 2022-10-08 15:53, Aurelien Jarno wrote:
>>> On 2022-10-08 14:11, Dan Johansen wrote:
>>>> Den 30.09.2022 kl. 07.12 skrev Aurelien Jarno:
>>>>> On the ODROID forum, Dongjin Kim said he is not planning to submit 
>>>>> a new
>>>>> version of the patchset adding support for the Hardkernel ODROID-M1
>>>>> board. I therefore decided to address the issues reported during the
>>>>> initial review, and I also did some small fixes either because some
>>>>> things changed in the meantime on the kernel side or because I 
>>>>> noticed
>>>>> some warning or issues when using the hardware.
>>>>>
>>>>> I continued writing some additional patches to complete the ODROID M1
>>>>> DTS to almost fully support the hardware, the drivers being already
>>>>> present in the kernel.
>>>>>
>>>>> This new version includes feedback from the linux-rockchip mailing 
>>>>> list
>>>>> and from the Odroid forum.
>>>>>
>>>>> Changes since v2:
>>>>> * Renamed "Rockchip RK3568 Hardkernel ODROID-M1" into "Hardkernel 
>>>>> Odroid
>>>>>     M1" and fix the sorting.
>>>>> * Fix sorting of arch/arm64/boot/dts/rockchip/Makefile
>>>>> * Collected Acked-by and Tested-by
>>>> Even though I added my Tested-by to this series, it seems I didn't 
>>>> test it
>>>> on eMMC.
>>>>
>>>> This fails to boot for me on eMMC, but works on SD card and NVMe.
>>> Thanks for the feedback. I do not have an eMMC, so this the only part
>>> from the patchset that I haven't been able to test.
>>>
>>> First of all, which version have you tested? The v2 includes fixes for
>>> the eMMC, there was a conflict with the NOR flash. If the problem is
>>> still there in the v2, could you please send the boot log or the error
>>> message?
>> Sorry I meant v3 above. Anyway in the meantime I have bought an eMMC,
>> and I confirm that:
>> - it does no work with the v2 due to a conflict with the NOR flash
>>    driver
>> - it does work with the v3
>>
>> Therefore can you please retry with the v3?
>>
>> Thanks
>> Aurelien
>>
-- 
Kind regards
*Dan Johansen*
Project lead of the *Manjaro ARM* project
Manjaro-ARM <https://manjaro.org>