Received: by 2002:a05:6358:1087:b0:cb:c9d3:cd90 with SMTP id j7csp3172701rwi; Sun, 16 Oct 2022 06:29:18 -0700 (PDT) X-Google-Smtp-Source: AMsMyM6CCkmSPfy+h6gdoXwoTnuDrxChKKEVG+Fb5W582qLQ/vIaA/XAvscRJlbtBkTkttpOD6/w X-Received: by 2002:a17:906:36d1:b0:76c:a723:9445 with SMTP id b17-20020a17090636d100b0076ca7239445mr4954330ejc.548.1665926957647; Sun, 16 Oct 2022 06:29:17 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1665926957; cv=none; d=google.com; s=arc-20160816; b=Wp7WaD31afHHS5gZxTHb8X89+suh8e71tqXBvkeyynCogfETgC/4BEYuLvWz5brtzE sjWNDHmEWy/Jtu+5hQOM3Wy2w+ld/mzfW+FCDik6p0ev44ldfNoj65SVnI/y7drkiXk1 QmtqoV1wqIkV1iXZm/WY6Z08k6GU1XuXeLRLkCBPh+Jq6MQv71UUY5T64Letb08+XDLt UTaRD57m3QeInRj0lvYjVGpo1s1nZzeLOOSQAQ9Yp0JTj6TTEhEioVztHPTfkUY1ZsKF Q1FD4c65NHH8oMkAE1aSnrZ1rTVV6Du2h2ud5rPXYeDI3oX9TC5ehg/Dg1SWaZOxZsNj RFiw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:feedback-id :dkim-signature:dkim-signature; bh=luOh1+tXqD7JMWO63diGmzw1lVMjKMj3+nXqqj2Jd70=; b=UDEcr+axk4rUWt9+djJvEMG9jkzHb4jR38wfVLhSL5GPcgHBFz/TnrhNMvVbioEXrH f5NeU8IRFDoVwKDzpbqOn0E03BakPdZMxaigoV2Hu8nUkgvN/AStXHLHtudvuXAtdALH jRKi/dkfZwIAjLroXVmmJxPeEcxSFUHsTiP2UZYuytqvCaAWj7mT8GfKAF2nT3gw8ELq kHAXQDHZSnUITfqQVUdnfpIccYjDGyiQiYuOtdlXnt/m8G+WFxYk6XQ9caIdocSG/ovu JQkY0ZB/HhY098BZjMiIYFwapzrNIdKXjbdPtf7vUyu+8wuIZg5wWZh0T0hU3Oyx6B/R q31Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@joshtriplett.org header.s=fm2 header.b=VJKFc1tW; dkim=pass header.i=@messagingengine.com header.s=fm3 header.b=pWHazTuK; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id jg35-20020a170907972300b0078d220fa8d0si6385306ejc.641.2022.10.16.06.28.34; Sun, 16 Oct 2022 06:29:17 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@joshtriplett.org header.s=fm2 header.b=VJKFc1tW; dkim=pass header.i=@messagingengine.com header.s=fm3 header.b=pWHazTuK; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229646AbiJPNXb (ORCPT + 99 others); Sun, 16 Oct 2022 09:23:31 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44382 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229661AbiJPNXM (ORCPT ); Sun, 16 Oct 2022 09:23:12 -0400 Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 619C832DBB; Sun, 16 Oct 2022 06:23:11 -0700 (PDT) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 2EDBE5C0065; Sun, 16 Oct 2022 09:23:08 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Sun, 16 Oct 2022 09:23:08 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= joshtriplett.org; h=cc:cc:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm2; t=1665926588; x= 1666012988; bh=luOh1+tXqD7JMWO63diGmzw1lVMjKMj3+nXqqj2Jd70=; b=V JKFc1tWmuQAc4v127ngF04vXL5JVjXdfS0zg5lUuQYjC87yz/n+NHZJ3PA3P+swu /sTXP3WN9oxQZXh7mGYkbsK43JMklb7UNDDBh/mmasVfTKKd++Vrp5XCu3w20LYY lJhXiHgwLRBRhbPE2hp+4gtBQluEZ3DSZZcDaAGGx060Mwsg5iUQrmT7U03H2ASc EPpteLYSFDjLuqDXiVos4sWgMOMg+xecoHR+PvSOO+ZcBVbN5ozApw17wxse2nt2 +xn7vG0OKHhQradz7iny4eVeNvlqA5voxMDzf31Qq3S3d+EWEjywf4oG46IkBiDa i+Gme8oJ/zPEqXAlBOGpQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm3; t=1665926588; x=1666012988; bh=luOh1+tXqD7JMWO63diGmzw1lVMj KMj3+nXqqj2Jd70=; b=pWHazTuKjzH67V5VKZSaxNo5eNnpEq19tt0JhIszsFg7 W+OLBVTRoT7/E0dNwKPdTlI60ZM+l9JjkfhLqC45UtiliY+WwOJCqoUm8r+9Ou3x RMAyDMNb0ksTbzl4iwKtomOtkq3NH39NJI7uAdUY626QqEVDqrIu0XYU//ts0mVt 09LzGnAKAqXpjTD1I5s7mEMiv6w+QdgfenJiSBM2GHS+pn53bWXzNcRPaYcXQUiL hh+H23qvIG3eDjvF9XGocMw5nZRhJA4SobGf0vKpXvfX99ykmqDVkV+pnEFhF0r2 teEebRoMa8kKHFkp+/EcvCGTihVclI2VQguqCTrNmQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrfeekjedgieegucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvfevuffkfhggtggujgesthdtredttddtvdenucfhrhhomheplfhoshhh ucfvrhhiphhlvghtthcuoehjohhshhesjhhoshhhthhrihhplhgvthhtrdhorhhgqeenuc ggtffrrghtthgvrhhnpeduieegheeijeeuvdetudefvedtjeefgeeufefghfekgfelfeet teelvddtffetgfenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfh hrohhmpehjohhshhesjhhoshhhthhrihhplhgvthhtrdhorhhg X-ME-Proxy: Feedback-ID: i83e94755:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sun, 16 Oct 2022 09:23:06 -0400 (EDT) Date: Sun, 16 Oct 2022 14:23:02 +0100 From: Josh Triplett To: Olliver Schinagl Cc: Gary Guo , Miguel Ojeda , Miguel Ojeda , Linus Torvalds , Greg Kroah-Hartman , rust-for-linux , Linux Kbuild mailing list , Linux Doc Mailing List , linux-kernel Subject: Re: [PATCH 00/13] [RFC] Rust support Message-ID: References: <20210414184604.23473-1-ojeda@kernel.org> <5c0bb1db-5589-32ca-ac22-4aafb3c15751@schinagl.nl> <20220728112114.0000003a@garyguo.net> <00604162-9157-3862-b463-de90cb17c69a@schinagl.nl> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <00604162-9157-3862-b463-de90cb17c69a@schinagl.nl> X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,SPF_HELO_PASS, SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Oct 15, 2022 at 04:16:14PM +0200, Olliver Schinagl wrote: > +indent_style = "Visual" Without commenting on the rest of this: visual indent style produces a *lot* of diff noise, and I'd strongly recommend against it. Because it lines things up, a change to one line can change many adjacent lines, and make it hard to see what actually changed.