Received: by 2002:a05:6358:1087:b0:cb:c9d3:cd90 with SMTP id j7csp3243643rwi; Sun, 16 Oct 2022 07:35:26 -0700 (PDT) X-Google-Smtp-Source: AMsMyM46PA3TIq6ZQszxw6KULgMVc9zt5Rwj5k1rr+CLiWQniAfjCi3mMu7anU+Cm4wGdZQNRnBa X-Received: by 2002:a17:90b:4ac1:b0:20a:de32:3650 with SMTP id mh1-20020a17090b4ac100b0020ade323650mr27621604pjb.142.1665930926058; Sun, 16 Oct 2022 07:35:26 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1665930926; cv=none; d=google.com; s=arc-20160816; b=hRYQ8G/SyuKPjBH69Wang4IxWev6C5zyTVXhGgWHe5OysuHxmFdL0YXetPFHOzk1NQ 4uCI6sndyVQGTNv4O5cs4WN6aV5jsFWFjI3siFE+CgE0Qmbte89AnGKLqTcttw9AWmOP 5Et5g+8OgN6FR5nS3+vShOhxY9me9johsQoNOREjdhMNUKcD3yVpiALnL8tDmned+AWo 9xw+ZIi/pLllQIloJHEub+HmGddyCPn1eiVgZrhkWnDATPJn1Ck0pBHC8J8dA/peSYcY pzzvqzSYeNweSwHkc/RX329qV0GQUTjdTDaOogyKBQHkrhLjyskS30qo30yF38VYnMrY Ksog== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=9ncZtmCzF3uCeRnv+zI+QEEYEIHkuJd/cuabntwMius=; b=Ey9st+K4NlGmLEhrGyMwB7JmlCw+LZvHPw8gHE4R2OIry3EMYe22VAPoprj+SGGIlY CkVcsAhClIaWS/86OPrkN8LP0DqOcORB3AG4HHPqJSUHAh7q0ZrWBsztlyQCovst1ift mEIO4mOzSc0zCkkmgwdxwrB+OivC3VAbaHmGalbY4tTONoJtlCJVRIM8uweMb6mfanJt X2i4C6TrbCZjR7YqrQIKZw1/6SEPhuvBdKVH+Cn8l3HCrnqAQihRnN4yooPcpQIM4+uP Wb+6sb+TzthV1lfqOV5NR02JUJjmBpDjJWJR8sKVBA6CSHI7Y649xEi3/QccF4TQLiAj jrLw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="bs+Pd/2s"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id r4-20020a654984000000b0046408c6d349si8417855pgs.478.2022.10.16.07.34.58; Sun, 16 Oct 2022 07:35:26 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="bs+Pd/2s"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229843AbiJPN2n (ORCPT + 99 others); Sun, 16 Oct 2022 09:28:43 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56720 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229785AbiJPN20 (ORCPT ); Sun, 16 Oct 2022 09:28:26 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6E4C73F1E9; Sun, 16 Oct 2022 06:28:02 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 6A7AFB80CC0; Sun, 16 Oct 2022 13:28:00 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id EFB0FC433C1; Sun, 16 Oct 2022 13:27:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1665926879; bh=BLlob7SHUpruAi1BQqz6CpLZq1PD5IlI3db/6R/GyA0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=bs+Pd/2sF2NT7mDeDPfBSJcubgRHNDQXi7Zjaff8kj5CXlzW4lZEaOb9FHxgLdMtn r7IZkeV7EGjNafUVhogKlNtM+YnnWaWIIfJ9V75ABHe94uXqjt29iNlJsr/S/VAM93 MkpdwR611t6j4EzJvPDmGdpLLuqJcjiOe0DNhPDyGOiIu5U6X8KUfGxnRB/tgYca8q Khjp6Bh6wO49OKDzzToYWmLzcT3+7mJJNgS5/PTZrLNZVXeLA+FYK8WCG6xIna9aXt vXSPt50v4+HS+Qf5VhYK7AuwQSVuWWWEZfd9sotgoiYduaFVMNw5Mqs2V7jVigw1s+ dnhpBrgCeGgjQ== Date: Sun, 16 Oct 2022 09:27:57 -0400 From: Sasha Levin To: Jiri Slaby Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org, Daniel Starke , kernel test robot , Greg Kroah-Hartman Subject: Re: [PATCH AUTOSEL 5.15 34/47] tty: n_gsm: replace use of gsm_read_ea() with gsm_read_ea_val() Message-ID: References: <20221013002124.1894077-1-sashal@kernel.org> <20221013002124.1894077-34-sashal@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-7.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Oct 13, 2022 at 08:21:37AM +0200, Jiri Slaby wrote: >On 13. 10. 22, 2:21, Sasha Levin wrote: >>From: Daniel Starke >> >>[ Upstream commit 669609cea1d294f43efdd8d57ab65927df90e6df ] >> >>Replace the use of gsm_read_ea() with gsm_read_ea_val() where applicable to >>improve code readability and avoid errors like in the past. See first link >>below for reference. > >I don't think this warrants for stable. It's only a cleanup, not a >fix. And it's quite intrusive. I'll drop it, thanks! -- Thanks, Sasha