Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Sun, 16 Oct 2022 11:50:45 -0400
From:   Deepak R Varma <drv@mailo.com>
To:     Greg KH <gregkh@linuxfoundation.org>
Cc:     Julia Lawall <julia.lawall@inria.fr>, outreachy@lists.linux.dev,
        pure.logic@nexus-software.ie, johan@kernel.org, elder@kernel.org,
        greybus-dev@lists.linaro.org, linux-staging@lists.linux.dev,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: greybus: loopback: enclose macro statements in
 do-while loop
Message-ID: <Y0woVSgGfUuvJUzY@debian-BULLSEYE-live-builder-AMD64>
References: <Y0wS4HQo9m/W/TrQ@debian-BULLSEYE-live-builder-AMD64>
 <alpine.DEB.2.22.394.2210161649400.2876@hadrien>
 <Y0wdDTUBrUT/cr9w@lion2204>
 <alpine.DEB.2.22.394.2210161709440.2876@hadrien>
 <Y0wi4itS3d8aExFc@debian-BULLSEYE-live-builder-AMD64>
 <Y0wmC2oi0TOpvpPM@kroah.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <Y0wmC2oi0TOpvpPM@kroah.com>
Precedence: bulk

On Sun, Oct 16, 2022 at 05:40:59PM +0200, Greg KH wrote:
> On Sun, Oct 16, 2022 at 11:27:30AM -0400, Deepak R Varma wrote:
> > On Sun, Oct 16, 2022 at 05:10:17PM +0200, Julia Lawall wrote:
> > >
> > >
> > > On Sun, 16 Oct 2022, Deepak R Varma wrote:
> > >
> > > > On Sun, Oct 16, 2022 at 04:51:09PM +0200, Julia Lawall wrote:
> > > > >
> > > > >
> > > > > On Sun, 16 Oct 2022, Deepak R Varma wrote:
> > > > >
> > > > > > Include multiple statements of macro definition inside do-while{0} loop
> > > > > > to avoid possible partial program execution. Issue reported by
> > > > > > checkpatch script:
> > > > > >
> > > > > > ERROR: Macros with multiple statements should be enclosed in a do - while loop
> > > > >
> > > > > I don't think this change will compile.  See if you can figure out why
> > > > > not.
> > > >
> > > > It did compile. I built the greybus driver and loaded it as well with the
> > > > modinfo tool. Can you please tell why you think it won't compile?
> > >
> > > Do you have a .o file for the .c file that you changed?
> >
> > I see many .o files and a greybus.ko as well, but not the loopback.o
> > Am I missing anything with my configuration? I did set Greybus Support to (M) in
> > the menuconfig.
>
> CONFIG_GREYBUS_LOOPBACK has to be enabled in order to build the
> drivers/staging/greybus/loopback.c file.
>
> A simple check would be to do:
> 	make drivers/staging/greybus/loopback.o
>
> does that work with your change?

No, it did not. I understand why it did not. My apologies for not looking into
the build of loopback.o file when the greybus module was rebuilt.

Please ignore my patch.

Thank you Julia and Greg for the feedback.
./drv


>
> thanks,
>
> greg k-h
>