Received: by 2002:a05:6358:1087:b0:cb:c9d3:cd90 with SMTP id j7csp3353416rwi; Sun, 16 Oct 2022 09:22:17 -0700 (PDT) X-Google-Smtp-Source: AMsMyM7C/aShdj6IcchKPY/lY3MBR//ATsRj4czzN2VbjWY3+W+bT28OTyqADoanzu6PKeFejbOS X-Received: by 2002:a17:907:2cf5:b0:78d:f9cc:794a with SMTP id hz21-20020a1709072cf500b0078df9cc794amr5451674ejc.577.1665937337498; Sun, 16 Oct 2022 09:22:17 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1665937337; cv=none; d=google.com; s=arc-20160816; b=qAcGUsmsSzmkYHJB8chjfpKHBAYMT5xfj3WaAQNG39B7mbGbtcC6fkN68w5D2QGDOk h045p3vNm5IrcRSLPI7OBfDM6CVy3JgBPNsTB+CeX9dVZueyquJw75BC+TzDQyaCwSJZ 8UMZATa+BXnuTNYhCOAuwX5XLepCeKMx1ey2YL/lpNI3hSDmCmPJoYEwj12PppPjTApA v5WX6kcySy+H3s9qKpJsuI+wr+nnoAxiCNMvtwRDxkLpb0hOoLWWPsX97c/7/mVYdfUu VT7pmFdLOqWzxFpL1B2v2wAvCpe3H6fZT4uPoyVVN45vk47QlWwYR5jwIozGHWVUUEsR LxLg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=m3LYKi4QF1dK67Q9dyFYJl+Pk8h5LwmOPS1K/m5Go2Q=; b=D4xJ3RFP/gS7xklKN4L8bgOcPsGdbYbRRas1Ht09GILXFS2nRGfEUGu45B/uLwJuz3 6NBVim6ZH4TyaQLx47Wy3i9ysUbexiLZJ/iHgfp3RglHlxeXOvnI0vm/3yyc1k9+rbRF UsfwQzS2iKDIeqJfUnztgsr+iQrd3igJOR1XJnBYsSyFkQD+6OF1aE5x43ureAKd96Nu sMXuFu6T9ZxKkOQ9igRij0ae1iIPAjNe0P77E81/WWtMHeTF4ydf8kgvRnHu3d9MN38P Tgr6PJ+jcFZM+u0w77U0/uT0R26F47ZAE48lQd2vp6TUVKlpa1NWCIhram7XSWPaH7fD 8TgA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=AfoDb2AC; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id u23-20020a056402065700b004590d914310si6336338edx.631.2022.10.16.09.21.51; Sun, 16 Oct 2022 09:22:17 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=AfoDb2AC; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229870AbiJPQSO (ORCPT + 99 others); Sun, 16 Oct 2022 12:18:14 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47892 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229801AbiJPQSM (ORCPT ); Sun, 16 Oct 2022 12:18:12 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 680DA3B720; Sun, 16 Oct 2022 09:18:11 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 0482C60BD3; Sun, 16 Oct 2022 16:18:11 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6A569C433D6; Sun, 16 Oct 2022 16:18:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1665937090; bh=m3LYKi4QF1dK67Q9dyFYJl+Pk8h5LwmOPS1K/m5Go2Q=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=AfoDb2ACUZLkxtnZxuTmL7m6n6PEteKKxOLixOR9uVs2kf5klsLYen+wmiskV62qk B0+55jEuqFFYfkwO2kRiM6oAXG6ml0r6d+3Q/Fhl8b5OVhDm0svn1NM4Xv8vvlLxHw 33Un2yBal/Uo9GzgrCVvJu444kFGaKNW4ilHajFRBTm2HO102hV8mK5ALXOYv+jNfu eN3phi3XCh8F+0a4Ti5liFwxJeSXTfNVOqBFhkrQwZCiHJVPvKfO/6vYW9pIFTR3Ke OQGMDRw9rKn0ghzVrtIfWeMU4GYqvWDKiRQ0FeOpLK27vSnMhxUyLmnJ6l8ue3f0ph GBamap/sH9/Ng== Date: Sun, 16 Oct 2022 17:18:38 +0100 From: Jonathan Cameron To: "Sa, Nuno" Cc: Matti Vaittinen , Matti Vaittinen , Lars-Peter Clausen , Alexandru Ardelean , "linux-iio@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH v3 13/14] iio: max1363: simplify using devm_regulator_get_enable() Message-ID: <20221016171838.22669a2a@jic23-huawei> In-Reply-To: References: <1286ea127d190e5708a0aaff271819b2d3f8802d.1660934107.git.mazziesaccount@gmail.com> X-Mailer: Claws Mail 4.1.0 (GTK 3.24.34; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-7.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 30 Aug 2022 11:50:05 +0000 "Sa, Nuno" wrote: > > -----Original Message----- > > From: Matti Vaittinen > > Sent: Friday, August 19, 2022 9:21 PM > > To: Matti Vaittinen ; Matti Vaittinen > > > > Cc: Jonathan Cameron ; Lars-Peter Clausen > > ; Matti Vaittinen ; > > Alexandru Ardelean ; linux- > > iio@vger.kernel.org; linux-kernel@vger.kernel.org > > Subject: [PATCH v3 13/14] iio: max1363: simplify using > > devm_regulator_get_enable() > >=20 > > [External] > >=20 > > Drop open-coded pattern: 'devm_regulator_get(), regulator_enable(), > > add_action_or_reset(regulator_disable)' and use the > > devm_regulator_get_enable() and drop the pointer to the regulator. > > This simplifies code and makes it less tempting to add manual control > > for the regulator which is also controlled by devm. > >=20 > > Signed-off-by: Matti Vaittinen > >=20 > > --- =20 >=20 > Acked-by: Nuno S=C3=A1 Applied.