Received: by 2002:a05:6358:1087:b0:cb:c9d3:cd90 with SMTP id j7csp3381286rwi; Sun, 16 Oct 2022 09:53:33 -0700 (PDT) X-Google-Smtp-Source: AMsMyM6KDUC5LiXT8GZn/yxY8Z50RkBr01HPfjzUIQCg7jMi+t0WuBts1DStp+mpg2Rij4jCj0jJ X-Received: by 2002:a17:903:2585:b0:185:483e:e4ce with SMTP id jb5-20020a170903258500b00185483ee4cemr7766442plb.17.1665939212920; Sun, 16 Oct 2022 09:53:32 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1665939212; cv=none; d=google.com; s=arc-20160816; b=BVbs71VYJ87ZVJsnr8TJGeq1g6I0AFZ+fSKQxbldhmT+Yprun/0j5EMhY+2dwgKBvU RyEgu9fp+mHB2Ixoi/gCZD+rvL8R9k6nHEZgAMKNznUTLYCbZc0X+KQX3PBxCYwCqJq5 SopyjhpLTBMPqgSdAvkTPjZceIpptvFt7VcSz3eUjyVoPtV91Iky6KopvcNxb6Kdptfa u34d6ZTA/W3WgjWd5F4u0PORe3enBWcxogLGl5VVo0q5ALXJ0Z3MQF49/N85HxEZLV7K JUkwkd7qI+zCDEH9I48+sNDSEoHT54e34SIRqzI4kJaLJloE7e5d6ewEbRyFDDJ/e7Ue 0KJg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=0WCJPBVy2SyjaIJlfagPnuweTaDaxafE9N0R3A9wkyc=; b=l4X94CPutIL6K40E/98FWuaT0Rn7syySqJmz/DzAnlMCsS1E8qEtQ262L96sO0nu/R NbjB9YWlXedhy6wNsG2hGR/EIc0VHT6OpjZ5zYULn9QmolgeZBt4nFJg4d/7r5mGRZIf yuUXxsNs635tB5S0M4/Hjd2zwacwvPFMf6wu/g6XhoO5VLCUvSTG2F68P4rZOVIPcjZL zySkoeHYmV1eRplyk7j3wVWP463NaEFCm/hO4KoEnVsyNyCUAkZ5XZrnVvKbDr0xuzJn 0Z8wdtVjUa1SGtO/TwxcKFu6YF6u3sX8bWSd/3AiwBhpU4EkSHm7bbQ6PV+JyWIuLL3E xwag== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="FIxi0/mP"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id l14-20020a170903120e00b001823a7b6c7esi10759583plh.585.2022.10.16.09.53.16; Sun, 16 Oct 2022 09:53:32 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="FIxi0/mP"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229820AbiJPQhA (ORCPT + 99 others); Sun, 16 Oct 2022 12:37:00 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35368 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229597AbiJPQg6 (ORCPT ); Sun, 16 Oct 2022 12:36:58 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E31153684C; Sun, 16 Oct 2022 09:36:57 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id A2C5BB80B67; Sun, 16 Oct 2022 16:36:56 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7DCA6C433D6; Sun, 16 Oct 2022 16:36:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1665938215; bh=JCCTbWupmkrNEddZayM59JFGMIafAlFS8/eA55XBEDk=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=FIxi0/mPqWefzgRNZImNyUt4qv9xQMT+g1xc6K5iF1oRhqi+Yj9IY31lkJ/FVTs+4 o3TL3ykXLtdDMQ0oZ1ipDPYg4JvzVULmh5RSrkakDWXfMYV7Q5aPdwNRiShmtr+R+1 g6LFHyN49Ca0WGaTBcFD83SI2z8YqivvP/BtWBq3VL44iuluLjxB7ZJhfe5CXdDkNd 6f2vrrRxyWVzYgr+iAxvTmzutKajHyq4RHpVPgR1iQHErmRnRL0HtdegywH3zAphqt xTupcR09YBaExDiRlLaLAnyKVJA+P+GE1pma09w3kO5P+h2SmWiT1ExPIw+MzHtFUu 3VCQDR3JOoGdg== Date: Sun, 16 Oct 2022 17:37:23 +0100 From: Jonathan Cameron To: "Sa, Nuno" Cc: Matti Vaittinen , Matti Vaittinen , Lars-Peter Clausen , Alexandru Ardelean , "linux-iio@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH v3 13/14] iio: max1363: simplify using devm_regulator_get_enable() Message-ID: <20221016173723.31edc35d@jic23-huawei> In-Reply-To: <20221016171838.22669a2a@jic23-huawei> References: <1286ea127d190e5708a0aaff271819b2d3f8802d.1660934107.git.mazziesaccount@gmail.com> <20221016171838.22669a2a@jic23-huawei> X-Mailer: Claws Mail 4.1.0 (GTK 3.24.34; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-7.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 16 Oct 2022 17:18:38 +0100 Jonathan Cameron wrote: > On Tue, 30 Aug 2022 11:50:05 +0000 > "Sa, Nuno" wrote: >=20 > > > -----Original Message----- > > > From: Matti Vaittinen > > > Sent: Friday, August 19, 2022 9:21 PM > > > To: Matti Vaittinen ; Matti Vaittinen > > > > > > Cc: Jonathan Cameron ; Lars-Peter Clausen > > > ; Matti Vaittinen ; > > > Alexandru Ardelean ; linux- > > > iio@vger.kernel.org; linux-kernel@vger.kernel.org > > > Subject: [PATCH v3 13/14] iio: max1363: simplify using > > > devm_regulator_get_enable() > > >=20 > > > [External] > > >=20 > > > Drop open-coded pattern: 'devm_regulator_get(), regulator_enable(), > > > add_action_or_reset(regulator_disable)' and use the > > > devm_regulator_get_enable() and drop the pointer to the regulator. > > > This simplifies code and makes it less tempting to add manual control > > > for the regulator which is also controlled by devm. > > >=20 > > > Signed-off-by: Matti Vaittinen > > >=20 > > > --- =20 > >=20 > > Acked-by: Nuno S=C3=A1 =20 >=20 > Applied. This one was missing cleaning up the docs as well. fixed up.