Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   "Wang, Wei W" <wei.w.wang@intel.com>
To:     "Christopherson,, Sean" <seanjc@google.com>,
        Vipin Sharma <vipinsh@google.com>
CC:     David Matlack <dmatlack@google.com>,
        "andrew.jones@linux.dev" <andrew.jones@linux.dev>,
        "pbonzini@redhat.com" <pbonzini@redhat.com>,
        "kvm@vger.kernel.org" <kvm@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH v5 0/5] dirty_log_perf_test vCPU pinning
Thread-Topic: [PATCH v5 0/5] dirty_log_perf_test vCPU pinning
Thread-Index: AQHY3PSo5mk7BJgdskG84RjiFjmwJa4N+zRAgAAgogCAAAXFgIAAGXKAgAAKKgCAAkRCcA==
Date:   Mon, 17 Oct 2022 00:47:33 +0000
Message-ID: <DS0PR11MB6373B2EA960D5FAAC9208320DC299@DS0PR11MB6373.namprd11.prod.outlook.com>
References: <20221010220538.1154054-1-vipinsh@google.com>
 <DS0PR11MB63735576A8FBF80738FF9B76DC249@DS0PR11MB6373.namprd11.prod.outlook.com>
 <Y0mPqNRSgpArgyS8@google.com>
 <CALzav=dU2-3avKGT2-AxO8d_uVH9bmYaO=ym8pPFM8esuSWP=A@mail.gmail.com>
 <CAHVum0d2Jfr=WVxKxvnmwGKzPfV3vN5dbz11=rdcW6qoSoobew@mail.gmail.com>
 <Y0myXiIjlT8pYyr8@google.com>
In-Reply-To: <Y0myXiIjlT8pYyr8@google.com>
Accept-Language: en-US
Content-Language: en-US
dlp-product: dlpe-windows
dlp-reaction: no-action
dlp-version: 11.6.500.17
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?hZ1J2d9f3GRl+uklyIdlDOrd711e225aT/KMShkgRSp9Evq9XoFULWgTKhyw?=
 =?us-ascii?Q?uRjRG/6BHp5LLW9rX7oRNlf0OYRNE1uCR/B9Z3BUcv7/gbo+cVKhK4+boJHF?=
 =?us-ascii?Q?npLb70gmDiBKDl16TZK0zrHzB7tkWwAR4nnNqo12WDQbPObEVqystNJZE3Cs?=
 =?us-ascii?Q?2vfqCerSbFRuzDWHxsDPURtBHW7IDZ3gMrjQioQsJRuZI0LuJmY2Zb7pb23M?=
 =?us-ascii?Q?0WtiqsyYGq8iNFxFz/G9MY5jonztQnGNGBiUPuDd4DlU1Igqia9vdeZsJmzo?=
 =?us-ascii?Q?BITS8ibquaw8rNfdixSikchJntCpDAA4Rp8fwKRIefeSPWVzTOHKvAZ4GUiL?=
 =?us-ascii?Q?kkpUss1C9s5NZFVHdhRPSlEKmW+wTkmq3Z4BOrEk0aOqm0Dffja79nkLaRC4?=
 =?us-ascii?Q?E5JcnLcFCdOjQkTnmDSu+KerOnw4cn0xNIODSCS46PZQghuQ+k7D/T6GzraX?=
 =?us-ascii?Q?iyytCynxzONlQlnZZ3WSTslrQCQI+wOiuOTyDX46TDPQYKmymo/Q1U8sMoIV?=
 =?us-ascii?Q?rwmTo6JwE3HNT7SLV1Lkyivrph0sTHmSskjcEL6tI3BpoiKNKdoeoWJXcxNm?=
 =?us-ascii?Q?Ep0G3MRWvd5MgzSgN5xw5cBBLxGLtwpGJa6fX2MLlq/ATCY7JtHELKgDLwxs?=
 =?us-ascii?Q?D1CPCrzd+KH45VGaLX4UHYYSBphrm8udIMXYl/LyiVybFj6c0Te4quYsaEVz?=
 =?us-ascii?Q?BHszDt9SMI+Y9GL45FEZ83clkuWV4cjuVf1NJd/0N5WsKt/XkGN6k2yxk7cG?=
 =?us-ascii?Q?AZzCvzTMz86OlO7iFnuBIWuBDBg6faiCqPnOrglJ64KPQ93ubP7B6XMLVw5B?=
 =?us-ascii?Q?/UfRPmS7P6hc863+y0wsSn4AxI5hqlFX4ANPMubnimGGSrKXYwYv+qNdTNdH?=
 =?us-ascii?Q?GZTRr+vgszsdlJNnffU3apQO4e4PX2IiMlXfLvofwOS/vj2SWwZT7gEHk2mX?=
 =?us-ascii?Q?t+FoDTSyH+1WhXmezd9FUOa9t+BfZE5a/JcY+6c7tN8xCrISfPjoyxplxP8N?=
 =?us-ascii?Q?+7h1h0Dupw5T/mYR5G7D3KwI8IYLmGi+Ndht+33eNQDCNyGUHX6ZwCrkbwuU?=
 =?us-ascii?Q?ArXhrXqQ8eJqLEuEiMQyRvEsKxcEo+juwAlzqZF+w4lKJUzaA/hMbqA2BfZ3?=
 =?us-ascii?Q?pG8A9TxPNcIzYSRL4lmq/cWsqIzaM5xFH50cv/3ECsLT2Q8gD4rtZ5n9NpXB?=
 =?us-ascii?Q?ycxFognbCqNS8nFSCd2mDPGg5aLcwnLrSGC5hH9l+NluJlrMkpZdyMgViAdl?=
 =?us-ascii?Q?aafxka4U+eVgDhXEtIkPyFYtZET27hpVyvgNKymS2agcRUH2/X9Vqkf6FL4H?=
 =?us-ascii?Q?Z3wawcPszoDaoW5XiGHtyKKznLD2XvFFF13iLZc3K1VIaFSAiBdKS/dlpiBk?=
 =?us-ascii?Q?QDnW8aeW3UbSbG3mmxaUlCYaf6g0S5WI6L6R/Voma17eTwE/RjdouGrfmQlT?=
 =?us-ascii?Q?bCd0+y9E2tBYJHDtO5SaIEsjYUdlJE3UgGwLe/ZPi6LTr3zyPo2uGvx6vLRz?=
 =?us-ascii?Q?KkHLzhvpAHcGNW3LnaTBy/dIuUoS1MDwvMIJ7isRSrNtm5ar+C0uNMROd1cY?=
 =?us-ascii?Q?JEPry4kie+Cmqi/PtIfVOY9IZw4vXbbLndczIvjL?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB6373.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 6d7d63ee-41a3-49e3-bbd8-08daafd92dbe
X-MS-Exchange-CrossTenant-originalarrivaltime: 17 Oct 2022 00:47:33.6428
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 2AVQ9HPAxrs10AfkGiK5NBUWY20T0kusrjQRYFOVf4HU90951YNUlgisY6ZLwYU85xKITEvn7luLpWFSHl9Vpw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM8PR11MB5623
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-7.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI,
        RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Saturday, October 15, 2022 3:03 AM, Sean Christopherson wrote:
> On Fri, Oct 14, 2022, Vipin Sharma wrote:
> > On Fri, Oct 14, 2022 at 9:55 AM David Matlack <dmatlack@google.com>
> wrote:
> > >
> > > On Fri, Oct 14, 2022 at 9:34 AM Sean Christopherson <seanjc@google.co=
m>
> wrote:
> > > >
> > > > On Fri, Oct 14, 2022, Wang, Wei W wrote:
> > > > > Just curious why not re-using the existing tools (e.g. taskset) t=
o do the
> pinning?
> > > >
> > > > IIUC, you're suggesting the test give tasks meaningful names so
> > > > that the user can do taskset on the appropriate tasks?  The goal
> > > > is to ensure vCPUs are pinned before they do any meaningful work.
> > > > I don't see how that can be accomplished with taskset without some
> > > > form of hook in the test to effectively pause the test until the us=
er (or
> some run script) is ready to continue.
> > >
> > > A taskset approach would also be more difficult to incorporate into
> > > automated runs of dirty_log_perf_test.
> > >
> > > >
> > > > Pinning aside, naming the threads is a great idea!  That would
> > > > definitely help debug, e.g. if one vCPU gets stuck or is lagging be=
hind.
> > >
> > > +1
> >
> > I also like the idea.
> >
> > Sean:
> > Do you want a v6 with the naming patch or you will be fine taking v5,
> > if there are no changes needed in v5, and I can send a separate patch
> > for naming?
>=20
> Definitely separate, this is an orthogonal change and I don't think there=
 will be
> any conflict.  If there is a conflict, it will be trivial to resolve.  Bu=
t since Wei
> provided a more or less complete patch, let's let Wei post a formal patch
> (unless he doesn't want to).

Yeah, I'm glad to take care of this. There are other places (e.g. hardware_=
disable_test.c)
that seem good to have this as well, I'll cover them in one patchset.