Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 17 Oct 2022 10:33:53 +0800
From:   Huang Rui <ray.huang@amd.com>
To:     "Meng, Li (Jassmine)" <Li.Meng@amd.com>
Cc:     Shuah Khan <skhan@linuxfoundation.org>,
        "linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
        "Rafael J . Wysocki" <rafael.j.wysocki@intel.com>,
        "Fontenot, Nathan" <Nathan.Fontenot@amd.com>,
        "Sharma, Deepak" <Deepak.Sharma@amd.com>,
        "Deucher, Alexander" <Alexander.Deucher@amd.com>,
        "Limonciello, Mario" <Mario.Limonciello@amd.com>,
        "Su, Jinzhou (Joe)" <Jinzhou.Su@amd.com>,
        "Yuan, Perry" <Perry.Yuan@amd.com>,
        "Du, Xiaojian" <Xiaojian.Du@amd.com>,
        Viresh Kumar <viresh.kumar@linaro.org>,
        Borislav Petkov <bp@alien8.de>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH V3 0/4] Add tbench/gitsource new test cases for
 amd-pstate-ut
Message-ID: <Y0y/EeA5uWTFWLHJ@amd.com>
References: <20220914061105.1982477-1-li.meng@amd.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220914061105.1982477-1-li.meng@amd.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?i1/crU8YubwiCbQo5RDdD1ksOBU50x8JyDFNgKUaWIQ6B86Un7aOetdSPOoq?=
 =?us-ascii?Q?5Ej1sOr/o00w60rsTfNy153UqnZmvSHAX1cZWKiRjg3dAoDdetSvzKvsa3Pk?=
 =?us-ascii?Q?5md3yTLYwbrtdt7OFp2lxvTKXeERFAIAWZIeTy4LYE/gjU8tEFU27FLAgYwS?=
 =?us-ascii?Q?77ir+Yjna2DITA3ZYFIDrp6+Z9a9QW4fMaIE7+o7KDxLJP+h2Xyet1K5klj9?=
 =?us-ascii?Q?3bmJqUrAO3NxjnDurGuciVuGLqLwfbjnxZKutg9eEQ7dBNH3WNHpKKTa09fy?=
 =?us-ascii?Q?hU3IjkjphuSw0D66b4PjKPZQ1XF0JRhZsv5yRoNxPpb6gA/KbkAEWTd2gbpo?=
 =?us-ascii?Q?2IXZ5QL7pb5HmfoS66kTubR39uTO4ULNT/21x/ua05bU1VZbjpOh+CjGm0HQ?=
 =?us-ascii?Q?EyJPGLqBrK+vfsMvM9qSkQ81Tb2acQF5pwvHbCM2NtGdpl+T92X7cPRFeiWA?=
 =?us-ascii?Q?/2JFVSqoLELrT7gUGAu5FKtH/gjnRfWTJQEj0lemSipP3Aq06NdhBfCaVwwp?=
 =?us-ascii?Q?HgF6PdItr/nPI6yKyyH7IupQRniFuNlAVkcPOEBBV0btxRPM3tgqjqFDfLAy?=
 =?us-ascii?Q?tEmO+2FGN8YEyczLaKu67168gpqTpcQW0C7SZMAT+bJEq3Q54TmLyoO/wLIb?=
 =?us-ascii?Q?DwBCFBMqsqDgaGwbbu7En1jerKn4MEkVJSLwe/1urZBva1Tq1qFX0KWG1akk?=
 =?us-ascii?Q?XJ0jdk6HyD6Mzh2si82wFFxbuUZmfEq4fQzGr9QDdVfWZyIKRPQT2xxJCOdZ?=
 =?us-ascii?Q?s/ku0O06cNO7maKQ+FaBK2GyoK8I125OtBLTbMimJwMp/EiNsvaC0X3WhsxA?=
 =?us-ascii?Q?qcZTgFAPIlIotb8UVeFXRT58X8Ij1l+W8T4nbYtSC/d7nFasrzuNEjoxgYrI?=
 =?us-ascii?Q?58l4qjPcxjIFNgZhpHiIbokyWn0wBxt1G/OScbrbslQ+4kuaQGWZawceLTa6?=
 =?us-ascii?Q?pZVg1lhWhhL/p8e+bv3aUj/5tBXmzH6229p1A4DXrMZeKL4WjNUrBoJrT7FX?=
 =?us-ascii?Q?IpwraPgV6E92upOdKLJAXY09i4949DZygsM6Qyv23hzV0hvderVbQ54WVEen?=
 =?us-ascii?Q?y28w10GCMDzxTrDVa26IH0F8hg8sTRXK91GTeeWnucFNQBW77cY0n8L5pjGA?=
 =?us-ascii?Q?NUsdx/JHQrubTKUEPXIgr5Udvd6RNPf+jV6dZ0gigaJVKEv44vaxtvvxe0gK?=
 =?us-ascii?Q?VmRnnE9X6X7qGIsru0ZZKGpetq9/t44yFs7GPvjBjRPSNhOLiS8FVmMkT/nl?=
 =?us-ascii?Q?IZ+/WpVZog5beGP6UBpfvoQFXfQJrjB4/j23jH7+ierZ1YQaVIm/M9JtN/of?=
 =?us-ascii?Q?SMpo4hTbDAmtyhouV1qxZyAWcfET3eb3W8B7i8bi5pSe4HFlx9xvv4ZyG/Rh?=
 =?us-ascii?Q?4f/lROcEiuBsyIgyoZW8HGoWNzWCog9Hc8Zwnxq0D69fGUjpKCHVEpVkv5yV?=
 =?us-ascii?Q?GiiKWHNNO+pDr15o3qutrt1cSnWETiHghNAHJiGTT+HBWuEX4/TtH+k6Fa8P?=
 =?us-ascii?Q?eoN99UGFd8QlhJWoPijRf1AKNxm2d4+EzDF4+z8Yg4ceaINuOtFi/eFDM/aB?=
 =?us-ascii?Q?ke93mBP3Y7bD+plSE3A4fVKDTG2dHwdMCD7PvMuW?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: c4f5c7ad-80de-4bcc-6ae3-08daafe81738
X-MS-Exchange-CrossTenant-AuthSource: DM5PR12MB2504.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Oct 2022 02:34:18.5849
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Nu0DX1OCbTNYCDNlbQQuH6jacxV2PhlLosxAUPtnXQDNmZ4ycs4Br8vHahNtjpmphlTDOWr8JlGJwDXQ8HPwHQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY8PR12MB7124
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, Sep 14, 2022 at 02:11:01PM +0800, Meng, Li (Jassmine) wrote:
> Hi all:
> 
> First, we modify amd-pstate-ut.sh to basic.sh as a basic test, mainly for
> AMD P-State kernel drivers. The purpose of this modification is to
> facilitate the subsequent addition of gitsource, tbench and other tests.
> You can test specific functions by specifying test cases.
> Default test all cases, include basic, tbench and gitsource etc.
> 
> Secondly, add tbench.sh trigger the tbench testing and monitor the cpu
> information.
> 1) Download and install tbench codes.
> 2) Run tbench benchmark on specific governors, ondemand or schedutil.
> 3) Run tbench benchmark comparative test on acpi-cpufreq kernel driver.
> 4) Get desire performance, frequency, load by perf.
> 5) Get power consumption and throughput by amd_pstate_trace.py.
> 6) Analyse test results and save it in file selftest.tbench.csv. 
> 7) Plot png images about performance, energy and performance per watt
> for each test.
> 
> Third, add gitsource.sh trigger the gitsource testing and monitor the cpu
> information.
> 1) Download and tar gitsource codes.
> 2) Run gitsource benchmark on specific governors, ondemand or schedutil.
> 3) Run tbench benchmark comparative test on acpi-cpufreq kernel driver.
> 4) Get desire performance, frequency, load by perf.
> 5) Get power consumption and throughput by amd_pstate_trace.py.
> 6) Get run time by /usr/bin/time.
> 7) Analyse test results and save it in file selftest.gitsource.csv. 
> 8) Plot png images about time, energy and performance per watt
> for each test.
> 

The cover letter won't be included into kernel commit. Above steps
are even clearer than the original patch commit message. So I suggest you
can move them into related commit log.

TBench steps -> Patch 2
Gitsource steps -> Patch 3

Thanks,
Ray

> Finally, modify rst document to introduce test steps and results etc.
> 
> See patch series in below git repo:
> V1:https://lore.kernel.org/lkml/20220706073622.672135-1-li.meng@amd.com/
> V2:https://lore.kernel.org/lkml/20220804054414.1510764-1-li.meng@amd.com/
> 
> Changes from V1->V2:
> - selftests: amd-pstate: basic
> - - delete main.sh and merge funtions into run.sh
> - selftests: amd-pstate: tbench
> - - modify ppw to performance per watt for tbench.
> - - add comments for performance per watt for tbench.
> - - add comparative test on acpi-cpufreq for tbench.
> - - calculate drop between amd-pstate and acpi-cpufreq etc.
> - - plot images about perfrmance,energy and ppw for tbench.
> - selftests: amd-pstate: gitsource
> - - modify ppw to performance per watt for gitsource.
> - - add comments for performance per watt for gitsource.
> - - add comparative test on acpi-cpufreq for gitsource.
> - - calculate drop between amd-pstate and acpi-cpufreq etc.
> - - plot images about perfrmance,energy and ppw for gitsource.
> - Documentation: amd-pstate:
> - - modify rst doc, introduce comparative test etc.
> 
> Changes from V2->V3:
> - selftests: amd-pstate:
> - - reduce print logs for governor.
> - - add a check to see if tbench and the perf tools are already installed.
> - - install tbench package from apt or yum.
> - - correct spelling errors from comprison to comparison.
> 
> Thanks, 
> Jasmine 
> 
> Meng Li (4):
>   selftests: amd-pstate: Modify amd-pstate-ut.sh to basic.sh.
>   selftests: amd-pstate: Trigger tbench benchmark and test cpus
>   selftests: amd-pstate: Trigger gitsource benchmark and test cpus
>   Documentation: amd-pstate: Add tbench and gitsource test introduction
> 
>  Documentation/admin-guide/pm/amd-pstate.rst   | 192 ++++++++-
>  tools/testing/selftests/amd-pstate/Makefile   |  11 +-
>  .../selftests/amd-pstate/amd-pstate-ut.sh     |  56 ---
>  tools/testing/selftests/amd-pstate/basic.sh   |  38 ++
>  .../testing/selftests/amd-pstate/gitsource.sh | 345 ++++++++++++++++
>  tools/testing/selftests/amd-pstate/run.sh     | 387 ++++++++++++++++++
>  tools/testing/selftests/amd-pstate/tbench.sh  | 334 +++++++++++++++
>  7 files changed, 1287 insertions(+), 76 deletions(-)
>  delete mode 100755 tools/testing/selftests/amd-pstate/amd-pstate-ut.sh
>  create mode 100755 tools/testing/selftests/amd-pstate/basic.sh
>  create mode 100755 tools/testing/selftests/amd-pstate/gitsource.sh
>  create mode 100755 tools/testing/selftests/amd-pstate/run.sh
>  create mode 100755 tools/testing/selftests/amd-pstate/tbench.sh
> 
> -- 
> 2.34.1
>