Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
IronPort-SDR: lW4KeUyAieZpvknA4tfW+gCYiqBbS2pEvU8w5Kb4Ni9gO3ZZTyyrb/OjZk6A85bHTlu0CCfdjz
 dlNzeRbzF1DDQr1ysx6atsvvACCRXxcmFF5/MP+fp2yXXzs9kCBWPCtKL/10MEWkZicmC3Fd+d
 gzoHfT/TBQ+BoaqBKyjHknYgHr7CX64vXH611fP4FiMgy3a2NUOH/WWpxDyox6eeynzIuGkXJ1
 chfnxzEF3Zx1wL5/H1bmUEB5m2xERJvqWJ/cvZABz+bXB98G2Ov1IXccTcbACvepJzU339iDJD
 swmAP6DfzKHHXqv2PTqoWIrj
IronPort-SDR: FaHCLoLG+ZZvVHIfogvJTdSoTVGzfugOzoGu0NfnTr5s9Ys7f8jjgA8Qn5kHfk9fw7W1XShc9T
 WTg9cvaapWFxSXUTyahlYeBULKWOI4U8cjjJ7C92ohGKI2lcKS/Xudp6yaPE9NB+VuLeHo2G10
 k/Tb2xdLZvT5syUE7nCRlMvr4Wk05seQFNdcuz+A4cTl7yPckD+mlx3CdS6FZdCdLczAv535xB
 cZ3SFycOxpFTI+GeCvn3oXRRj3Sq3JmG/rZ2UYboYx8OV/zLgaETzINJyodln5fGPG4GDecEs1
 SLA=
WDCIronportException: Internal
Message-ID: <0368fdce-436d-4a19-1fec-fdd2f3038eca@opensource.wdc.com>
Date:   Mon, 17 Oct 2022 11:43:01 +0900
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.1
Subject: Re: [PATCH] ata: pata_mpc52xx: Replace NO_IRQ by 0
Content-Language: en-US
To:     Christophe Leroy <christophe.leroy@csgroup.eu>,
        Sergey Shtylyov <s.shtylyov@omp.ru>
Cc:     linux-kernel@vger.kernel.org, linux-ide@vger.kernel.org
References: <a8c87c6d8dd6d9e57c515036a333ff89fc56bcbf.1665033366.git.christophe.leroy@csgroup.eu>
From:   Damien Le Moal <damien.lemoal@opensource.wdc.com>
Organization: Western Digital Research
In-Reply-To: <a8c87c6d8dd6d9e57c515036a333ff89fc56bcbf.1665033366.git.christophe.leroy@csgroup.eu>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 10/6/22 14:17, Christophe Leroy wrote:
> NO_IRQ is used to check the return of irq_of_parse_and_map().
> 
> On some architecture NO_IRQ is 0, on other architectures it is -1.
> 
> irq_of_parse_and_map() returns 0 on error, independent of NO_IRQ.
> 
> So use 0 instead of using NO_IRQ.
> 
> Signed-off-by: Christophe Leroy <christophe.leroy@csgroup.eu>
> ---
>  drivers/ata/pata_mpc52xx.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/ata/pata_mpc52xx.c b/drivers/ata/pata_mpc52xx.c
> index 6559b606736d..3ebd6522a1fd 100644
> --- a/drivers/ata/pata_mpc52xx.c
> +++ b/drivers/ata/pata_mpc52xx.c
> @@ -731,7 +731,7 @@ static int mpc52xx_ata_probe(struct platform_device *op)
>  		udma_mask = ATA_UDMA2 & ((1 << (*prop + 1)) - 1);
>  
>  	ata_irq = irq_of_parse_and_map(op->dev.of_node, 0);
> -	if (ata_irq == NO_IRQ) {
> +	if (!ata_irq) {
>  		dev_err(&op->dev, "error mapping irq\n");
>  		return -EINVAL;
>  	}

Applied to for-6.2. Thanks !

-- 
Damien Le Moal
Western Digital Research