Received: by 2002:a05:6358:1087:b0:cb:c9d3:cd90 with SMTP id j7csp3933876rwi; Sun, 16 Oct 2022 21:55:58 -0700 (PDT) X-Google-Smtp-Source: AMsMyM4FU1ve/a0KDzzea4oncmsack4EW4mXoXKUpVQrXbmMxVuyVnj1LUp8vot+irTFIQR0Iggu X-Received: by 2002:a17:907:3f85:b0:733:3f0e:2f28 with SMTP id hr5-20020a1709073f8500b007333f0e2f28mr6941677ejc.376.1665982558593; Sun, 16 Oct 2022 21:55:58 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1665982558; cv=none; d=google.com; s=arc-20160816; b=PVVR+EIsMBcRKJJzFjAMz8npO4BE1q6Qej9UJLMeDu62O3v3cYVeRpZIj+pFKqU9jX MkJtUk0mHQUkfCHFFo/O7IuT3TXiDrt/0R/Q44HNlQEvrtQ5rjDcZSLUdyDCzVwvd3BS VLYwOaTb2qJbhrO9oxgwVJeNRHpdBl0WjDdyBycuadqeoivdyOVZpcMoNmMlySMaA5HU Sl0Y4xfiQMws7J7BcC7bXs3ESN6Iz9EHY9uN7JvQjL9KWTCEDcur9tFA+c5vQOinp3WP GccN3ez/v1ZcdaRVImYMoS8Z6NCeMbyGtMBlVFZeNmqYD5/Suz7UIR5czd87emRDQVzq BuFg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=obs5QWcYykyilhvjXRmEGlT8rOUF1fwosMIRVr88pJ0=; b=P+4VuZvzs0cJxxt67WWtlnDyWs3oHCLyiH4e0vhmvmIZVjBjSysq/4lQbtQP7yDkrJ 36J65nnc+x+Rc5klCjh1fo+w0U/A5GmA6UBvaahNlEgKAiNLwxQ+yt2i1sdK9cZYo8MF MnP5gTNXtVTgUtXaZiQqZEAJGm+ZwAE3WmbxefMhu2F0DzuJ2hQH0Mgif63WLyi7yTnC 24HKRyC5N84PM1ihMRcENZT4FKyOAJN0Jx5XR5fjmS5ppEs31M6R7LS3MouuC+5liE2X gs2+X/ISRvhcKYSeOYVYL/5AZrpqvl5ctynnVaeLDzTmI/r7svtTVxxJtN3+oAGgdmLF i66w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=aUFPxp4F; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id b21-20020a056402139500b00448d387c327si7313290edv.181.2022.10.16.21.55.29; Sun, 16 Oct 2022 21:55:58 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=aUFPxp4F; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229908AbiJQEuZ (ORCPT + 99 others); Mon, 17 Oct 2022 00:50:25 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38020 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229729AbiJQEuX (ORCPT ); Mon, 17 Oct 2022 00:50:23 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6AFFA2A419 for ; Sun, 16 Oct 2022 21:50:22 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 03B2060F1F for ; Mon, 17 Oct 2022 04:50:22 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D6EA1C433D6; Mon, 17 Oct 2022 04:50:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1665982221; bh=zP+QWZVvD/g/7FLG+RNOCKnRNoV+tb39fjJoguMZEdg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=aUFPxp4Fmx6nPNVRnAl5xAtGwHVTYtTQhe04+XKOrniM5/eloE4hEDs046xE83Def hPcUfJnlEtskuG3XC0SVVxIMpKzmgH2kn/E8JwhDpmg9TNshPhXnyLmapGKHHvQTAr Fk6miAl2K9rDFXTHw3aGpi2Ugb3G9m9IdFO1stXg= Date: Mon, 17 Oct 2022 06:51:08 +0200 From: Greg KH To: Yang Yingliang Cc: linux-kernel@vger.kernel.org, rafael@kernel.org Subject: Re: [PATCH] kobject: fix possible memory leak in kset_create_and_add() Message-ID: References: <20221017023327.1793893-1-yangyingliang@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221017023327.1793893-1-yangyingliang@huawei.com> X-Spam-Status: No, score=-7.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Oct 17, 2022 at 10:33:27AM +0800, Yang Yingliang wrote: > If kset_register() fails in kset_create_and_add(), the name allocated > in kset_create() will be leaked. How is kset_create_and_add() failing? Is this in a real kernel, or created with a fake fault injection? thanks, greg k-h