Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 17 Oct 2022 13:34:39 +0800
From:   Huang Rui <ray.huang@amd.com>
To:     "Meng, Li (Jassmine)" <Li.Meng@amd.com>
Cc:     Shuah Khan <skhan@linuxfoundation.org>,
        "linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
        "Rafael J . Wysocki" <rafael.j.wysocki@intel.com>,
        "Fontenot, Nathan" <Nathan.Fontenot@amd.com>,
        "Sharma, Deepak" <Deepak.Sharma@amd.com>,
        "Deucher, Alexander" <Alexander.Deucher@amd.com>,
        "Limonciello, Mario" <Mario.Limonciello@amd.com>,
        "Su, Jinzhou (Joe)" <Jinzhou.Su@amd.com>,
        "Yuan, Perry" <Perry.Yuan@amd.com>,
        "Du, Xiaojian" <Xiaojian.Du@amd.com>,
        Viresh Kumar <viresh.kumar@linaro.org>,
        Borislav Petkov <bp@alien8.de>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH V3 0/4] Add tbench/gitsource new test cases for
 amd-pstate-ut
Message-ID: <Y0zpb9XNa23uotk0@amd.com>
References: <20220914061105.1982477-1-li.meng@amd.com>
 <Y0y/EeA5uWTFWLHJ@amd.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <Y0y/EeA5uWTFWLHJ@amd.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?Pg3vEinCPDHhTl9IWMAHxbjCrhMmlhja/uSusWnRID3b/G5t6qdsx+Lxh4YB?=
 =?us-ascii?Q?lNiu+wS4GSIaVrhyQxSuRJG4iK45+idBvhCtDac8LxxzT0YquGjNqctMVEfU?=
 =?us-ascii?Q?2AZX2MAcRKMk8RphzDJHHEDH4CEbmvV/az+FzwhX1iLIq/mbfjoe6taaQKBU?=
 =?us-ascii?Q?ZG44by0Q4ZYdYTJJCbxN4C3PwJ4Qje4TPhgymlcI6XTQ3rB4ixynzy9H2Xbn?=
 =?us-ascii?Q?lNdaQxJA31sleme7cZSUXbXGEzukU9yA1+dBxCc0olTbQZFKPYwmLvChaSTN?=
 =?us-ascii?Q?nkvjVZb4uQcMXQx1/pdr3C+Nrq7/YeL41NDFTd1gS2Tj4F64cYxk6JQ3pWIN?=
 =?us-ascii?Q?aXyRybFqSEwiB6baqBjBirVNXn+e2TrQRAWgYQMbTgEUAkBg/AzgB7y17zRl?=
 =?us-ascii?Q?v+6i85UtajiUmsuTPFAmvGr2Q+0i7BQK+qs3BSsuM/weiTNIR1GPbRuDPwSB?=
 =?us-ascii?Q?9G+dwA0q3D66hD+FUh+D8A3vYPOYpFqs6Rg9Ojmj3q6ZKC7mx6cThd8vRpJ1?=
 =?us-ascii?Q?1HQha2UCWZxRVAl7YBTVS3vYlrs1t0Q41+uwhKkj5c0j6MDDGquRixRqy0/o?=
 =?us-ascii?Q?6j1rt6WDXxqCdebupuLAPO6XkM8xP7txqR7tFxZze3eU8RHxY9sziiI/5+Fs?=
 =?us-ascii?Q?GOm8WlTzu4Pdscv8bFmClPbADrUKXlRmuuAORPFOGHeAHg2nZR8yh5UJzPkO?=
 =?us-ascii?Q?pWLj2iyi008PUT/j3XKz4p+4Pfu/6cfjRFj9vCzN25uNC0tm3zRnxlnWT4bk?=
 =?us-ascii?Q?C6rSbXb26xzF05cQVGQsPmJGpwtRERv6RZSn20Mg3jB50GIkuMlOpQfjexEV?=
 =?us-ascii?Q?8cXP8lYFMIRRA7NCb9YhbfVDW7X3RfOGZUmvuW6NdpNpSC4NM5gi/1HrHIjW?=
 =?us-ascii?Q?2TS+wrYF+nuyjFAe/QQyV5wTwYyCXrXWv/61/bEAbKL1UGCEdHCDCjq6WYqk?=
 =?us-ascii?Q?lv35BYbk+mU5oVurZJyM8OjcWX+JbQg2tBHtB3RJnW4Za874HtNE2LVN4ZkL?=
 =?us-ascii?Q?cO0jBP0mNgYgGZr0jCAfKfLczc4qZ73664asd4fOScOrBs/w2SP/HfJPdcSF?=
 =?us-ascii?Q?YxerwNhrvYiP/KIN84DIwZ8MV1gDGIPtqTX38zrJ0WyQaiD1xSjOpd4liZW+?=
 =?us-ascii?Q?Cm4udm3Hju4S+wU/d26/azwIFqyhJlQSSLS6BWHBvhGtsgT7ZSBg7n7AMMQ6?=
 =?us-ascii?Q?WDc/aYw2AK5BW8U18EGqX1SVGa8xGo9RUVnyO6NOYkGH4aM8rpG3XIefuGxs?=
 =?us-ascii?Q?yB2mjXjeUv/CR/MDJxFnqWW51jJFBSaxFrXroY+BtY4hDnnQCYkAVGizH+UP?=
 =?us-ascii?Q?PdooXha0nc2tLfbaXn8uvAd78CXsxJPhU4HDCEkSFDMeXWD2ToGPx6vhwvKS?=
 =?us-ascii?Q?ILC65eQEbzowOtVfbPJe5Z7iDFueCxi8S/q9jg5CabbSS3n5yK9cXbeSseK3?=
 =?us-ascii?Q?YGicLilOIQLWIcZ9xVuSSFRauToFH4pHJDK2kFrgPzlFs/wgtHcAbWWz7eeY?=
 =?us-ascii?Q?5RVl5pr7TaKZLwfph7ODndCzEn+0R6uJeVp6JvR2sAklYhDj9RJffgvLDk+a?=
 =?us-ascii?Q?ondwzFKFhkqCfxvHWavq7R1IBICsMcSmzcKrPODn?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 0f72b67d-38f2-4156-d131-08dab0015787
X-MS-Exchange-CrossTenant-AuthSource: DM5PR12MB2504.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Oct 2022 05:35:03.8664
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: zKN6FSNi/1/hJZ38DfpCX968ZxfGJP4xJYvwoakJ/txWOPa464t8tgNCJq9OW/aU/R6ZJYzyixvOqv2pFJX2AA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR12MB6114
X-Spam-Status: No, score=-0.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,URIBL_BLACK autolearn=no
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, Oct 17, 2022 at 10:34:18AM +0800, Huang Rui wrote:
> On Wed, Sep 14, 2022 at 02:11:01PM +0800, Meng, Li (Jassmine) wrote:
> > Hi all:
> > 
> > First, we modify amd-pstate-ut.sh to basic.sh as a basic test, mainly for
> > AMD P-State kernel drivers. The purpose of this modification is to
> > facilitate the subsequent addition of gitsource, tbench and other tests.
> > You can test specific functions by specifying test cases.
> > Default test all cases, include basic, tbench and gitsource etc.
> > 
> > Secondly, add tbench.sh trigger the tbench testing and monitor the cpu
> > information.
> > 1) Download and install tbench codes.
> > 2) Run tbench benchmark on specific governors, ondemand or schedutil.
> > 3) Run tbench benchmark comparative test on acpi-cpufreq kernel driver.
> > 4) Get desire performance, frequency, load by perf.
> > 5) Get power consumption and throughput by amd_pstate_trace.py.
> > 6) Analyse test results and save it in file selftest.tbench.csv. 
> > 7) Plot png images about performance, energy and performance per watt
> > for each test.
> > 
> > Third, add gitsource.sh trigger the gitsource testing and monitor the cpu
> > information.
> > 1) Download and tar gitsource codes.
> > 2) Run gitsource benchmark on specific governors, ondemand or schedutil.
> > 3) Run tbench benchmark comparative test on acpi-cpufreq kernel driver.
> > 4) Get desire performance, frequency, load by perf.
> > 5) Get power consumption and throughput by amd_pstate_trace.py.
> > 6) Get run time by /usr/bin/time.
> > 7) Analyse test results and save it in file selftest.gitsource.csv. 
> > 8) Plot png images about time, energy and performance per watt
> > for each test.
> > 
> 
> The cover letter won't be included into kernel commit. Above steps
> are even clearer than the original patch commit message. So I suggest you
> can move them into related commit log.
> 
> TBench steps -> Patch 2
> Gitsource steps -> Patch 3
> 
> Thanks,
> Ray
> 
> > Finally, modify rst document to introduce test steps and results etc.
> > 
> > See patch series in below git repo:
> > V1:https://lore.kernel.org/lkml/20220706073622.672135-1-li.meng@amd.com/
> > V2:https://lore.kernel.org/lkml/20220804054414.1510764-1-li.meng@amd.com/
> > 
> > Changes from V1->V2:
> > - selftests: amd-pstate: basic
> > - - delete main.sh and merge funtions into run.sh
> > - selftests: amd-pstate: tbench
> > - - modify ppw to performance per watt for tbench.
> > - - add comments for performance per watt for tbench.
> > - - add comparative test on acpi-cpufreq for tbench.
> > - - calculate drop between amd-pstate and acpi-cpufreq etc.
> > - - plot images about perfrmance,energy and ppw for tbench.
> > - selftests: amd-pstate: gitsource
> > - - modify ppw to performance per watt for gitsource.
> > - - add comments for performance per watt for gitsource.
> > - - add comparative test on acpi-cpufreq for gitsource.
> > - - calculate drop between amd-pstate and acpi-cpufreq etc.
> > - - plot images about perfrmance,energy and ppw for gitsource.
> > - Documentation: amd-pstate:
> > - - modify rst doc, introduce comparative test etc.
> > 
> > Changes from V2->V3:
> > - selftests: amd-pstate:
> > - - reduce print logs for governor.
> > - - add a check to see if tbench and the perf tools are already installed.
> > - - install tbench package from apt or yum.
> > - - correct spelling errors from comprison to comparison.
> > 

The series overall look good for me, only very a few comments. Thanks!

Could we please send V4 to address them?

Thanks,
Ray