Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Liu Ying <victor.liu@nxp.com>
To:     devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        linux-kernel@vger.kernel.org
Cc:     robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
        shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de,
        festevam@gmail.com, linux-imx@nxp.com, saravanak@google.com,
        gregkh@linuxfoundation.org, geert+renesas@glider.be,
        krzysztof.kozlowski@linaro.org, robh@kernel.org
Subject: [PATCH v4 RESEND 1/2] drivers: bus: simple-pm-bus: Use clocks
Date:   Mon, 17 Oct 2022 15:40:38 +0800
Message-Id: <20221017074039.4181843-2-victor.liu@nxp.com>
In-Reply-To: <20221017074039.4181843-1-victor.liu@nxp.com>
References: <20221017074039.4181843-1-victor.liu@nxp.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?w7g8z3ZIKhPcrWpgLcFqRNdqGnkiJDCbbc9VP4Jin2kLLOEUazOmXliPEwAJ?=
 =?us-ascii?Q?yzxw4a9AYBhv9LzNJvECOMrrl1U37uH0+lZ/2nNA8EDLU72eqLVsjC3iRj4f?=
 =?us-ascii?Q?KoIamMPzv5d+niVK6V0ejwbUW3HEGjOlTbjGXxAFEyLWxt2s+ZZWqm6QXAEz?=
 =?us-ascii?Q?xlW5Lfw7lt74soXvzklU5xoJ0GZNTtf7w7RUzqX8wS/KNhwjR3chb9Ln4GL1?=
 =?us-ascii?Q?kUmeFDky+3Wp3DETXqAisJJ5cW+YzmRFW4zHKibOu7ZZvvrnVrS4mJw+d9L/?=
 =?us-ascii?Q?8HobwHtdoTjpxfGRd8fUYAJCFW6vHF9KQ4EDTCdZ86gqx0O53Qp7nCFlNBBA?=
 =?us-ascii?Q?pyDD1+HSgdTqQ9NoSpyiDtZ9nBGkNOEOGRZNXQ+bTinHImAW8T6eRKeCuzeI?=
 =?us-ascii?Q?feXcnvZ9zQmBAZvBzECpiZsX3f9MOKkPQsJmvviq2jFRrpasL8TsFAAkTg5z?=
 =?us-ascii?Q?mNazMopImHXd1nkj0PKYxXTrsV5KJipuCp37t1HAhnf+GVOPn28CaGfEe6SF?=
 =?us-ascii?Q?G07ikpyYr1ta1NM67fR6b/bExUPX/05VqrZhw4DiMJGjjtjnQALGMFq3+QP7?=
 =?us-ascii?Q?tk01T87bL25wfK2i1lJBYMZHoBhCrgZH3F6HOenwS20d1Wsus9btv48YGcLB?=
 =?us-ascii?Q?JLhqVFYEx2Xfztu9owXvwyB2qXwpHN+wf2gAGKGietsAwd5tWuxbWFO0AaJd?=
 =?us-ascii?Q?Yx5i67BPOIy2r2r0Vqwu1LjM5GpdaduPW5iD1veiRLEkXtVWC7ib7HFtV2Rw?=
 =?us-ascii?Q?BG3StgzMZgkxA9Mcl6ffoWFAorcFfbJrGS7LMwMFMeqwrAFmAyEsDXzLxs6D?=
 =?us-ascii?Q?n+cgc0VX3qIiQa7LxW7mOZ42VRELUKG300JAhonY5rT6meQx5//MiZxgrjJW?=
 =?us-ascii?Q?bFVAX9hoKqC/axDka5C+Pk51DaiSdnbNtEKiJyEtKKqWQbjnCWQ+If/7i/5K?=
 =?us-ascii?Q?QkXDShZoxLnXsqDoIKqF5lhKif819EGE0z+4WhM8Hp4THoVsvBCEm+Esd8Vx?=
 =?us-ascii?Q?xbyiyvpDRjnZlbYtqJGYbSta6Rr/ZnegJO/P4T+/SkzW+XSOT3bRPgvPMsQ1?=
 =?us-ascii?Q?XTbET6wi97YDsHxsDTOCfbGzyDyOEQSXfMcK4FMzUW9sCREN44Law/7T3RFM?=
 =?us-ascii?Q?VkMVXEzuhGN+f2uxG9t+nDw6f+Fj4CGnFxGGckquqU/W0mmN04OnH1O8OPAc?=
 =?us-ascii?Q?tCE1/tx0cWSn80AUJW2Zt+A1qEKP/G+i+YqRm+XUgSsS3decVAaIAUlXyF6W?=
 =?us-ascii?Q?wZXLV4krV0GsUNFHn4n61f7vO1u4jf8tZXGz1MUt/bVoL5cteUqA0f0GxujL?=
 =?us-ascii?Q?ikSJ3Yv1qdmOXDSgUCYhfrYT/K3Gnxtve0RN1a/F79MgCEAARBCp4DcDx7HA?=
 =?us-ascii?Q?fxAV2MIETf7wm2erxGQ8WOiL7mAhLWXUL9vJwoqt7VmQ+aSzDD+fx9ytwRvd?=
 =?us-ascii?Q?VJW61bX3Ur2dH2wFaOznN1EQq+Qz2nNdo0Kccvl+G44oJi2qm0wrTiktSjut?=
 =?us-ascii?Q?F4WGCpBjdncSslfVcSyBSrDI6fWwX7xeDwH4k9BZnDGvtWZFOb3wc/BmlPs1?=
 =?us-ascii?Q?9nYwgw1OMz/JN2IJmLw80r35/OKmMx8aOqizaoCf?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: ee2c4fe2-dda8-4219-e034-08dab012b5a3
X-MS-Exchange-CrossTenant-AuthSource: AM7PR04MB7046.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Oct 2022 07:39:23.2161
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Rxv+cZBSBuAeeAFMzhqcNUe6N64MjAuskOvh5Cf62S/0JgPbuWWyqkBHLQiAwfzugunTx3P5hUPfWVDH+GoVkA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB8296
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Simple Power-Managed bus controller may need functional clock(s)
to be enabled before child devices connected to the bus can be
accessed.  Get the clock(s) as a bulk and enable/disable the
clock(s) when the bus is being power managed.

One example is that Freescale i.MX8qxp pixel link MSI bus controller
needs MSI clock and AHB clock to be enabled before accessing child
devices.

Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Signed-off-by: Liu Ying <victor.liu@nxp.com>
---
v3->v4:
* Drop unnecessary 'bus == NULL' check from simple_pm_bus_runtime_{suspend,resume}.
  (Geert)
* Add Geert's R-b tag.
* Resend v4 based on v6.1-rc1. (Greg)

v1->v3:
* No change.

 drivers/bus/simple-pm-bus.c | 48 +++++++++++++++++++++++++++++++++++++
 1 file changed, 48 insertions(+)

diff --git a/drivers/bus/simple-pm-bus.c b/drivers/bus/simple-pm-bus.c
index 6b8d6257ed8a..d7b043fefde9 100644
--- a/drivers/bus/simple-pm-bus.c
+++ b/drivers/bus/simple-pm-bus.c
@@ -8,17 +8,24 @@
  * for more details.
  */
 
+#include <linux/clk.h>
 #include <linux/module.h>
 #include <linux/of_platform.h>
 #include <linux/platform_device.h>
 #include <linux/pm_runtime.h>
 
+struct simple_pm_bus {
+	struct clk_bulk_data *clks;
+	int num_clks;
+};
+
 static int simple_pm_bus_probe(struct platform_device *pdev)
 {
 	const struct device *dev = &pdev->dev;
 	const struct of_dev_auxdata *lookup = dev_get_platdata(dev);
 	struct device_node *np = dev->of_node;
 	const struct of_device_id *match;
+	struct simple_pm_bus *bus;
 
 	/*
 	 * Allow user to use driver_override to bind this driver to a
@@ -44,6 +51,16 @@ static int simple_pm_bus_probe(struct platform_device *pdev)
 			return -ENODEV;
 	}
 
+	bus = devm_kzalloc(&pdev->dev, sizeof(*bus), GFP_KERNEL);
+	if (!bus)
+		return -ENOMEM;
+
+	bus->num_clks = devm_clk_bulk_get_all(&pdev->dev, &bus->clks);
+	if (bus->num_clks < 0)
+		return dev_err_probe(&pdev->dev, bus->num_clks, "failed to get clocks\n");
+
+	dev_set_drvdata(&pdev->dev, bus);
+
 	dev_dbg(&pdev->dev, "%s\n", __func__);
 
 	pm_runtime_enable(&pdev->dev);
@@ -67,6 +84,36 @@ static int simple_pm_bus_remove(struct platform_device *pdev)
 	return 0;
 }
 
+static int simple_pm_bus_runtime_suspend(struct device *dev)
+{
+	struct simple_pm_bus *bus = dev_get_drvdata(dev);
+
+	clk_bulk_disable_unprepare(bus->num_clks, bus->clks);
+
+	return 0;
+}
+
+static int simple_pm_bus_runtime_resume(struct device *dev)
+{
+	struct simple_pm_bus *bus = dev_get_drvdata(dev);
+	int ret;
+
+	ret = clk_bulk_prepare_enable(bus->num_clks, bus->clks);
+	if (ret) {
+		dev_err(dev, "failed to enable clocks: %d\n", ret);
+		return ret;
+	}
+
+	return 0;
+}
+
+static const struct dev_pm_ops simple_pm_bus_pm_ops = {
+	SET_RUNTIME_PM_OPS(simple_pm_bus_runtime_suspend,
+			   simple_pm_bus_runtime_resume, NULL)
+	SET_NOIRQ_SYSTEM_SLEEP_PM_OPS(pm_runtime_force_suspend,
+				      pm_runtime_force_resume)
+};
+
 #define ONLY_BUS	((void *) 1) /* Match if the device is only a bus. */
 
 static const struct of_device_id simple_pm_bus_of_match[] = {
@@ -85,6 +132,7 @@ static struct platform_driver simple_pm_bus_driver = {
 	.driver = {
 		.name = "simple-pm-bus",
 		.of_match_table = simple_pm_bus_of_match,
+		.pm = &simple_pm_bus_pm_ops,
 	},
 };
 
-- 
2.37.1