Received: by 2002:a05:6358:1087:b0:cb:c9d3:cd90 with SMTP id j7csp4120036rwi; Mon, 17 Oct 2022 01:33:15 -0700 (PDT) X-Google-Smtp-Source: AMsMyM7kDG0rpTOfL2Ujbkx2Uk2Qu+PyHy9jv+B1CiwMwMQCI8/LDkkRXCeJUw5O/fX3r/5zWybi X-Received: by 2002:a17:902:ea06:b0:185:3d64:8d55 with SMTP id s6-20020a170902ea0600b001853d648d55mr10753659plg.7.1665995594783; Mon, 17 Oct 2022 01:33:14 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1665995594; cv=none; d=google.com; s=arc-20160816; b=BLjmDIFBmM7Wo5awjEr6Dk2oAivcgZLv8sBNsybPXkDtVNGfB7/KITz9/ep1REO64C VzkCHopcTG73OAZbzUlmfYMIICzT1VBRLPFS5Et9OwS3IJXzDz29TDIz2X5BVAv5rur4 arh2tCEf8oyRkdq/2qqyAfPvbLLfQFX0NGctkbV+TqRcGoje9ho656H36BIMepiuTX1X S/QceyYRCNgp0u5/BmTXgVf0CKKF9UqwbqRd4WrMHPDZ1l+ezRY50tvxckvc91rul+1b 5Ui05/b2UCZva/x/Rv+ekYUVw19eN7RnOrfybv8arYiO7qDsbkAbDj/yJ6pg8Y+WVSIn 3ZkA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-language:content-transfer-encoding :in-reply-to:mime-version:user-agent:date:message-id:from:references :cc:to:subject; bh=4BoeONyuSDh2Y25wJd37K7GXU7A+y1X0jLxE4c7HGy0=; b=ImQvTOZXg7C2uB3tg7Ead9p1mwRcpRUGGQSh2EDfS9RBOp0jXLDDq/ySYHD8KM94qQ AWk7sabj9WXAw2J05VtYS7WK615hSTufCQuwPrc7W/Ojiqn/oACiUjA+oag/s+dP/R8r WxE/9U6BmFADcjC4/Ao2t6eLApmQW6frrQJOPo6P8LWmpcHS5OUNAHKJxNRZPoIW+37K VwFGYMRgMr4WXqTACj8HNyXcWQQnq8j4bKB51Lm3Uq0oTuEd+SADz211FaU4LXHAIApU QNcNUOMniBech5QjVILhqYZuY1jZku+D28ciz03plcxeGt1Va8l3+CkU4cTqEfEeexFF 0jtA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=huawei.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id c10-20020a63ea0a000000b00438b79bcf26si11357480pgi.151.2022.10.17.01.33.01; Mon, 17 Oct 2022 01:33:14 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=huawei.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230212AbiJQIOA (ORCPT + 99 others); Mon, 17 Oct 2022 04:14:00 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47194 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230233AbiJQINl (ORCPT ); Mon, 17 Oct 2022 04:13:41 -0400 Received: from szxga03-in.huawei.com (szxga03-in.huawei.com [45.249.212.189]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7FB935C944 for ; Mon, 17 Oct 2022 01:13:39 -0700 (PDT) Received: from dggpemm500022.china.huawei.com (unknown [172.30.72.56]) by szxga03-in.huawei.com (SkyGuard) with ESMTP id 4MrV775hXFzJn4B; Mon, 17 Oct 2022 16:10:59 +0800 (CST) Received: from dggpemm500007.china.huawei.com (7.185.36.183) by dggpemm500022.china.huawei.com (7.185.36.162) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Mon, 17 Oct 2022 16:13:04 +0800 Received: from [10.174.178.174] (10.174.178.174) by dggpemm500007.china.huawei.com (7.185.36.183) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Mon, 17 Oct 2022 16:13:03 +0800 Subject: Re: [PATCH] kobject: fix possible memory leak in kset_create_and_add() To: Greg KH CC: , References: <20221017023327.1793893-1-yangyingliang@huawei.com> From: Yang Yingliang Message-ID: <9c2e91e1-dd07-8a4b-999c-9a2d26ee5f07@huawei.com> Date: Mon, 17 Oct 2022 16:13:03 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US X-Originating-IP: [10.174.178.174] X-ClientProxiedBy: dggems702-chm.china.huawei.com (10.3.19.179) To dggpemm500007.china.huawei.com (7.185.36.183) X-CFilter-Loop: Reflected X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,NICE_REPLY_A, RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On 2022/10/17 12:51, Greg KH wrote: > On Mon, Oct 17, 2022 at 10:33:27AM +0800, Yang Yingliang wrote: >> If kset_register() fails in kset_create_and_add(), the name allocated >> in kset_create() will be leaked. > How is kset_create_and_add() failing? Is this in a real kernel, or > created with a fake fault injection? Inject fault while probing module qemu_fw_cfg, kset_create_and_add() may fail. Thanks, Yang > > thanks, > > greg k-h > .