Received: by 2002:a05:6358:1087:b0:cb:c9d3:cd90 with SMTP id j7csp4120834rwi; Mon, 17 Oct 2022 01:34:10 -0700 (PDT) X-Google-Smtp-Source: AMsMyM5k0OS04tnVnWR2gZqoxe4Gbvm9nLbW9qJ91ItBKQD5hY//0LLdyUfdufxoPZkniET8BJLW X-Received: by 2002:a17:90a:cb05:b0:20a:ea16:4ba5 with SMTP id z5-20020a17090acb0500b0020aea164ba5mr31535718pjt.187.1665995650243; Mon, 17 Oct 2022 01:34:10 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1665995650; cv=none; d=google.com; s=arc-20160816; b=CWMd6NK+XJyJoRGw0WJYSrjBiN7SOJGeUEXfyzR4i7B5G2Ogh1sCo9VEBiPtmUBVjH yWVfbKaCCJaRxzT6iTJKl/Wk1IQi22MMtkY9pOlNjqvafHn1egtgbI4wZqXIhi/avMuX 69kb36W6RwPr8oW/UvGmuzrQd0yW2fG/qPRTeX/SdQ3lPEvr65eIZx9iv3qcApR1osId H5m0P5ad852Z6AKZz0sQGLwWLMndGh0OhVv50er2k3axkoaLuKUyWh9QQklg/PydVgql i4DCVWIjBSZhXx0y3lFzw5MDCcxvno9AskDvfx7EghzI2RiRmXF21YSBbbKEANTPyEZI BxdA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=N3DhelgxeJD6609Ma0kcmpLW0VW7ci1zuKd0emkDasI=; b=Q1f9jTfLSfbeMuFlDMjb1Cqx0AGa2eChuCCE9TCBKYpauhE6S4dw6ySZX+k9ZFAjpe AqcDfYHhEWdnXmuT9cypqVxVSiYrTd8CP6WniBR5YpM85CrMWIKSpn8xKFC0zX85Q2Or IaI0w5eY+g2nm+kQBXf6m1792cS7L03m1fuYhHvX7bXMMZYR3zVF+somAEvsgQkI0CmB wliEy+FxKQvRwxGpcJFC4TW3bPiqX7apNW4R5GMZaSsWRC+zUlFlL2E+pg1bgiWMbhbH k4zvbJv/t1YVIsOnd1/pIGxF9FFgdCAdRcANcV4P8xdViYnkf+hWL4FAgCz/QhRTVvr2 jOBw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=4fQDVYDX; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id m4-20020a654384000000b00460d7f0d329si11131387pgp.288.2022.10.17.01.33.58; Mon, 17 Oct 2022 01:34:10 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=4fQDVYDX; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230252AbiJQHr1 (ORCPT + 99 others); Mon, 17 Oct 2022 03:47:27 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47760 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230062AbiJQHrY (ORCPT ); Mon, 17 Oct 2022 03:47:24 -0400 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4BF55193ED; Mon, 17 Oct 2022 00:47:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=N3DhelgxeJD6609Ma0kcmpLW0VW7ci1zuKd0emkDasI=; b=4fQDVYDXyHEvBhehq1JK9VdDW0 R3tMd/QDPEtKsjFGyFUg5svkVWeas3otDLcoY5ADt9NTdCDdXhQyvOSW0DiE+Ha40wEVm/WfkzT/P 2ch6qZHi1dMjetjJmmIpImeTfa6H8ZZIkQJ5A7xdpLLo5NXFdAN8dqifLlAyZKASYGEEnlfL06jmG yElmdEt09/1MHOslxcYuYYBVYM/zyj4Cb8W/6WUxoR+nYxhbg+dlVS3nz2/T4FBe6Pb/3hYyNRHvI 3YHeorVPSs9m3r3Mfq/GgQdazSE7bATFMgq6NUCBUwMIZHJOLAuHVUoWLH3zLEoaYTfJ2ti5bhaI7 9m8SZYMg==; Received: from hch by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1okKqE-008bBK-57; Mon, 17 Oct 2022 07:47:18 +0000 Date: Mon, 17 Oct 2022 00:47:18 -0700 From: Christoph Hellwig To: Dawei Li Cc: axboe@kernel.dk, tj@kernel.org, paolo.valente@linaro.org, linux-block@vger.kernel.org, cgroups@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] block: Add helper for queue_flags bit test Message-ID: References: <20221011145246.8656-1-set_pte_at@outlook.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > if (op_is_flush(bio->bi_opf) && > - !test_bit(QUEUE_FLAG_WC, &q->queue_flags)) { > + !blk_queue_wb_cached(q)) { The formatting is wrong here. And I really think these helpers do nothing but obsfucating the code. Now instead of a grep telling me exactly what is going on I now need to walk through the macro first. (nevermind that this particular one is also horribly misnamed).