Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <0571554f-ee19-39ba-c0ce-bab544ebfde2@nvidia.com>
Date:   Mon, 17 Oct 2022 09:40:53 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.2.2
Subject: Re: [PATCH] PCI: tegra: Use PCI_CONF1_EXT_ADDRESS() macro
Content-Language: en-US
To:     Lorenzo Pieralisi <lpieralisi@kernel.org>
Cc:     =?UTF-8?Q?Pali_Roh=c3=a1r?= <pali@kernel.org>,
        Thierry Reding <thierry.reding@gmail.com>,
        Rob Herring <robh@kernel.org>,
        =?UTF-8?Q?Krzysztof_Wilczy=c5=84ski?= <kw@linux.com>,
        Bjorn Helgaas <bhelgaas@google.com>,
        Vidya Sagar <vidyas@nvidia.com>, linux-tegra@vger.kernel.org,
        linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20220928121911.14994-1-pali@kernel.org>
 <220b0fe7-8b7b-cf9b-e28d-d9d81647fb80@nvidia.com>
 <20221011161638.ycxpg3ox2wv63vym@pali>
 <18a48407-9fd7-175d-0c7f-5702b077f13d@nvidia.com>
 <Y00HiWT+N6Fo9KVD@lpieralisi>
From:   Jon Hunter <jonathanh@nvidia.com>
In-Reply-To: <Y00HiWT+N6Fo9KVD@lpieralisi>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MFQrV3k3SFgwRUh2em8zY0hSWHJGbklHdHpYQ2NGUkJvbUZNenRoZFUzUnNm?=
 =?utf-8?B?cEpucnpKSnZTVW1xbWd4SGMycE0vbjNYSVM3bDlobDM1aU90WFBCZDl5OWdD?=
 =?utf-8?B?elVYYkxOMytvaHBuZnRBaFNmNjN2OGliVTNXYjR5eHJnWE1MWGlNYUdDNitm?=
 =?utf-8?B?VllRUXV5VktaYkVjQy81NUV3QW5oYmo2SXk1VjAxL1NDbEwzTXAveXpMa3FQ?=
 =?utf-8?B?ME5rdjNzbTNsRUJiODdsdmN5TnF5bkxkTTZvb0pBTDhVOWM0aHlHNXl6OXU5?=
 =?utf-8?B?alpsTU1CRUErM1Q3cTI1TXdkNlJZY1FrRHg0dGpGeHpzajVhODJNZldLSlIw?=
 =?utf-8?B?TXh3R29JcFFvYUFFQ1dVQXBydk9RWVZWa1BXOWJOdW95VGNXVlJ2N1FteXdD?=
 =?utf-8?B?citxYndYYTFUTG9BbmRJWkJrQUM5NDNDVnFGY0NjQjZ4STJvV3Avdk4yMmg3?=
 =?utf-8?B?ZHJoUk81bjdNZnEwYjFVWW1PbHBDaEVjWUJZd0Z5WDFXanVDMUZGRlJQWkNN?=
 =?utf-8?B?SXZZL3I1bnZvL1NhMzF1d1p3WDMwKzFUaVZDV01wTE5vTk9TV05TZEhkUzFS?=
 =?utf-8?B?RGVTWTJneW9HaWVCamRWeC9XOUhlQWgyak10bEhKblhHRTZTM0hCOVpCMWRY?=
 =?utf-8?B?ODJlZjR2ZmFULzduZDZXak1VeWljRjBTMDVJRWVxU1FsUlhHenloKzl2Qzht?=
 =?utf-8?B?aWF4Q3JHdHRQSXphclljU3RLbEo5bHRsNjMzSE93aWwxTGZsVmhOVnYyNCtK?=
 =?utf-8?B?bWFjSG03TmpiNUZlbWNEbjlZZ3l4b3VTV2FzKzVNQ2Z0d3l0YWtZNGdiQ3RE?=
 =?utf-8?B?U0hyZVZZVnVtcXVzNHp2d2FMRkszUUYvMkdJWnlJWWl6NGNNTFVsZWp2aU4r?=
 =?utf-8?B?cktsbzkwd0pvOGVDaHRjTnJqY1dJaFZ3R1Z5Z3ExZWNTSzR4Y2J2ZlkxNUpK?=
 =?utf-8?B?ZHlYdTRsNm0wT250d3E3eklKRU5MVHEyb3hrOGFUTlNENVBpT1lKVUV4VDVV?=
 =?utf-8?B?SmhuZklEMHpsNHhxQkdnbGZBU3k4aW5FVjBPMDBpdnp1akJxU254SHRjanJj?=
 =?utf-8?B?eEx0elB5WnpteHhSNTRIVDFJdHZXQ3d5aHJrakRONHR0VjA4aHBzSEd3YWN5?=
 =?utf-8?B?bEJlL1BmSWt2MllrYkFRSXVWdk5TanJMSEJIWXN6cStUcFYxUlc3Y2FaSmtM?=
 =?utf-8?B?YVYvdVViWDdYNDhqVWU5cExnS1dtZW05akcwUThFWkxEbkpaQUtaaEpYTldK?=
 =?utf-8?B?TVZvMExFeEpxTEhsQXFKenozaGMwd1BSVlptL3c0M3RvOTh5NEFhcGNsZG5v?=
 =?utf-8?B?ODFzR243cWhoa25zWnp1OGdzaW54WitNYlU2aDJabE1hSG9NQlU1UDNhbEJq?=
 =?utf-8?B?NDNYWXlGaldlaW1jb1I4VmlQcTFwY3EwRDNTL0ZUTFp4UE45bWhMMFFJT0V1?=
 =?utf-8?B?TzU1dnFuZ1d3WUZydklRUkpsMGJUYmpQZFJueWJ3YWtrWWk2bXBWYTlQbTNJ?=
 =?utf-8?B?YUpIMkYvRzJSeFNPOUlodUg1NGV3S29RMmFzVXBRNHY3VmNlYmZKaDc2MkFI?=
 =?utf-8?B?OEtnZmZ5YUdnSmZUR0tQd3Zac2lwaFBIVmZyU0Q4SksxYjgrQUdxRDhRM2ZQ?=
 =?utf-8?B?SVdmMXlTYTNuZXV5SVpldS9KVEFkUTFiOVhSb2VFR0FkRGRYL0Y5NTVWQm54?=
 =?utf-8?B?WmpyRDdKNS9TMVRScnhqYWY0VVVIcHRENWt4Rzl3elg3WnY2NkRKVmY0YXps?=
 =?utf-8?B?NDUxNU9YR1BqTUFmSGoreUlTWDdSdkptYzBnUTFKcmg3cDJpT1poZjh2djRn?=
 =?utf-8?B?cDROT1QxRHpxYWNOY2l0ZHBhaTFxenhPZFZvdEZwOUY3bHNLS1ZGYk5SSkVy?=
 =?utf-8?B?RlU3Ukwrb0N2L0VVTFQ0aVRsdFdaakl0M1l4SldKQkx6WkU4WkoxL1NtUXNM?=
 =?utf-8?B?YnIxUGFFN21KZGhONTR5dC85bjgzTjZEYnZobUVMWjdiQ3NldnhTZG45UVBZ?=
 =?utf-8?B?TjROWFVNTjlGOUF0THd2U3ZaLzkxc252Y1crczdzZTl0aHU5d294NkNvRndX?=
 =?utf-8?B?b0ZQZ2lIMVB5NjhOa25OL3FIYnhsSkh5dTFoRzBMTUErVy9yYTVqZkFZNFNn?=
 =?utf-8?B?OENrRXR5ajhWSkRZNTQ5RWYyaWNKV1Fua2pkZURwWFYxaDZUNXlUZ2tXck16?=
 =?utf-8?Q?87NGhB7BZtywu3RS5LWBStO3aBYyelj6gUgMfwOKoCms?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 11e8580f-98f9-4411-22d3-08dab01b51bf
X-MS-Exchange-CrossTenant-AuthSource: CO6PR12MB5444.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Oct 2022 08:41:01.1088
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: bgFsrTo7OoQVwEIAo1dRgCcZ5FnqqamNBkTjqRSr9EOJPy2W1GKU+szI3SI9dBCGSg1rnAu8PvwK1mSsI+p/Fw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR12MB7167
X-Spam-Status: No, score=-1.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        NICE_REPLY_A,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS,SPF_NONE autolearn=no
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 17/10/2022 08:43, Lorenzo Pieralisi wrote:
> On Tue, Oct 11, 2022 at 05:47:50PM +0100, Jon Hunter wrote:
>>
>> On 11/10/2022 17:16, Pali Rohár wrote:
>>
>> ...
>>
>>> I see, this is stupid mistake. PCIe config read and write operations
>>> needs to be 4-byte aligned, so normally it is done by calculating 4-byte
>>> aligned base address and then using appropriate cpu load/store
>>> instruction to access just defined size/offset of 4-byte config space
>>> register.
>>>
>>> pci-tegra.c is using common helper functions pci_generic_config_read()
>>> and pci_generic_config_write(), which expects final address with offset,
>>> and not 4-byte aligned address.
>>>
>>> I'm not sure what should be the proper fix, but for me it looks like
>>> that pci_generic_config_read() and pci_generic_config_write() could be
>>> adjusted to handle it.
>>>
>>> In any case, above patch is a regressions and I see there two options
>>> for now:
>>>
>>> 1) Reverting that patch
>>>
>>> 2) Adding "offset |= where & 0x3;" after the PCI_CONF1_EXT_ADDRESS()
>>>      macro to set also lower 2 bits of accessed register.
>>>
>>> Jon, Lorenzo, what do you think? Could you test if 2) is working fine?
>>
>>
>> I tested 'offset |= where & 0xff' which is essentially the same as the above
>> and that is working and so I am sure that the above works too. However, I do
>> wonder if reverting is simpler because we already have a '&
>> ~PCI_CONF1_ENABLE' and now adding '| where & 0x3' seems to diminish the
>> value of this change.
> 
> Hi Jon,
> 
> it is unfortunate but I think we should proceed with a revert, please
> send it and I shall ask Bjorn to send it for one of the upcoming -rcX.

I have sent a revert for this change.

Thanks
Jon

-- 
nvpublic