Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 17 Oct 2022 11:08:08 +0200
From:   Greg KH <gregkh@linuxfoundation.org>
To:     Yang Yingliang <yangyingliang@huawei.com>
Cc:     linux-kernel@vger.kernel.org, rafael@kernel.org
Subject: Re: [PATCH] kobject: fix possible memory leak in
 kset_create_and_add()
Message-ID: <Y00beLWxbp1ODaB/@kroah.com>
References: <20221017023327.1793893-1-yangyingliang@huawei.com>
 <Y0zfPKAgQSrYZg5o@kroah.com>
 <9c2e91e1-dd07-8a4b-999c-9a2d26ee5f07@huawei.com>
 <Y00XKw+Vs5Bo8jkZ@kroah.com>
 <3a661911-fb26-3d36-a78b-0778c0fceec2@huawei.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <3a661911-fb26-3d36-a78b-0778c0fceec2@huawei.com>
Precedence: bulk

On Mon, Oct 17, 2022 at 05:01:04PM +0800, Yang Yingliang wrote:
> 
> On 2022/10/17 16:49, Greg KH wrote:
> > On Mon, Oct 17, 2022 at 04:13:03PM +0800, Yang Yingliang wrote:
> > > Hi,
> > > 
> > > On 2022/10/17 12:51, Greg KH wrote:
> > > > On Mon, Oct 17, 2022 at 10:33:27AM +0800, Yang Yingliang wrote:
> > > > > If kset_register() fails in kset_create_and_add(), the name allocated
> > > > > in kset_create() will be leaked.
> > > > How is kset_create_and_add() failing?  Is this in a real kernel, or
> > > > created with a fake fault injection?
> > > Inject fault while probing module qemu_fw_cfg, kset_create_and_add() may
> > > fail.
> > Ah good, it's never being hit in a real situation.  The next time you
> > submit patches that are found like this, please include this type of
> > information.
> OK. Do I need to send a v2 with commit message update.

That would be wonderful for you to do, thank you!

Also do the same thing for the other patches you sent that fix up error
paths like this.

thanks,

greg k-h