Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <3945912b-580b-d1bc-35f8-9debdffe9b15@amd.com>
Date:   Mon, 17 Oct 2022 15:03:42 +0530
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.3
Subject: Re: [PATCH v2] perf: Rewrite core context handling
Content-Language: en-US
To:     Peter Zijlstra <peterz@infradead.org>
Cc:     acme@kernel.org, alexander.shishkin@linux.intel.com,
        jolsa@redhat.com, namhyung@kernel.org, songliubraving@fb.com,
        eranian@google.com, ak@linux.intel.com, mark.rutland@arm.com,
        frederic@kernel.org, maddy@linux.ibm.com, irogers@google.com,
        will@kernel.org, robh@kernel.org, mingo@redhat.com,
        catalin.marinas@arm.com, ndesaulniers@google.com,
        srw@sladewatkins.net, linux-arm-kernel@lists.infradead.org,
        linux-perf-users@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
        linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org,
        sandipan.das@amd.com, ananth.narayan@amd.com, kim.phillips@amd.com,
        santosh.shukla@amd.com, Ravi Bangoria <ravi.bangoria@amd.com>
References: <20221008062424.313-1-ravi.bangoria@amd.com>
 <Y0VTn0qLWd925etP@hirez.programming.kicks-ass.net>
 <ba47d079-6d97-0412-69a0-fa15999b5024@amd.com>
 <Y0V3kOWInrvCvVtk@hirez.programming.kicks-ass.net>
 <Y0WsRItHmfI5uaq3@hirez.programming.kicks-ass.net>
 <174fb540-ec18-eeca-191d-c02e1f1005d2@amd.com>
 <Y0awHa8oS5yal5M9@hirez.programming.kicks-ass.net>
 <Y0cn1xazYpNmqhRo@hirez.programming.kicks-ass.net>
 <99caec5f-dcdf-70c6-8909-11552ce42a20@amd.com>
 <Y0fvpQEEl/tK6mJ5@hirez.programming.kicks-ass.net>
 <0df72f8e-1c17-2140-c841-5a75fb43db14@amd.com>
From:   Ravi Bangoria <ravi.bangoria@amd.com>
In-Reply-To: <0df72f8e-1c17-2140-c841-5a75fb43db14@amd.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Y1ZDUUdlRGJ3L2F3a2kxMkhraG8yV2doV1VmcWlacy9ETGhLVnNnLzVUZ1N0?=
 =?utf-8?B?d05mV2RSak91V1dndUU2R3pIM09SY29WUk1YMDkrc1pHZmxZSFA0Y1VJWmhJ?=
 =?utf-8?B?YnBaOHBUZ214UXZxUHdJdVY4S2lZSUxRSnVLbU4vOHJQK3g0eGFEd2ZOelEw?=
 =?utf-8?B?S0tNUERQZm84UHJFTEQyWU9zR3g1RjVnbFRQM055aksyQ0hNbXIxNDg4a3VR?=
 =?utf-8?B?QTBxblUrc1kyTXNtb0xiVzBlZUZkVmhMdnI4M3dYMzRpZGF1WnZlZS9yK3pW?=
 =?utf-8?B?Z2JHTTQwd1NTSXFybUwwQ295eXJ2WlI5ZVd4VUt5ZG53QTFhKzdyNEI2L1BR?=
 =?utf-8?B?d2JWd0JKNzBObzFmODlSVXNxTVRpOUszOWhnM0VnRDFiK3h1ZERJaGJ6aE91?=
 =?utf-8?B?Y1FqN01rZk9uV2NNR0YxbEhMTTFDRGg3eFVSMFd5SWZ2dGpuNnlIL254UnRL?=
 =?utf-8?B?U2JQRzJ5ZTFjbDcrNHBBTEZPcDVaazdFOHNUVW5RTHQyd2tET3hBYUgxclF2?=
 =?utf-8?B?RkI1dWZjQWR6VzlpeHJETnNjc2FaTGk1ejcvQ2RsRi9pOWhyeTFXZkxSa2h3?=
 =?utf-8?B?MSt0U2FZWW55R3BSRDRSVEp5UVYzWlJDbGRFRzhoekNmVXFQQmlTbjJxUEVB?=
 =?utf-8?B?czZCaCtHUmtQYi96VWhwd2l5NnEwcWcvMFZET3FFbitST2hWNUJtSkJqd2Q1?=
 =?utf-8?B?dUVXbVpGbUlzSktDRTJZaUJjRkJ2NXlQTWdrWGJDdHBrZ05pRHJScGtRd2Fz?=
 =?utf-8?B?THdnLzJ3UXNkMlBSYm5TVzMwcXUzOGphYXJBWkFEWTFzS2V4dXFGS0V4R0I0?=
 =?utf-8?B?Mm1FTFBDOFNBSkVrWmZnRWZZdmhzeERFQjhMSWhzOXVyVGczU2svd2syWm03?=
 =?utf-8?B?YWo3OGNndFN2K3dhZ2JuTCtaNXMyVHpySXBaZ2xwUXVKaUhSa2NVSnUybVd3?=
 =?utf-8?B?MmRaZmpqeG9hNm9idEY3OGxkaU1mdXZFbHBMKzlNY1liVXlRN0Q3c0xkWFBk?=
 =?utf-8?B?WG9FRmg3RVJDT0RvWWl4UGNicHdkQlI0Mlp1aWtPRGhGblpwL1daVjMwQnll?=
 =?utf-8?B?OWhheHhKN2ZJK2hDdXd2M05mUlh1SzJjYXdwTnE4S3E2UGNSV0xxTTRxcDI4?=
 =?utf-8?B?V2V1Y2M0WklUa0dIcU9wNExFenV2SDE3Sit2c1R2VXFOUzVuNEhjVm13bEs0?=
 =?utf-8?B?d3hZMGRnQzhHWTlHQno4YkI3Q0lxTmxkUHArcksxaEV0QzQ1ZWxsKzJUa0Rx?=
 =?utf-8?B?K2hGSmpJOHkrcjZjOXdLVFVBZUdIYlFkNFdWYWNpeHZzbjZ2ZzJaRVZLOEdx?=
 =?utf-8?B?V0NJaTVmQjl5ZHhvQjE2cXV3V2VmdCtTTGRlekN2bVJMblpvSTl1NERIMk1W?=
 =?utf-8?B?UlRjb2lYOWt2Q3QxYVVoV2V0K0F0eHJKR2VvWGVCTnZxV294VHl1QmZqWWpE?=
 =?utf-8?B?VUFLcVkyR0RrVGVGd1laMGE4MUV6ZFMvM0VJejBOaUNKemUvcWhPVitHOTRi?=
 =?utf-8?B?RDhjcUU3b2V3SzNDTDNkbU1DVzRoTkdKc1hReWk5ZVQ0dUxDMjUzK1ZqWEdT?=
 =?utf-8?B?ZlVHT1ZhNjdjd090bWFHUTc5RGorTVNIczg4U2ZwTWMzblhHZlc0V2VLcWZz?=
 =?utf-8?B?dmFYTStTdXJIM2ZmQVlDVmdjVUpMd1JENllNNkREeExTZU03cEF2c2Y0VWg1?=
 =?utf-8?B?eFN2c2RIWSs2SHluNXFsTTdoVmszYWR1UlhSQXFISjRZNTZjTE9mRm1XOXk3?=
 =?utf-8?B?dkVhUXUreU1tenl2WjJmSkZsSVdYSU1iRk5RMkxlSE9WWWJlbVl0OEY3L0Zh?=
 =?utf-8?B?SWRuTnZLeHpJMTl1RkczZGZNbUd4eEFRdW5LdEwxODk5Z1FUVHhxNlQ4eEps?=
 =?utf-8?B?Skt4R0plYm0rV3NKK2RJekcrUWt3UzZPdW5NcmVuQlpnUkNPVDI3RmFFS29r?=
 =?utf-8?B?alFVMXhuRTJSdEJzZEFQaGoxcm1aM2ZmV05oM1Y2Z2FxWjhkSlFBc01WWXJo?=
 =?utf-8?B?Ymk4eHh1UDdCNWtSM1YrNWZlUDRQWDBJR1E5cVFUYlBGb1o0REZFNm5qckFF?=
 =?utf-8?B?VzhtODIvY0JiNGtBNk02L2lpUFBSd0hLSUQvVGZmbERGY1VtcjR6V2tkSGkv?=
 =?utf-8?Q?q2T7RXnQBpey3i4JO/auocKMs?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 9f5a9fa4-4d3a-4216-b185-08dab022b72f
X-MS-Exchange-CrossTenant-AuthSource: PH7PR12MB6588.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Oct 2022 09:33:57.9778
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: nqrOadQ/ERuX0ziUPpBecZhIWcmUWB+xS7Z445zTnX/NnpM/JgQPlZkoxMlmh+XQXPCYT5i1/8WIjezTovvoFg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR12MB6904
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 14-Oct-22 3:26 PM, Ravi Bangoria wrote:
> On 13-Oct-22 4:29 PM, Peter Zijlstra wrote:
>> On Thu, Oct 13, 2022 at 03:37:23PM +0530, Ravi Bangoria wrote:
>>
>>>> -	refcount_t			refcount;
>>>> +	refcount_t			refcount; /* event <-> ctx */
>>>
>>> Ok. We need to remove all those // XXX get/put_ctx() from code
>>> which we added to make refcount a pmu_ctx <-> ctx.
>>
>> Them already gone :-) I've not yet fixed up the typoes, but current
>> version should be here:
>>
>>   https://git.kernel.org/pub/scm/linux/kernel/git/peterz/queue.git/log/?h=perf/core
>>
>> Thanks!
> 
> I've been running perf-fuzzer on Xeon machine since yesterday and I don't see any
> issue. Will do the same on my AMD machine as well over the weekend.

Only one WARN_ON() hit. Otherwise all good.
https://lore.kernel.org/lkml/8d91528b-e830-6ad0-8a92-621ce9f944ca@amd.com

Thanks,
Ravi