Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Mime-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset=UTF-8
Date:   Mon, 17 Oct 2022 11:25:57 +0200
Message-Id: <CNO39RACPFL9.13SXHBXOMYMT2@ancom>
Cc:     "Henrik Rydberg" <rydberg@bitmath.org>,
        "Luca Weiss" <luca@z3ntu.xyz>, <linux-kernel@vger.kernel.org>,
        <linux-input@vger.kernel.org>
Subject: Re: [PATCH v3 2/3] Input: add driver for Himax hx83112b touchscreen
 devices
From:   "Job Noorman" <job@noorman.info>
To:     "Dmitry Torokhov" <dmitry.torokhov@gmail.com>
References: <20221016102756.40345-1-job@noorman.info>
 <20221016102756.40345-3-job@noorman.info> <Y0zX0e6WbLaRuTqv@penguin>
In-Reply-To: <Y0zX0e6WbLaRuTqv@penguin>
Precedence: bulk

Hi Dmitry,

Thanks for your review! I've addressed all your comments and will send an
update momentarily. I just have a small reply below.

On Mon Oct 17, 2022 at 6:19 AM CEST, Dmitry Torokhov wrote:
> > +struct himax_event {
> > +	struct himax_event_point points[HIMAX_MAX_POINTS];
> > +	u8 majors[HIMAX_MAX_POINTS];
> > +	u8 pad0[2];
> > +	u8 num_points;
> > +	u8 pad1[2];
> > +	u8 checksum_fix;
> > +} __packed;
> > +
> > +static_assert(sizeof(struct himax_event) =3D=3D 56);
>
> Is this different from BUILD_BUG_ON()?

Their intent is the same but BUILD_BUG_ON() cannot be used at the global
scope. Hence, static_assert() is necessary here.

Best regards,
Job