Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 17 Oct 2022 17:50:24 +0800
From:   Ming Lei <ming.lei@redhat.com>
To:     Chaitanya Kulkarni <chaitanyak@nvidia.com>
Cc:     "linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "axboe@kernel.dk" <axboe@kernel.dk>,
        "damien.lemoal@opensource.wdc.com" <damien.lemoal@opensource.wdc.com>,
        "johannes.thumshirn@wdc.com" <johannes.thumshirn@wdc.com>,
        "bvanassche@acm.org" <bvanassche@acm.org>,
        "shinichiro.kawasaki@wdc.com" <shinichiro.kawasaki@wdc.com>,
        "vincent.fu@samsung.com" <vincent.fu@samsung.com>,
        "yukuai3@huawei.com" <yukuai3@huawei.com>
Subject: Re: [PATCH] null_blk: allow teardown on request timeout
Message-ID: <Y00lYIhUNv1CxqiK@T590>
References: <20221016052006.11126-1-kch@nvidia.com>
 <Y00fkc1N+Cif/Kxt@T590>
 <0af3d1a4-8166-ea1e-8710-c51479c587a1@nvidia.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <0af3d1a4-8166-ea1e-8710-c51479c587a1@nvidia.com>
Precedence: bulk

On Mon, Oct 17, 2022 at 09:30:47AM +0000, Chaitanya Kulkarni wrote:
> 
> >> +	/*
> >> +	 * Unblock any pending dispatch I/Os before we destroy the device.
> >> +	 * From null_destroy_dev()->del_gendisk() will set GD_DEAD flag
> >> +	 * causing any new I/O from __bio_queue_enter() to fail with -ENODEV.
> >> +	 */
> >> +	blk_mq_unquiesce_queue(nullb->q);
> >> +
> >> +	null_destroy_dev(nullb);
> > 
> > destroying device is never good cleanup for handling timeout/abort, and it
> > should have been the last straw any time.
> > 
> 
> That is exactly why I've added the rq_abort_limit, so until the limit
> is not reached null_abort_work() will not get scheduled and device is
> not destroyed.

I meant destroying device should only be done iff the normal abort handler
can't recover the device, however, your patch simply destroys device
without running any abort handling.


Thanks,
Ming