Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20221007151647.98222-1-Ryan.Wanner@microchip.com>
In-Reply-To: <20221007151647.98222-1-Ryan.Wanner@microchip.com>
From:   Linus Walleij <linus.walleij@linaro.org>
Date:   Mon, 17 Oct 2022 11:52:24 +0200
Message-ID: <CACRpkdZv0_E8o4ctYr+UEsQG8XqnFATq6jXmKTrbyWh4WJfz+A@mail.gmail.com>
Subject: Re: [PATCH 0/2] pinctrl:at91-pio4:add support for pullup/down
To:     Ryan.Wanner@microchip.com
Cc:     ludovic.desroches@microchip.com, nicolas.ferre@microchip.com,
        alexandre.belloni@bootlin.com, claudiu.beznea@microchip.com,
        linux-arm-kernel@lists.infradead.org, linux-gpio@vger.kernel.org,
        linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Fri, Oct 7, 2022 at 5:16 PM <Ryan.Wanner@microchip.com> wrote:

> From: Ryan Wanner <Ryan.Wanner@microchip.com>
>
> This patch set adds support for pull up/down pinctl configuration.
> The implementation is based off of other pinctl drivers that have
> implemented line bias configurations.
>
> The second patch addes a case for PIN_CONFIG_PERSIST_STATE
> this shows up becuse the gpiod api passes this into the new config_set
> function that was just implemented. Looking at other drivers like TI
> driver, added the ENOTSUPP to the switch case for that state flag.
>
> How this was tested was by using a gpio program that I created to test
> configuration from userspace. This program was run in the
> background using & then using gpioinfo function checked if the change
> has been detected by the gpiod api. Then using devmem reading the
> regester making sure that the correct bit was set. The registers where
> checked before and during the program is being run, making sure the
> change happens.
>
> In the program Pin 127 would be passed into the test program. Before
> the program was ran devmem for pin 127 config register. After
> the progam is running in the background devmem for the same status
> register is called, the result is showing the change in pinconfig.
> The device used to test was the SAMA5D27_som1_ek.
>
> Ryan Wanner (2):
>   pinctrl: at91-pio4: Add configuration to userspace
>   pinctrl: at91-pio4: Add persist state case in config

Patches applied!

Yours,
Linus Walleij