Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 17 Oct 2022 17:57:43 +0800
From:   Leo Yan <leo.yan@linaro.org>
To:     Adrian Hunter <adrian.hunter@intel.com>
Cc:     Arnaldo Carvalho de Melo <acme@kernel.org>, suzuki.poulose@arm.com,
        linux-perf-users@vger.kernel.org, mathieu.poirier@linaro.org,
        mike.leach@linaro.org, Peter Zijlstra <peterz@infradead.org>,
        Ingo Molnar <mingo@redhat.com>,
        Mark Rutland <mark.rutland@arm.com>,
        Alexander Shishkin <alexander.shishkin@linux.intel.com>,
        Jiri Olsa <jolsa@kernel.org>,
        Namhyung Kim <namhyung@kernel.org>,
        linux-kernel@vger.kernel.org, coresight@lists.linaro.org,
        Sven Schnelle <svens@linux.ibm.com>,
        James Clark <james.clark@arm.com>,
        Christian Borntraeger <borntraeger@linux.ibm.com>,
        Carsten Haitzler <carsten.haitzler@foss.arm.com>
Subject: Re: [PATCH] perf tools: Fix man page build wrt perf-arm-coresight.txt
Message-ID: <Y00nFxrcV7TVqmJO@leoy-yangtze.lan>
References: <a176a3e1-6ddc-bb63-e41c-15cda8c2d5d2@intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <a176a3e1-6ddc-bb63-e41c-15cda8c2d5d2@intel.com>
Precedence: bulk

On Mon, Oct 17, 2022 at 12:35:49PM +0300, Adrian Hunter wrote:
> perf build assumes documentation files starting with "perf-" are man
> pages but perf-arm-coresight.txt is not a man page:
> 
> asciidoc: ERROR: perf-arm-coresight.txt: line 2: malformed manpage title
> asciidoc: ERROR: perf-arm-coresight.txt: line 3: name section expected
> asciidoc: FAILED: perf-arm-coresight.txt: line 3: section title expected
> make[3]: *** [Makefile:266: perf-arm-coresight.xml] Error 1
> make[3]: *** Waiting for unfinished jobs....
> make[2]: *** [Makefile.perf:895: man] Error 2
> 
> Fix by renaming it.
> 
> Reported-by: Sven Schnelle <svens@linux.ibm.com>
> Reported-by: Christian Borntraeger <borntraeger@linux.ibm.com>
> Fixes: dc2e0fb00bb2 ("perf test coresight: Add relevant documentation about ARM64 CoreSight testing")
> Signed-off-by: Adrian Hunter <adrian.hunter@intel.com>

Thanks for fixing, Adrian.  The change LGTM:

Reviewed-by: Leo Yan <leo.yan@linaro.org>

> ---
>  .../Documentation/{perf-arm-coresight.txt => arm-coresight.txt}   | 0
>  1 file changed, 0 insertions(+), 0 deletions(-)
>  rename tools/perf/Documentation/{perf-arm-coresight.txt => arm-coresight.txt} (100%)
> 
> diff --git a/tools/perf/Documentation/perf-arm-coresight.txt b/tools/perf/Documentation/arm-coresight.txt
> similarity index 100%
> rename from tools/perf/Documentation/perf-arm-coresight.txt
> rename to tools/perf/Documentation/arm-coresight.txt
> -- 
> 2.25.1
>