Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 17 Oct 2022 17:47:13 +0800
From:   Huang Rui <ray.huang@amd.com>
To:     "Yuan, Perry" <Perry.Yuan@amd.com>
Cc:     "rafael.j.wysocki@intel.com" <rafael.j.wysocki@intel.com>,
        "viresh.kumar@linaro.org" <viresh.kumar@linaro.org>,
        "Sharma, Deepak" <Deepak.Sharma@amd.com>,
        "Limonciello, Mario" <Mario.Limonciello@amd.com>,
        "Fontenot, Nathan" <Nathan.Fontenot@amd.com>,
        "Deucher, Alexander" <Alexander.Deucher@amd.com>,
        "Huang, Shimmer" <Shimmer.Huang@amd.com>,
        "Du, Xiaojian" <Xiaojian.Du@amd.com>,
        "Meng, Li (Jassmine)" <Li.Meng@amd.com>,
        "linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [RESEND PATCH V2 2/9] cpufreq: amd_pstate: add module parameter
 to load amd pstate EPP driver
Message-ID: <Y00koVkHD3ECCY7H@amd.com>
References: <20221010162248.348141-1-Perry.Yuan@amd.com>
 <20221010162248.348141-3-Perry.Yuan@amd.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20221010162248.348141-3-Perry.Yuan@amd.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?aiz30Xdy2f5oCRbk7Hdpt9bXj8qJtaghsJje48sTYJWHp64hc0R41XIunatO?=
 =?us-ascii?Q?0U7Cbr/Blw3CIfXzd3cDCON2Va4njLt9sP3c/jtccfXXZ/Xu6nmbsHtuOADW?=
 =?us-ascii?Q?A4vGqfUhAWi0RYTWfi+ITqhYXKl0zZztj40kGbxVjB2i/DnE9tthax2147hC?=
 =?us-ascii?Q?QeN2CtPHqJRIHh7TKvWAQPxa0JzoSgrN6NX0ymrEfn0qP+Hw/ZYaHDXspgRm?=
 =?us-ascii?Q?Oekab0oc1Z6YEXjaN8HIjASRDpzyz72r8l89OvLaB3wxEUQRRaEWOiD+Zy50?=
 =?us-ascii?Q?Ir08eGNkEgbwTimX2C+U6VoZbG+5L2QcWVi1U2dqdUL1lExDF4ek+e6uR7M6?=
 =?us-ascii?Q?Vwptm++dgp/OgHhV8YsOSnssYzncsvOMLP6gWL/7rX9Ik60Tsod306fuNZJy?=
 =?us-ascii?Q?hFczZDVHMwoekAL/Ya20vJywCw5SqfYj8o8JesvQMuy57BNejZXiu482fMSZ?=
 =?us-ascii?Q?gtMy4hxNFikXn1QN1frSExSGw7bAlExLuobOSYMMH2mkxkedW9althVA0CnK?=
 =?us-ascii?Q?RAgwGqI4KuFgKekfzWLOfHV1NDdIIYCQ+e9YU2eIer9+LgIr8iWyj/laOFNs?=
 =?us-ascii?Q?yRuPNInWHf3lwLUUvxFIIL/Qsoiu1sQ7g4/JdNXaFjrpsPbaSyRh0wFaXCSc?=
 =?us-ascii?Q?zrfNR0GW5iC+VMeXuvJdbO5DEnDU9JVhefUUIOzukMYDG62UD2trnWveAvUt?=
 =?us-ascii?Q?5hxEkQFJn4/gRDyCZ5OxVTxaKw9ACMoLm9Ha9TaUxqJc28MamAAGxXR7iFpb?=
 =?us-ascii?Q?2YEy4eLU/9IegCEMPrMg2s3EdhFLWBt6Es7itYJAvBoTzk/XMpvEjNfEQows?=
 =?us-ascii?Q?sQsyOugvu0oALw3kEUm/z3rPunHETXhGqPJuPAcZh5dHp+w7TZEkW2qnXobH?=
 =?us-ascii?Q?S4KyWp2O/fsi+UpELmpcHjmAsHpM1jpj2JBJb5iu9DJWMM0X4wJMnD1sinx4?=
 =?us-ascii?Q?xq8xCD400gEJXvXgN9qooCGE1mH7+T9vNUc8D8itwvtWBSTgnYVmLsp5s/QT?=
 =?us-ascii?Q?AxsVfORM2nd62FfFQQEIUNSi2K78BPHOj6a7ZuMBNfZFImDb+nxT8foGDdk+?=
 =?us-ascii?Q?+qy2ncvYJ+Lv/eDaXCDdap0XhwpaBaHUdQTZGvIRYwfO2eEoj56l4mqZ/HVB?=
 =?us-ascii?Q?orCBauMstfy32RLasryE/ygOqeQ15O2JAZzWznVMWd5/q5REsN44rF2n4bFP?=
 =?us-ascii?Q?Rqo6M7Luvf7QaTgm4Pf/QS29rvrcon2Lz3W3XPYr4kQab0hyiVsNTaMHX89r?=
 =?us-ascii?Q?7tSmMc/UXCsE4CQf7KK0qIy6F189dGjCfD23hCYsvKyxNw9F+m/kNzg1ETTp?=
 =?us-ascii?Q?V78r7qiFNwskCNLw/byt3Bnk0yJ6S0JsauujeAksSvy7WIptWRbMVpGY20k/?=
 =?us-ascii?Q?wI6zJAwdBYgTE6lp0X/A190srsrDX39X3LQzYE4Pivs+0XsaoOdp6HmAHS9I?=
 =?us-ascii?Q?bHDMBCK24ultPEFjGLbfC2CraFx6tGf7/IPVxpmX/dVvjlqUMUUGQWENeyTz?=
 =?us-ascii?Q?jnHlnLv1pKki2lBSuzec7P8mv0Tbk1ksGr+cbWRvSUuoiz1QuONTxsvx4caR?=
 =?us-ascii?Q?kiJ1Mf0Ny9ty79+hJNj+MqPYeM+HNxwdiZacW5HF?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 8beb4608-be3d-4130-5be8-08dab0249d9f
X-MS-Exchange-CrossTenant-AuthSource: DM5PR12MB2504.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Oct 2022 09:47:33.7686
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: fm0AsyzMLuAXX+BqXtyWZehbJ6qFqEfD/9GKUW/YQbd//iTaxT7x1V6azwbIcNM+5oA9NJdchdLbLt+CavSh8w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN0PR12MB5929
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Oct 11, 2022 at 12:22:41AM +0800, Yuan, Perry wrote:
> The amd_pstate mode parameter will allow user to select which amd pstate
> working mode as booting mode, amd_pstate instance or amd_pstate_epp instance.
> 
> 1) amd_pstate instance is depending on the target operation mode.
> 2) amd_pstate_epp instance is depending on the set_policy operation mode.It
>    is also called active mode that AMD SMU has EPP algorithm to control the
>    CPU runtime frequency according to the EPP set value and workload.
> 

There is one concern here: how can the user know which kind of processor
supports the EPP function in hardware?

Thanks,
Ray

> Signed-off-by: Perry Yuan <Perry.Yuan@amd.com>
> ---
>  drivers/cpufreq/amd-pstate.c | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/drivers/cpufreq/amd-pstate.c b/drivers/cpufreq/amd-pstate.c
> index f52b8f2fe529..2d28f458589c 100644
> --- a/drivers/cpufreq/amd-pstate.c
> +++ b/drivers/cpufreq/amd-pstate.c
> @@ -63,6 +63,10 @@ module_param(shared_mem, bool, 0444);
>  MODULE_PARM_DESC(shared_mem,
>  		 "enable amd-pstate on processors with shared memory solution (false = disabled (default), true = enabled)");
>  
> +static bool epp = false;
> +module_param(epp, bool, 0444);
> +MODULE_PARM_DESC(epp, "Enable energy performance preference (EPP) control");
> +
>  static struct cpufreq_driver amd_pstate_driver;
>  
>  /**
> -- 
> 2.34.1
>