Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Niklas Cassel <Niklas.Cassel@wdc.com>
To:     John Garry <john.garry@huawei.com>
CC:     "jejb@linux.ibm.com" <jejb@linux.ibm.com>,
        "martin.petersen@oracle.com" <martin.petersen@oracle.com>,
        "jinpu.wang@cloud.ionos.com" <jinpu.wang@cloud.ionos.com>,
        "damien.lemoal@opensource.wdc.com" <damien.lemoal@opensource.wdc.com>,
        "linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linuxarm@huawei.com" <linuxarm@huawei.com>,
        "yangxingui@huawei.com" <yangxingui@huawei.com>
Subject: Re: [PATCH v6 8/8] scsi: libsas: Update SATA dev FIS in
 sas_ata_task_done()
Thread-Topic: [PATCH v6 8/8] scsi: libsas: Update SATA dev FIS in
 sas_ata_task_done()
Thread-Index: AQHY4gWIffPyDhEbSEGGm14VUjG/1q4SZdsA
Date:   Mon, 17 Oct 2022 10:41:03 +0000
Message-ID: <Y00xPoTeYEVkhMMl@x1-carbon>
References: <1665998435-199946-1-git-send-email-john.garry@huawei.com>
 <1665998435-199946-9-git-send-email-john.garry@huawei.com>
In-Reply-To: <1665998435-199946-9-git-send-email-john.garry@huawei.com>
Accept-Language: en-US
Content-Language: en-US
wdcipoutbound: EOP-TRUE
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?oRUSJIdzuQGGRZe5TQneTiyUJtHsk3vEBQ85pBhR6YvqH3KwvgWyuxEyQHFz?=
 =?us-ascii?Q?DlGKqnt3JJqNmLvUALKLv2XV47Lv7xgIDhBaBipArR70SyYnn9K2WJr/GE25?=
 =?us-ascii?Q?D9N1Zuy51WvutliK2QqjkLx7YgTZPV4SckXzSjtoZCYPq2iGdwiGW960U9Mf?=
 =?us-ascii?Q?9B75gXs2wJQt4pIZcKaTbSX43vclhzqb3aDlmaZQESa2VzO4AfHC1qcrNsmo?=
 =?us-ascii?Q?4uob2Z6iHeHi8gfEkrA37Gg893AjidYs+Aw8rzoj5qa/MQIiAN448BNmBiMm?=
 =?us-ascii?Q?Vjp2eWWujBt/uOP5fw84zHr3j3CRX2ZdN+G3+wmTSQUWHA/rhjb4/TTk7ZiW?=
 =?us-ascii?Q?qfnhHN7UBVa+Y4RTkiLZZK/n50Up9WY3QhO/joLz4utCCldsyZbgw1R8tJQw?=
 =?us-ascii?Q?v9MoscXufpboB7h0D7CDLhdUqcg1S6qh8YfeUx2yCe4shM8tMS0DpTxysSFh?=
 =?us-ascii?Q?4WZsR9bx7iV8+ejkdg2gbiPFt7AOWFaFQx4aHOP7eiwRifq+U34DfNcBMI4J?=
 =?us-ascii?Q?xCKhWXy0AYukSrhkreRJ6vOzVnJu+fxApFxXUbGXOKRlC2w9zV7V2gCjrMxG?=
 =?us-ascii?Q?Mr5saICxQmw2IpJlFe7E9n3TKu0f8k54EaTdNVgFyEJZLq9PTZTNghUzDVt/?=
 =?us-ascii?Q?lF7hOw8yus9v76FXpWDiz9avG7UEjIo0MqDGUTOjKHktLrhvw1HJIIsVUtB9?=
 =?us-ascii?Q?PmWlNbCQJGcQ8UK5t7+v/BQFdADQmOFyJ4RIebmlrbYgmaYEh7tQrILr+756?=
 =?us-ascii?Q?aXcd4irjqDFLFU/1AX7pDanUFVCerB7e+EhGp8iPL3tV5DYH/Bhf0alpepf4?=
 =?us-ascii?Q?hG+zh9HGaZ8/Axp0rlNkaTV8PoF/nTvHvxlhQGoYHEO2UwvdpFJwIE7L/idu?=
 =?us-ascii?Q?F034s+1aZe8cELxxcYRMKuMO8UvTpFL5KbtP3iWroSK3zy3ZNo7Wf+/XgVq1?=
 =?us-ascii?Q?eT4iTNgxhHo8EDIbpmClqWq5VYuecx7rQ6O6mGIb4Mb2qU6EEY6YBS9p5eQl?=
 =?us-ascii?Q?5DGL1WE2mU5cUJ9MB8Iv+GPs+9ZhRhWtZT4kRJcAPcN97yKf6SPdqdtVBq2M?=
 =?us-ascii?Q?9vkRs4g1I/38rm0GsrFrEOFfDxdg/CpWdd1XtxfB2qBBMWfsuNGeV860WpWr?=
 =?us-ascii?Q?seeCsagZn1TTg0TDMkfQVOxOUSP8xqPdt5zjWqn+pV4BPRtdyfXWifVk0x1I?=
 =?us-ascii?Q?Spgfy82c18YbR5zAkdnnY1HCxJVX1ZMyfU63hXzN9tlL9ypWTWunDEIfwBWF?=
 =?us-ascii?Q?j1DlQ6z5qPN7fvj6MEgeO2ifi7Bw1q92KbIuFjkauPQ78OYqOEJKdNv6KiC0?=
 =?us-ascii?Q?2FdNy/2JRUu05IB/XCrvJhKYY4HRrfAmuZ4bFmr5IYMlRSmI7tSUFwHXQJNf?=
 =?us-ascii?Q?56BuJYfDHNY0L9vNL1qyqZBw1KRx/8dfA+eZy+QNtSgypSj8Kw9lnJScnBkQ?=
 =?us-ascii?Q?SMFx13drsjNwsZmcV20HXFE09M6CEPgRYtbd+Ns5TIuEmaRPyWT98ZEBmwJI?=
 =?us-ascii?Q?Z6CbsjNCQDjOQ+a3f2Pm7smAxm1lmBJzizmjQRBOx9xszqko/syH13rP1Ueg?=
 =?us-ascii?Q?ouzeBVhyuPXFCHl4Xp8w7TCxgvtci+0NyBfEM3biUbFsPryK3cvSoAJKauBC?=
 =?us-ascii?Q?Bg=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <CECD9F9755BDC94C919BF3799388B8DC@namprd04.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: wdc.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: MN2PR04MB6272.namprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 335643f7-0c34-4e2f-5793-08dab02c1705
X-MS-Exchange-CrossTenant-originalarrivaltime: 17 Oct 2022 10:41:03.7153
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b61c8803-16f3-4c35-9b17-6f65f441df86
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: ARh4LMcZt+HwrMD6LLBZydHgW+/J13Y/y4fH8NWlLcH4SwKYpYHcMkOGZ8ORbWwvKZB5XBUzXhIgheSxXjyJWA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR04MB1243
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_PASS,
        SPF_NONE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, Oct 17, 2022 at 05:20:35PM +0800, John Garry wrote:
> In sas_ata_task_done(), for commands which complete with error we set
> the SATA dev FIS status field with ATA_ERR. In ata_eh_analyze_tf() this
> would be interpreted as a HSM error. Set ATA_DRDY, which will lead libata
> to judge as a device error, which is a safer bet.
>=20
> Signed-off-by: John Garry <john.garry@huawei.com>
> ---
>  drivers/scsi/libsas/sas_ata.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>=20
> diff --git a/drivers/scsi/libsas/sas_ata.c b/drivers/scsi/libsas/sas_ata.=
c
> index 61f64d54e67d..78e6046fb55a 100644
> --- a/drivers/scsi/libsas/sas_ata.c
> +++ b/drivers/scsi/libsas/sas_ata.c
> @@ -139,8 +139,8 @@ static void sas_ata_task_done(struct sas_task *task)
>  				qc->flags |=3D ATA_QCFLAG_FAILED;
>  			}
> =20
> -			dev->sata_dev.fis[3] =3D 0x04; /* status err */
> -			dev->sata_dev.fis[2] =3D ATA_ERR;
> +			dev->sata_dev.fis[2] =3D ATA_ERR | ATA_DRDY; /* tf status */
> +			dev->sata_dev.fis[3] =3D ATA_ABORTED; /* tf error */
>  		}
>  	}
> =20
> --=20
> 2.35.3
>=20

Reviewed-by: Niklas Cassel <niklas.cassel@wdc.com>=