Received: by 2002:a05:6358:1087:b0:cb:c9d3:cd90 with SMTP id j7csp4332524rwi;
        Mon, 17 Oct 2022 05:03:02 -0700 (PDT)
X-Google-Smtp-Source: AMsMyM6CAQ2ZY9y+g8m4vu5QcN4e82sjJpgJSKjNYF1DHS84ikMlDuGSIZZzhltuXv2n/VyN0fUR
X-Received: by 2002:a17:907:8a24:b0:78d:cd60:1022 with SMTP id sc36-20020a1709078a2400b0078dcd601022mr8332584ejc.384.1666008182407;
        Mon, 17 Oct 2022 05:03:02 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1666008182; cv=none;
        d=google.com; s=arc-20160816;
        b=s3aV/k+QpMiCYchhYBOvrlPSYLZ7F8LGAhRkNIKkBbnN8Je/pht3T/KyMcemEDIavA
         ackWn3yMw38PXT8CEPvLQTVolgYcFFA4zaOyRbr0xkf4ppRSVCVaWC8UKaGSMjldIEif
         4JKgWF1xQRAld7Nm4v5GkMrrMDCqJtrSeF9XKs3tP/R86oOvixZNUX196bt/QY6T+P+V
         q4Zjp0+uX4ArR1bM2KMG+mjwrrGU+PKeVQOaXNIj1FDnab9XE93Wm5N2PT/aNlbSQCoc
         knlqadVzrGY32GY3wZ+jSXf0Uu43XclzKIHHiIlZkWQPpWIasAOjYdL6MUkVDOtoAvA9
         Ow2Q==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:in-reply-to:content-disposition:mime-version
         :references:message-id:subject:cc:to:from:date:dkim-signature;
        bh=ILWUUnJmtGV7aeHMCXZZLwmGVJlhgsvZnptaQfncfUE=;
        b=zAdjB331n3HOr0A7Wd+VMGrMBmF/HMI9bEVq3jhY8iNUrYVuLn3APOh/fjMH6opEME
         trBCxLKDPLxJkIVPtGaDD+c4fQ1E9xTXAR8QSfbjjeGGVETlvje8eZMlA+3a17wLUJ96
         RmiiDmh+MfsKPi9sYG2w5gjagjM6b+bQYZ41oVQorYrPNT9AN37g1d0Ix7gjsUn5gAbH
         QO1ebKScCPemZbbeQuHGZgu+l6t6pOZ7YZuI2sJaEdJL9en5+dhGCd6OmLE/lZWIJX8X
         eXDQ4iZZdNgzL1MnDUPqHWOreHKRT8RS5oPY8FTjcJPPz1dj9tLf12f7yp6MeTcSNXJV
         NZmg==
ARC-Authentication-Results: i=1; mx.google.com;
       dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=buma+6Iv;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20])
        by mx.google.com with ESMTP id cw10-20020a170906478a00b00773b8e3b6a1si10871276ejc.805.2022.10.17.05.02.28;
        Mon, 17 Oct 2022 05:03:02 -0700 (PDT)
Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Authentication-Results: mx.google.com;
       dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=buma+6Iv;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S230147AbiJQLg5 (ORCPT <rfc822;aradford@gmail.com> + 99 others);
        Mon, 17 Oct 2022 07:36:57 -0400
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51054 "EHLO
        lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S230133AbiJQLg4 (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 17 Oct 2022 07:36:56 -0400
Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133])
        by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A2C6757BC3;
        Mon, 17 Oct 2022 04:36:55 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
        d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version
        :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To:
        Content-Transfer-Encoding:Content-ID:Content-Description;
        bh=ILWUUnJmtGV7aeHMCXZZLwmGVJlhgsvZnptaQfncfUE=; b=buma+6IvaMsiAqrbzCR92v9ktz
        qEQVyYhJieOyZhb8YSwweyJDN3OaIif/yt+gFwbSZ+E9rkSKaDVtrk2QHfhtERBjUDe/z+mNA+TkF
        SRp21SgtIvUSTP/PpbjEAxliUKVRVl9vnD1vfJzkab9FiGjtkuIpw52XMunVds5mXVtY/odkY7hd7
        bM7A76PT5BN9y5zrivKiU++JNvjBjn3M5pD4xpcniY6vXb4XyCAKmfQ7TQxMCK36dVbkr8v47OgRT
        1b8aushYhNjxSWLiMTfrRmCDI85Lv1pDj56a1dXDNJVdx7t+HBqQM49E/HqmvPh6q7Udl13Qm52Ww
        sG49e0SA==;
Received: from hch by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux))
        id 1okOQE-00ArzE-KL; Mon, 17 Oct 2022 11:36:42 +0000
Date:   Mon, 17 Oct 2022 04:36:42 -0700
From:   Christoph Hellwig <hch@infradead.org>
To:     Yu Kuai <yukuai1@huaweicloud.com>
Cc:     Christoph Hellwig <hch@infradead.org>, axboe@kernel.dk,
        gregkh@linuxfoundation.org, willy@infradead.org, kch@nvidia.com,
        martin.petersen@oracle.com, johannes.thumshirn@wdc.com,
        linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
        yi.zhang@huawei.com, "yukuai (C)" <yukuai3@huawei.com>
Subject: Re: [PATCH RFC] block: fix use after free for bd_holder_dir/slave_dir
Message-ID: <Y00+SsxI7IJ56im8@infradead.org>
References: <20221012125838.1608619-1-yukuai1@huaweicloud.com>
 <Y00LTH0yk3obS22m@infradead.org>
 <dadef634-9ec3-aa7b-f1c0-65a98a0fafb1@huaweicloud.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <dadef634-9ec3-aa7b-f1c0-65a98a0fafb1@huaweicloud.com>
X-SRS-Rewrite: SMTP reverse-path rewritten from <hch@infradead.org> by bombadil.infradead.org. See http://www.infradead.org/rpr.html
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE,
        SPF_NONE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, Oct 17, 2022 at 05:24:20PM +0800, Yu Kuai wrote:
> I agree that this patch do make sense, however, it seems to me this
> patch should fix the problem that kobject is leaked, not uaf... And I
> verified that the problem can still be reporduced with this patch.

Can you share your reproducer?