Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 17 Oct 2022 09:11:34 -0300
From:   Jason Gunthorpe <jgg@nvidia.com>
To:     liulongfang <liulongfang@huawei.com>
Cc:     John Garry <john.garry@huawei.com>, alex.williamson@redhat.com,
        shameerali.kolothum.thodi@huawei.com, cohuck@redhat.com,
        linux-kernel@vger.kernel.org, linuxarm@openeuler.org
Subject: Re: [Linuxarm] [PATCH 1/2] hisi_acc_vfio_pci: Add debugfs to
 migration driver
Message-ID: <Y01GdiFbt2J9La2Y@nvidia.com>
References: <20221014025757.39415-1-liulongfang@huawei.com>
 <20221014025757.39415-2-liulongfang@huawei.com>
 <42d12308-4777-47a7-a1ae-50dfada050cf@huawei.com>
 <7c041671-71bf-d558-d47a-70296fe5c30e@huawei.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <7c041671-71bf-d558-d47a-70296fe5c30e@huawei.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?QWFpdUptdjRWYlhYajNaQjM1ditZTGhVMmU3RnhoYjM4em1wZVV4Z3FUTDRz?=
 =?utf-8?B?NmdDOW5ZQnh6RVNIVGxTb0c1bERkc3pqUGVRQklmOWRObE9hWGNva2JKc2hv?=
 =?utf-8?B?U1BlbERGcEJrNW1EanlXUmdzemsvY2tQREI2Uk5VZmUwVnFlLytQaXBzRDR4?=
 =?utf-8?B?bUdKNzgzSFBGYnZMQkhLWHZ6ZVBZMGtndTFva0lhY2lZdzlVNHpWV0tMUnlv?=
 =?utf-8?B?Q1FZWFIzVUJ2ZzZrOEs4NldrbkxOaEZVYlBaSCtvVEt6VnFmWlR0MFFBK1lz?=
 =?utf-8?B?ZmRSbjdFZ1lUdzU4MDZ1cXcyUVM0ODFvWW53ajVoa3IxVThEZlFSNnIyelVk?=
 =?utf-8?B?VGd4SS9STGttUk5IN1lDRWtjN0NOaFNuZUNJSXhndU1PYSt4YmNVZmQ4bm5r?=
 =?utf-8?B?ZU81blNCaHA5U3plOXRrUXBIUGxTYk5vLzU1TGN2TkVUL1RzZG14OVFQY1NF?=
 =?utf-8?B?ekJiWmgyVjZ3bCswWURSUHNqaysybXJWeFp6N2puaGcvdE5ZU05vamZhbm14?=
 =?utf-8?B?NzNEMGhPREZScjZEOUg0N2dvZ1BCNEpqUHIycnZBMWZaSGhQSDZpQkRWa0tD?=
 =?utf-8?B?dHh2V25JU3hOM01MalJKZHFUNW5UcmF4Q2hvTHo5SDNnbDMyeXgwcmg0UlBG?=
 =?utf-8?B?NEdkc1Nyd1NHNTFFQWo3Sm02TXU1Q0F3V0taTGo0NTI0Y1psNkM3VnNPV21J?=
 =?utf-8?B?OFRBZXdRKzJZdWEzNE93QlJoU1dBWUVUQ0w3UDFjRTRuM2d6RmU4U3psbkxL?=
 =?utf-8?B?S0R3RDQyWkdCV1B3ODJBT2k2c0w1eTNkUHZnVUtVVXZTZlM0VkxFbU1zN2NN?=
 =?utf-8?B?dTR0bTZFdm01K1VhOUFBUUw0eC9JS094bmc0L00vZ2lhb1dxNHBkaFRWMHMv?=
 =?utf-8?B?Q2hIN0x2RFh4RkRXWGwyTmZFczcyeXJZOXJUS1VoR2lWZkNSWDNValVObnIv?=
 =?utf-8?B?aUZTVi8zTDBZY2Fxc0pZNVYySHNVeFVVNlFIMDlxZ2JuaTNTZVIrL2dpeFZY?=
 =?utf-8?B?WmRoczcxenhCOVhBbTVMQWUxQS94WTFYdGJXYnFSZTgxcm80NURqQ2Q4ZFp4?=
 =?utf-8?B?YnhWZUM4T1Y4ZVJ3TzhkaXFjUEJzWmdqL1Frb1JYemg4VzBDWTJJOUJXL05Y?=
 =?utf-8?B?bWQvUDFVb2d5ZFR5cmdBN2dyTFlqVnNjbFZua2R5R1JIT3dDSlRIQVR4ZElt?=
 =?utf-8?B?OTIxbFpOOE96QmVDeU8wMVg0S2VyRFdLcmkwNFdLR0I3N0Vtc0tETEN4Y1Rk?=
 =?utf-8?B?Y3BWMGVYb3RtYlJvVEdZNUdOcmVhNWx6aGYzNHhBVndOWjl5TWtiYURxRDJR?=
 =?utf-8?B?Z050U2t4OXh4U3FEbDc5Z1ZlMHVyNnU2WDhteXdmUGlITGZ4a0FCeHczdHRy?=
 =?utf-8?B?eWFFVWIydlAzMks4WUZ6Q21TeEZkc3lPV3FSN01FYTEzTHNydEhONW1TekNm?=
 =?utf-8?B?ZURuZkFtdlVJcnF6emxWZ1FsWHN1dGlaTmxlV3cxdGwzT00xTHBRaVF1WUU2?=
 =?utf-8?B?a0drU2RORURUSDdjcVZkSUFFczlDWGxKSnRDL2lESk1yVnpuL0oyWStzQWVS?=
 =?utf-8?B?aXVvMjJ0RTVJWDBDVVBLR1JHVjB6ZXhUd241OUFaUXFPdU5zd0pyZmZIOC9Y?=
 =?utf-8?B?VTRYQ3dOL1JYTkNBNE91SmdUUHhnd0VXa09QbFpBTVB1blF5emRJVEs5eXlM?=
 =?utf-8?B?clpVekxjM242ZTBjNm1EWUZuZ2c3WE9XZXZKelhoODMyRVNLSTdKSHg1Rmhh?=
 =?utf-8?B?RlF6bktqWCttZ01OTnpFMGVtOFpoNGV2QzlZQVJUQ1RKQWY5YlgrZEZTOW1l?=
 =?utf-8?B?c1BLaVdyRU5UakFhemNWU1dDY05Tb3NGcUYyTHVtUm9PR2g2VFcvSkllR0JU?=
 =?utf-8?B?bUV6K1V4eFhPL0xlcnQ3TGlPOTBoRG9VMG54WG5MT0dlcjg5dkxvRXRuR29X?=
 =?utf-8?B?MjNOUy8wNHUrMHY5Q3VIQXl6RXViYk1JRkg1dVM4THF2NDlnVVlNNDFmdXZV?=
 =?utf-8?B?Ly9NZTlzM04xTDRhdnUwY3hlalI4RHdSVnVnelQ2c0lnVVVPbGtQSU9JRy9p?=
 =?utf-8?B?SS90d1dlMEtoQWM1MXdBYTVDVU1uUW5HL0lZQjViM2hSdWlRMnNiWFVSRXFE?=
 =?utf-8?Q?mrrqqlRpaqSONtwK3WINRvpiX?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 4e5a9258-54e3-415c-b811-08dab038bc5d
X-MS-Exchange-CrossTenant-AuthSource: MN0PR12MB5859.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Oct 2022 12:11:35.2980
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: s+1NSvehT+ba9Fd89ol57PexPHM7GEkGkH/6ksF27/S9qx//ocPUFWyutcvj5w5x
X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR12MB6434
X-Spam-Status: No, score=-1.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE
        autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, Oct 17, 2022 at 05:20:34PM +0800, liulongfang wrote:
> On 2022/10/14 17:20, John Garry wrote:
> > On 14/10/2022 03:57, Longfang Liu wrote:
> >> +static void hisi_acc_vf_debugfs_init(struct hisi_acc_vf_core_device *hisi_acc_vdev)
> >> +{
> >> +    struct pci_dev *vf_pdev = hisi_acc_vdev->vf_dev;
> >> +    struct device *dev = &vf_pdev->dev;
> >> +    int ret;
> >> +
> >> +    if (!atomic_read(&hisi_acc_root_ref))
> >> +        hisi_acc_debugfs_root = debugfs_create_dir("hisi_vfio_acc", NULL);
> >> +    atomic_inc(&hisi_acc_root_ref);
> >> +
> > 
> > This looks totally racy, such that I wonder why even bother using an atomic for hisi_acc_root_ref.
> 
> 
> When enabling VF, it is possible for multiple VMs to enable VF at the same time. The atomic variable
> is used to ensure that only one "hisi_vfio_acc" is created. When other VFs are enabled,
> it will not be created again, but will be used directly.

It is still completely racy. Use a lock

Jason