Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <ec75ba21-97e0-9479-8d87-46cc8032d44c@amd.com>
Date:   Mon, 17 Oct 2022 09:06:38 -0400
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.3
Subject: Re: [PATCH] drm/amd/display: add a WARN() to irq service functions
Content-Language: en-US
To:     Hamza Mahfooz <hamza.mahfooz@amd.com>
Cc:     Harry Wentland <harry.wentland@amd.com>,
        Leo Li <sunpeng.li@amd.com>,
        Alex Deucher <alexander.deucher@amd.com>,
        =?UTF-8?Q?Christian_K=c3=b6nig?= <christian.koenig@amd.com>,
        "Pan, Xinhui" <Xinhui.Pan@amd.com>,
        David Airlie <airlied@linux.ie>,
        Daniel Vetter <daniel@ffwll.ch>,
        Mario Limonciello <mario.limonciello@amd.com>,
        Nicholas Kazlauskas <nicholas.kazlauskas@amd.com>,
        Alex Hung <alex.hung@amd.com>, dri-devel@lists.freedesktop.org,
        linux-kernel@vger.kernel.org, amd-gfx@lists.freedesktop.org
References: <20221014153129.68674-1-hamza.mahfooz@amd.com>
From:   Rodrigo Siqueira <Rodrigo.Siqueira@amd.com>
In-Reply-To: <20221014153129.68674-1-hamza.mahfooz@amd.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?eHBMZzRmVHRiaE5SNlE0YUhrdWRrSFNEcUxzbVk5bVdSRHNEbWpOYUd3Y0Ra?=
 =?utf-8?B?cnZKMTZDM2dTSE14VEhLcUV0czNSSndqako5WXY4SEdBZEZPZDQ4azdwcWJO?=
 =?utf-8?B?UjlGUGZWSGRIenY3aUtGcnJtK2tqb1I0NjhQenFFY3RmZUcvV1g2YXBpZmFY?=
 =?utf-8?B?MkZ3STFMQ2xuRHlzdzJCS2dvMU4ybFVrQXVkV090Ris2VWRVYUN1UzRUWU04?=
 =?utf-8?B?VHdqSitjK1BUM0xNUVpDQ2NmZThMK2NZM0E3emxuQ3l3M1laWGFnOEthZy9v?=
 =?utf-8?B?S2ptU0g1aFl6U3NzbDJDb2tjNFdlY1FpSnJJK2NNTWJRa0RmaDd1SzVWZ3NO?=
 =?utf-8?B?aVIrWUN3bHhlV2szd3FYMG53QVMvOG1YVFhrRU95NmMwSkpjbTZZWjcvUlNP?=
 =?utf-8?B?WXcxUTNNeHgwcVh3cWZLSGYxK2UzMmR1MVRLR2pEVnBPU3VsME5NWTR2dEs5?=
 =?utf-8?B?S0RZQ3Z0NGc5ajdHR0Ywd2gzeW45L2xreXJ4Rk9CaWx1TG5maXJyVG5NRDEr?=
 =?utf-8?B?QUROcEtrVWRGdXR0eUhWYU5IclF5NlloMldON0pXWS9KekNvLzBhU0pUa082?=
 =?utf-8?B?SW1VcjRqWnZBMTR0TDZidFM5MGFBTlFrSTRpd1FidVpTdDZxRytFNFpVK25R?=
 =?utf-8?B?ZGVPWEdqM083b1lPZFVFVXV6d2VteVZBamtxVEZqaHFITHc1aHphcnAvaElM?=
 =?utf-8?B?OHVBYnpyM0JzdWpKRFVWbmZQTmU1N3NCc2ZDdU1xQ01aTUEwa1FnYmUzZHR0?=
 =?utf-8?B?eWVsR21nd2c0M1dnd0xXbG9IVExGYWI0SHFyWU1vSEl3Ym5iNEt6TzBPc3BH?=
 =?utf-8?B?VFpoSGRyMWxScHRKQW5LT2J5VXVTU2VuTXh1Wm1laC9ENGtCZkcxMWVoL2FX?=
 =?utf-8?B?QzJOaE8xUGNVRWQyOVJQZlV4NE9VMWtnaS83T2JPeG5IdVpJQ2FOSXpta2dv?=
 =?utf-8?B?a0gxYUFJTGxjODZ3dXh2bndHWW94MnNkYlJVQjZSd3pJZE5NNmxuRTJ1dCtn?=
 =?utf-8?B?N1N4WVZDR3FWR3hpeGExaVNlSC9LNFYvSk4xd0RFSVhUeWFVd0JIN2NSc3Zk?=
 =?utf-8?B?NTZkM3JxSGcyLzMrcVVkeXpFZ1dFWXd2REY4QSt5RnRjUFZoMlltS2V5OVMw?=
 =?utf-8?B?R2phNXFDOTVRcUlPRGFSenU4bXJVNUlCdEs1WTRSYWVxdFB4QVJRaWZha3NG?=
 =?utf-8?B?algvRWU4UTNNME42c2JGVjZtSmR0SHRzOGxob2ZqS2lyTmlBN2R0VldDdngv?=
 =?utf-8?B?SE9maXRFU2N5b2lZaEdNaUdxbWtMYVNLWDdnZGx0NGhYTkRyaEpyT21aY2Z3?=
 =?utf-8?B?QnpIYkpoYmJLNitoTmlqdEN2dG5wNUpHSDhqTVdFdkJkKzQxemVxWE1sNzU4?=
 =?utf-8?B?Wlo2V0pVaUIxcDA4K0U4d2J4MXZwaFFGeXhxaDZ2VXF6K0Z3ejlTL012YkRI?=
 =?utf-8?B?YldmUHErR0VNbjJod1J1VktOYWhobiszMU9ha2hjRjJ0S29KbGY0SEYxRm9R?=
 =?utf-8?B?ajBRZmx5NWk0a3FMN3FzSWs4Q0xsUUJFeXN3YVFwWXR6S1JVV25HQzNXazhE?=
 =?utf-8?B?T0pvOU84bUpHRWt0emxPRnpUN3c2cnkvcXdudE1hcHQ4T2lmVUtCQ3dzYys1?=
 =?utf-8?B?V1NVcGlIUVU1Ny82enZoUG9mZS9yU05tdE9FbjFTa1VCdmMvZHJnLzMxVlhF?=
 =?utf-8?B?Q0psVk5Yd044YnM1YWw5QW1rQVdrVm40T3F1NWVBTUwzWFV1cStqTytsQmRW?=
 =?utf-8?B?VU9nYy9QcHJDVUVDeVVseHFMMVRFZnErNi9OTjdwNEM0Qm5FU05nR1pnSzRi?=
 =?utf-8?B?MVM1UCswckw5OE1LV25ldG1BdGxqU25jSVNtdGZCaXZIeDh4MjF5VFFNcW5T?=
 =?utf-8?B?akpkaGgrUnYzRUYzaExmeFRBOEVxR1V0ancvUE5xN2ZaT01YVlBhZ0JRNzYw?=
 =?utf-8?B?SW9hNktKR3hYNkp5L0NTakxVRFhvQlNjeGIrNjVCdU43WGx2a29nUzFzTkk0?=
 =?utf-8?B?ZUhTRjkyaGdNWkFHUjdqSEJJZnJQUXlIaGxtL0FOMGtibWt0aG5kSVZXT21k?=
 =?utf-8?B?VzlwQnB4d2ZPRUc2MVUweDJ5ajRFUkdtcnVoZEU3S0QyZmFNYUtzVk1TVXBq?=
 =?utf-8?B?ZmxSaFB6bGxuVGRHWEw1TUtva2lTTjZ0Tm9xU25ZZEkxQ1VTcmNEaDE2Q3VI?=
 =?utf-8?B?c1E9PQ==?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: bbcc47e8-f251-4aa0-b97a-08dab0405649
X-MS-Exchange-CrossTenant-AuthSource: MN2PR12MB2941.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Oct 2022 13:06:00.8257
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: T80/RfXVh6C9z0UaooJVDjqxWWQd8kGlf5RPk7lNGYGYpl3/WmQdXuVpjlLHGKla62+uXFyzkl60iLpHVLv+Mw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR12MB5204
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Hamza,

On 10/14/22 11:31, Hamza Mahfooz wrote:
> Currently, if we encounter unimplemented functions, it is difficult to
> tell what caused them just by looking at dmesg and that is compounded by
> the fact that it is often hard to reproduce said issues. So, to have
> access to more detailed debugging information, add a WARN() to
> dal_irq_service_ack() and dal_irq_service_set() that only triggers when
> we encounter an unimplemented function.

Do you know the specific issue that triggered this unimplemented 
function? It might be useful to describe the situation in the commit 
message where you see this problem.

> 
> Signed-off-by: Hamza Mahfooz <hamza.mahfooz@amd.com>
> ---
>   drivers/gpu/drm/amd/display/dc/irq/irq_service.c | 10 ++++++++--
>   1 file changed, 8 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/amd/display/dc/irq/irq_service.c b/drivers/gpu/drm/amd/display/dc/irq/irq_service.c
> index 7bad39bba86b..b895bdd8dc55 100644
> --- a/drivers/gpu/drm/amd/display/dc/irq/irq_service.c
> +++ b/drivers/gpu/drm/amd/display/dc/irq/irq_service.c
> @@ -112,8 +112,11 @@ bool dal_irq_service_set(
>   
>   	dal_irq_service_ack(irq_service, source);
>   
> -	if (info->funcs && info->funcs->set)
> +	if (info->funcs && info->funcs->set) {
> +		WARN(info->funcs->set == dal_irq_service_dummy_set,
> +		     "%s: src: %d, st: %d\n", __func__, source, enable);
>   		return info->funcs->set(irq_service, info, enable);

Do you know if we may hit this condition multiple times?

> +	}
>   
>   	dal_irq_service_set_generic(irq_service, info, enable);
>   
> @@ -146,8 +149,11 @@ bool dal_irq_service_ack(
>   		return false;
>   	}
>   
> -	if (info->funcs && info->funcs->ack)
> +	if (info->funcs && info->funcs->ack) {
> +		WARN(info->funcs->ack == dal_irq_service_dummy_ack,
> +		     "%s: src: %d\n", __func__, source);
>   		return info->funcs->ack(irq_service, info);
> +	}
>   
>   	dal_irq_service_ack_generic(irq_service, info);
>   

Just for curiosity, did you run some IGT tests?

Thanks
Siqueira