Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 17 Oct 2022 16:11:22 +0200
From:   Thierry Reding <thierry.reding@gmail.com>
To:     Ulf Hansson <ulf.hansson@linaro.org>
Cc:     Prathamesh Shete <pshete@nvidia.com>,
        "adrian.hunter@intel.com" <adrian.hunter@intel.com>,
        Jonathan Hunter <jonathanh@nvidia.com>,
        "p.zabel@pengutronix.de" <p.zabel@pengutronix.de>,
        "linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>,
        "linux-tegra@vger.kernel.org" <linux-tegra@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Aniruddha Tvs Rao <anrao@nvidia.com>,
        Suresh Mangipudi <smangipudi@nvidia.com>,
        Krishna Yarlagadda <kyarlagadda@nvidia.com>
Subject: Re: [PATCH v7 2/4] mmc: sdhci-tegra: Add support to program MC
 stream ID
Message-ID: <Y01iiqtNA9xek46S@orome>
References: <Yz6zfrVq9cP/wrJb@orome>
 <20221006130622.22900-1-pshete@nvidia.com>
 <20221006130622.22900-2-pshete@nvidia.com>
 <CAPDyKFr_Yi2EgrBUzsORnM4mOkf25WR8+7_dfF2h4XzRDPm9-w@mail.gmail.com>
 <DM5PR12MB2406610AB26183BACB19EED6B7239@DM5PR12MB2406.namprd12.prod.outlook.com>
 <CAPDyKFqn2jMVQ5BAOZPFx2OOyMRQvsQ1E7mGAQp82x5+v6aSGQ@mail.gmail.com>
 <DM5PR12MB2406405CE44A7606B5A28203B7259@DM5PR12MB2406.namprd12.prod.outlook.com>
 <CAPDyKFq5hNTdwT7CMvsxG=_5u+xvG2k3-PfbGhAbHfHbGqK81w@mail.gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="bW1/UntuZ/Dpz/dP"
Content-Disposition: inline
In-Reply-To: <CAPDyKFq5hNTdwT7CMvsxG=_5u+xvG2k3-PfbGhAbHfHbGqK81w@mail.gmail.com>
User-Agent: Mutt/2.2.7 (2022-08-07)
Precedence: bulk


--bW1/UntuZ/Dpz/dP
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Thu, Oct 13, 2022 at 03:43:18PM +0200, Ulf Hansson wrote:
> On Thu, 13 Oct 2022 at 08:33, Prathamesh Shete <pshete@nvidia.com> wrote:
> >
> > Hi Ulf,
> >
> > >> In that case, perhaps we can add a "depends on IOMMU_API" in the Kco=
nfig
> > >> instead? Or is the tegra driver used on platforms where IOMMU_API co=
uld be
> > >> unset?
> > Yes it can/will work with IOMMU disabled so its not recommended to add =
a "depends on" condition in Kconfig.
>=20
> Alright, in that case it looks to me that there are two other options
> to move forward.
>=20
> 1) Add proper definitions of the struct iommu_fwspec in
> include/linux/iommu.h even when CONFIG_IOMMU_API is unset. In a way it
> seems a bit silly to me, to have the iommu stubs around, unless those
> can be used for cases like this, right!?

I recall that I had proposed a patch for this a long time ago:

	https://lore.kernel.org/all/20191209120005.2254786-3-thierry.reding@gmail.=
com/

Given that Joerg had acked it at the time, I think the only reason why
it never ended up getting merged is because the rest of the series did
not get enough traction. I wonder if I should peel it out of the series
and propose it separately.

I agree it doesn't make any sense to have the stubs to allow compilation
and then break compilation because users of the stubs will end up
wanting to dereference the structure.

Thierry

--bW1/UntuZ/Dpz/dP
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCAAdFiEEiOrDCAFJzPfAjcif3SOs138+s6EFAmNNYocACgkQ3SOs138+
s6Ealw/+N+g3kvb61CMuasUT4REnY/0pdkX6PG+sIPl74h/vEy4RQONsMSIF60At
vT5lx44ULGJq6Hi76D4A2OaZqGwezVI8lhdMPPzajE6LgH+VgnqaXbZzcSu1C0n9
jGRyRvg0xcikfl8leufXlIPY4vew2i6OHaGX9kOOrpfuHyQPEf0qYGPRPtdOPHg6
nxkUuOSxT2wSVxByOystb2Idao31IaN+dHk9Yds/OfLi5a3eXicJTfcV2Ashpktx
91k7ZbPIXrYpB0TxhkqlsQGTC2tqaoR2vXAYB2MfGlz7FTuFXeyV7Xk8zaHvgMRg
jfqqsqwXyzltIk5MY4ErJk8c1XZLRO6q3iepi4xSU0wb59Sjmcb7klZP5scPJC6H
fHha2s6BZoLzw584a7O5RvjDK5GOGcMYDxmEGz5mb+ZKLsHdG24sdV2F46/qJU5c
iRNZhlYV7PNCJmSxMFoOozA63v7YKR4RYQfBJSKHGSinTK+QJ2Cqm3EsRbCrBQgt
u4AigcYY+T+pMd+L9HfYb0nxPYjViqa0FEtvv8fDua89MVVtGlQ+trHec4licmNF
NNj87vkJpFe8uJYIWbsNAI6s1d6G/tGdcW85v11KFsBbJX/+HJawDSJXVj1ZF4m8
fRRI7PcXMrKBlKhCAPfYz5057boPT+Gh64gTH1Lv2HQz7TCYvTE=
=FnaY
-----END PGP SIGNATURE-----

--bW1/UntuZ/Dpz/dP--