Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1763631AbXF1RIX (ORCPT ); Thu, 28 Jun 2007 13:08:23 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1756169AbXF1RIO (ORCPT ); Thu, 28 Jun 2007 13:08:14 -0400 Received: from mail.screens.ru ([213.234.233.54]:50162 "EHLO mail.screens.ru" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754088AbXF1RIN (ORCPT ); Thu, 28 Jun 2007 13:08:13 -0400 Date: Thu, 28 Jun 2007 21:08:25 +0400 From: Oleg Nesterov To: Satyam Sharma Cc: Jeff Layton , Herbert Xu , linux-kernel@vger.kernel.org, "Eric W. Biederman" Subject: Re: [PATCH] RFC: have tcp_recvmsg() check kthread_should_stop() and treat it as if it were signalled Message-ID: <20070628170825.GA549@tv-sign.ru> References: <20070608123527.9b4cdafe.jlayton@redhat.com> <20070609070826.7bd3480c.jlayton@redhat.com> <20070626115449.GA92@tv-sign.ru> <20070627122437.GA158@tv-sign.ru> <20070628141246.GA95@tv-sign.ru> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.11 Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1124 Lines: 32 On 06/28, Satyam Sharma wrote: > > Second, we *must* break that tcp_recvmsg() inside the kthread's > main loop, of course! We want it stopped, after all, and if we don't > make it "break" out of that function, the kthread _will_never_exit_. In that case this kthread is buggy. We have sock->sk_rcvtimeo. > Please note that this > whole thing is about functions that will _simply_*never*_exit_ever_ > _unless_ given a signal. ditto. kthread should not do this. OK, I suggest to stop this thread. I don't claim you are wrong, just we think differently ;) > >This is what I can't understand completely. Why should we check SIGKILL > >or signal_pending() in addition to kthread_stop_info.k, what is the point? > > ... so kthread_stop_info will go away too. it should go away regardless, we have patches. Still I see no point to check signal_pending() in kthread_stop(). Oleg. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/