Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <364c0959-c82f-a93c-df02-87a04e1c2cea@oracle.com>
Date:   Mon, 17 Oct 2022 20:33:28 +0530
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.3.2
Content-Language: en-US
To:     macroalpha82@gmail.com, hjc@rock-chips.com, heiko@sntech.de
Cc:     airlied@gmail.com, Dan Carpenter <dan.carpenter@oracle.com>,
        daniel@ffwll.ch, dri-devel@lists.freedesktop.org,
        LKML <linux-kernel@vger.kernel.org>,
        kernel-janitors@vger.kernel.org,
        linux-rockchip@lists.infradead.org,
        Harshit Mogalapalli <harshit.m.mogalapalli@oracle.com>,
        harshit.m.mogalapalli@gmail.com
From:   Harshit Mogalapalli <harshit.m.mogalapalli@oracle.com>
Subject: [bug-report] Smatch warns unsigned comparison with zero in
 dw_mipi_dsi_rockchip_set_lcdsel()
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dTYyUEVYMXN6MDF3Zk94MGtxcWZDeVZmUThBckdBWjMzNnRjR3BJSzF1dUM0?=
 =?utf-8?B?QnVCRncvMk5oY1RFcXNUVGtXVkt0UmMzVmhnZ2tqMVVhSEZBYmwvVytTYnVK?=
 =?utf-8?B?WEtPNlNzY1pSWDUvZFlmL1lXbzIzZVBFZ2dVOHhzVDdTVytucXpmQUFwM3V3?=
 =?utf-8?B?dDRyNWRFTC9ySlczbjY3ZzRKMTZXaGx2aURvU25yOThyeXVnbWJOU3c2aUVX?=
 =?utf-8?B?TStoQSsvQ1VYY01vSHJmQXU0ZGRHcUVGTUk0eDFLMURMUVBTd3c3R2lYMFkx?=
 =?utf-8?B?VVRxejhvd2FLdzJpTWd4eVkzOXh3RmNmcVYvd2o5WVppL2NXcUJSdGZmRGFj?=
 =?utf-8?B?aU1GK1haNVp2YlE1dzlRd1doWWNkdHBpb0EwUnhVRVBRSitjMmd2bENuQnhL?=
 =?utf-8?B?cEoyVldmbzBWTERoM21obmQ0SWxQWkhKZ2Z3dU9UZEx4N1c0Y2lFL3JmUHJU?=
 =?utf-8?B?OVJwNXBpa2NrRmprUkptS2RyT2t0elN5Qk83RkZLSTUrbkdGdlpaVWxXYkti?=
 =?utf-8?B?MGNEdkVLM25zTGdQZDlmbzFuaUwxSnVvc1BGd3VSY3FOeDQwc2FHYVRyODJQ?=
 =?utf-8?B?VDBHS3E4V3hjNzZGUERSaWtnT0ZzTE9zblB3K0dHVTRvNzhta2IwallOR2hQ?=
 =?utf-8?B?Tk5HVityZm1UUDA2aWhXODExVExSVHdWRDVhd1RaTVZPMlhJV0JFMnQxKzl6?=
 =?utf-8?B?QkNCSnp3R3RGaGVLczdTUUdLTUJJTUN0NzlFYXhKSUx5Sk9XUDZkN1R0WUdU?=
 =?utf-8?B?eWFBSmtiZUsvR1RCSlBZaTFYOVFuamh6ejk0em9ZeEZvbzNuSEp2YnlYOW1V?=
 =?utf-8?B?V3NXRC9lYjNrZ3c2NDB3S2hKSWFWZjFCTkZQVVVNZ0k4YS94aWpvTkJlc3J1?=
 =?utf-8?B?ZzRTQWM3VnNXZHloV1Zrek9ROEdjT1RQamRRLy9tZDZZMUViWnNXWFRQTXd2?=
 =?utf-8?B?QnExMit5aXFUV0Z4OVZEVDBvSmlpN0QwSU0vZHVFQmRTYnVodEE3Um9yZElR?=
 =?utf-8?B?c2FVMC9XZjhjSWN5ZUFUaWpsN1lzbjIvbllyUVlpdkRkL1JublBRWDNQaE81?=
 =?utf-8?B?dUlEeXdJdnhBL0hRYVlKcmVOUzdtL1hzRXh2cThsakpkWDVqeFpjRlhod0Y4?=
 =?utf-8?B?YThFalZKeWtIL3RGTWxtSkRRbERvVHc3U0JwYVJmd20wVDFUOWxvc0hLU2J0?=
 =?utf-8?B?bGN6dzN6U3EwWGRCeVVKYTQ4TDgvRXZxcXl3dlQ3cjFvOE1GZnVtRGlzVDNp?=
 =?utf-8?B?UUUxM0lKb3dIdTVkNnl5WUN1dnE2cDJyK3ZqUDl6Y1hFdXBhUEZUZURVWW1o?=
 =?utf-8?B?bjg2TEFCTjBvOUc0WW9wQjRSeUZkSkdqeVpBUDIyL014VW5QUVBMRzhxREpR?=
 =?utf-8?B?WCtuZ2ZlYklKY0JId05zUmVNT2pMOU5VZUNLV3B6TnJGeFBMYTRrM0hqWThm?=
 =?utf-8?B?Y3I5elVhVEpaVzBjZS9YWTFENlUydk5BRjA0SFR5S3BBbXRpNHFjRE9DNlRq?=
 =?utf-8?B?ZVVhbkw0MWorUEU3QUtnTHoxZ21jOXpQdktzeHYyR0h6R1lBeGhBd3dkUlc0?=
 =?utf-8?B?YnZ3d0ZjdGdLeGFyK1RHMUN3Ti80NWJPN1dGQy9GTTgxMW5hS3loMWEySTFs?=
 =?utf-8?B?Z0o0YkJsVjBRUTl6WkNDWmFZM2RsbzBlbGRJTUdsWGRtY0tLeEgyVFZialpo?=
 =?utf-8?B?ZEN5ZTdsOGRrNUd4K3A5WmVCNXZYelo2bm53NE9DNXM3UTdITlNITU9rTzll?=
 =?utf-8?B?N25xNkxlNVdqek9DYnBjaVN4RHRIWnZwSjNJYkdPQVhyY01TaDJsN2hEdkli?=
 =?utf-8?B?dXJXODZydmE5b2YxNzhzMnhCMnl3a0s2R3ZxMlhtU3MzVFJ3cXQrMW5xZUhM?=
 =?utf-8?B?WW9FL1RlU1dMRzM1Skl1d29rMU5keWQ3Wm1sUG03ZGh5ekF1UWQ0NEQ1R29k?=
 =?utf-8?B?TC9VZWNPQjUxTHNPd1FRZ3BOZ2FmNEY3ZnVML202RzhOdGwzSlV1OWtSdEFK?=
 =?utf-8?B?SlhVVzJjOUhlL0Z6N25jeUtGUUhlc3FJWlp2bUVCUHJXa2RSeGNKRlBKeklG?=
 =?utf-8?B?cEJiUFhPaGp0Y2x3MjRkaUdRd01PV3RleHhqQ3pld3ByaXpqaTBNS0J0c0RO?=
 =?utf-8?B?QnhveVlrUWlxNE5DUW0vZ1lHcC9QcUhyenN1VURZWmc5V21ITmwwMnllSXUy?=
 =?utf-8?Q?DoQuvaJvBj29Yk+nhnGoU1o=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 0e8f9b2d-6559-46a4-ecad-08dab050ca57
X-MS-Exchange-CrossTenant-AuthSource: PH8PR10MB6290.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Oct 2022 15:03:46.8259
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: eOrB5CWL6E8tUEFcBs5A+QBrMEo7oEWUu8hBR4eOS4ELVUgOJw/4bYS8rwunnOsTS5oA+xkmXFypqQGzWto0lFq7ag92sKTk5ScNrqCVj1VYIcrcGIlwXKuBI6JQrBxN
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLAPR10MB4836
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.895,Hydra:6.0.545,FMLib:17.11.122.1
 definitions=2022-10-17_12,2022-10-17_02,2022-06-22_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=952 phishscore=0
 suspectscore=0 spamscore=0 adultscore=0 mlxscore=0 malwarescore=0
 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2209130000 definitions=main-2210170087
X-Proofpoint-ORIG-GUID: jOagjt46aW9lWEgsFU_k91uIGnGJVYAK
X-Proofpoint-GUID: jOagjt46aW9lWEgsFU_k91uIGnGJVYAK
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi,


Smatch warns:
drivers/gpu/drm/rockchip/dw-mipi-dsi-rockchip.c:755 
dw_mipi_dsi_rockchip_set_lcdsel() warn: unsigned 
'dsi->cdata->lcdsel_grf_reg'
is never less than zero.

static void dw_mipi_dsi_rockchip_set_lcdsel(struct dw_mipi_dsi_rockchip 
*dsi,
                                             int mux)
{
         if (dsi->cdata->lcdsel_grf_reg < 0)
                 regmap_write(dsi->grf_regmap, dsi->cdata->lcdsel_grf_reg,
                         mux ? dsi->cdata->lcdsel_lit : 
dsi->cdata->lcdsel_big);
}

'dsi->cdata->lcdsel_grf_reg' is of u32 type, it can never be less than zero.
So the above if condition is an impossible one.

Note: 'lcdsel_grf_reg' is set to -1 at other places.


Thanks,
Harshit