Received: by 2002:a05:6358:1087:b0:cb:c9d3:cd90 with SMTP id j7csp4685883rwi; Mon, 17 Oct 2022 09:19:05 -0700 (PDT) X-Google-Smtp-Source: AMsMyM7rs0VqSLG1eRslMvDLK5G7Aii0z3HklYZRso64or9FzTcgya/NOqD/HQzVBQeQ1lCiOSK3 X-Received: by 2002:a63:8643:0:b0:46b:2bef:338b with SMTP id x64-20020a638643000000b0046b2bef338bmr11404484pgd.357.1666023545098; Mon, 17 Oct 2022 09:19:05 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1666023545; cv=none; d=google.com; s=arc-20160816; b=XLpicmpU5NpKYgQHfHEt/MonG2h+Z6cmPWpv7avlC8rywcqGD7nkk2obvB0DZd4qi9 SS4pwnN/CY58pz4OU5eQcUwWYprPhnsrIJ788vUNg5u+MjpP2br8XghYMtKP7LSfYf5j w1D6xgf2cf5v1HOkE9Hkw7IZYoXIktWoMWuaP/YB8UurPGw7V7Cnx2zHXnC+CRvWbGsr O3bDhHckR8QqHjzp72m2W0OC/jX7hYwtYu8W8WybFHu9tV1J5CRCgttmUW3ETENY4OWU rn2XteTgFtHTo/LKUW1mVRlFzfJpeL7gsjU32bbz9bpXnCgRk1vwVQn47qnOuHAfvdAZ DNaw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:date:message-id:cc:to:subject:from :dkim-signature:dkim-signature; bh=jTwL/T4HkHL8iKoj6Vj+ljbJU9UBePNtP7Jc/xS7RZk=; b=Uz9cNd8UlR/u109ZP8qN04I1BrtNIkoHNKoR1lKG/wGSLhNxfwzc646T9HI6dLDmJI WkC2rRjOHXbGIOyM7y/c9mHWyMV/DGWJ5VIqNTzbuj3UbD9HyqrVp820Bp9W7Y0o54rP EZoYn7uBM7+6LtSsjFC/92VhoMGtqnC8VyW45Yv7hOoSF/Sb4wRrlM7kKk3TFk8WMaBt ngi1nQWUuL1CPBQP41Yo0hvmhyRaj9jOw/wXRk801xzLvhojRoaxPDCBKqQSiCtb2eXa pJoZ1HsGCqEVYva0knithIIHYyG+BUWubaNUp4Ag7yc9Lasc78ZyiipUELzxVIcSdnH4 Qt9g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@suse.cz header.s=susede2_rsa header.b=K9GSOMhk; dkim=neutral (no key) header.i=@suse.cz header.s=susede2_ed25519 header.b=5CbRW0u8; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id q22-20020aa79616000000b0052f0fa0c853si11519162pfg.241.2022.10.17.09.18.53; Mon, 17 Oct 2022 09:19:05 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@suse.cz header.s=susede2_rsa header.b=K9GSOMhk; dkim=neutral (no key) header.i=@suse.cz header.s=susede2_ed25519 header.b=5CbRW0u8; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231704AbiJQPBA (ORCPT + 99 others); Mon, 17 Oct 2022 11:01:00 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53260 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231654AbiJQO77 (ORCPT ); Mon, 17 Oct 2022 10:59:59 -0400 Received: from smtp-out1.suse.de (smtp-out1.suse.de [IPv6:2001:67c:2178:6::1c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A6D46696D0; Mon, 17 Oct 2022 07:57:02 -0700 (PDT) Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out1.suse.de (Postfix) with ESMTP id C0A8134031; Mon, 17 Oct 2022 14:55:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1666018517; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc; bh=jTwL/T4HkHL8iKoj6Vj+ljbJU9UBePNtP7Jc/xS7RZk=; b=K9GSOMhkY/1TlU8TUHxxVvr0wT6acqz9NJz4Q4N0N1Seu6yt5/Gt5t5zh6BVuDwuU5apsS by/EayaSyJU4PD09AeLBtn1IZxN6tl+7NdHAb/+b/qop2ISOPz5eoWzoQn/gjseQZBVm9k bVUv094GfB2Bibd5uG2aFNTuIqKHbT8= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1666018517; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc; bh=jTwL/T4HkHL8iKoj6Vj+ljbJU9UBePNtP7Jc/xS7RZk=; b=5CbRW0u8AVRIVmzJshsqZpLnRR0qLNjEAW5RFH5B80H7Zm+bgvgE3ZBAcMFRWmBl1FJhj6 Z7CUGwtmuK+ACvDA== Received: from lion.mk-sys.cz (unknown [10.163.29.118]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by relay2.suse.de (Postfix) with ESMTPS id B370A2C141; Mon, 17 Oct 2022 14:55:17 +0000 (UTC) Received: by lion.mk-sys.cz (Postfix, from userid 1000) id 93BCB6043B; Mon, 17 Oct 2022 16:55:17 +0200 (CEST) From: Michal Kubecek Subject: [PATCH v2] scsi: mpi3mr: select CONFIG_SCSI_SAS_ATTRS To: mpi3mr-linuxdrv.pdl@broadcom.com, Sathya Prakash Veerichetty , Kashyap Desai , Sumit Saxena , Sreekanth Reddy Cc: linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, James Bottomley Message-Id: <20221017145517.93BCB6043B@lion.mk-sys.cz> Date: Mon, 17 Oct 2022 16:55:17 +0200 (CEST) X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,SPF_HELO_NONE, SPF_SOFTFAIL autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Starting with commit 42fc9fee116f ("scsi: mpi3mr: Add helper functions to manage device's port"), kernel configured with CONFIG_SCSI_MPI3MR=m and CONFIG_SCSI_SAS_ATTRS=n fails to build because modpost cannot find symbols used in mpi3mr_transport.c: ERROR: modpost: "sas_port_alloc_num" [drivers/scsi/mpi3mr/mpi3mr.ko] undefined! ERROR: modpost: "sas_remove_host" [drivers/scsi/mpi3mr/mpi3mr.ko] undefined! ERROR: modpost: "sas_phy_alloc" [drivers/scsi/mpi3mr/mpi3mr.ko] undefined! ERROR: modpost: "sas_phy_free" [drivers/scsi/mpi3mr/mpi3mr.ko] undefined! ... Select CONFIG_SCSI_SAS_ATTRS when CONFIG_SCSI_MPI3MR is enabled to prevent inconsistent configs. Fixes: 42fc9fee116f ("scsi: mpi3mr: Add helper functions to manage device's port") Signed-off-by: Michal Kubecek v2: use select instead of depend --- drivers/scsi/mpi3mr/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/scsi/mpi3mr/Kconfig b/drivers/scsi/mpi3mr/Kconfig index 8997531940c2..f48740cd5b95 100644 --- a/drivers/scsi/mpi3mr/Kconfig +++ b/drivers/scsi/mpi3mr/Kconfig @@ -4,5 +4,6 @@ config SCSI_MPI3MR tristate "Broadcom MPI3 Storage Controller Device Driver" depends on PCI && SCSI select BLK_DEV_BSGLIB + select SCSI_SAS_ATTRS help MPI3 based Storage & RAID Controllers Driver. -- 2.38.0