Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Subject: Re: [PATCH net-next v5 05/14] net: fman: Map the base address once
To:     Geert Uytterhoeven <geert@linux-m68k.org>
Cc:     "David S . Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>, netdev@vger.kernel.org,
        Camelia Groza <camelia.groza@nxp.com>,
        Madalin Bucur <madalin.bucur@nxp.com>,
        open list <linux-kernel@vger.kernel.org>,
        linux-arm-kernel@lists.infradead.org, linuxppc-dev@lists.ozlabs.org
References: <20220902215737.981341-1-sean.anderson@seco.com>
 <20220902215737.981341-6-sean.anderson@seco.com>
 <CAMuHMdWqTtjuOvDo9qxgDVpm+RBGm7BEgpdqVRH1n_dLGoYLTA@mail.gmail.com>
From:   Sean Anderson <sean.anderson@seco.com>
Message-ID: <086a6f02-4495-510e-9fc5-64f95e7d55f6@seco.com>
Date:   Mon, 17 Oct 2022 11:34:47 -0400
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
In-Reply-To: <CAMuHMdWqTtjuOvDo9qxgDVpm+RBGm7BEgpdqVRH1n_dLGoYLTA@mail.gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UlRhUnY1MDlPSkpyTUlEaW1mTjM5ZWkxMm9JTzhqTGJVNllPVFdRZGVKVTh1?=
 =?utf-8?B?b0h1Tk1Vd29lVVRQRWozeHpPYlJBYW5KWkxPREJrUURjc0FDdDNWZXBlaU1R?=
 =?utf-8?B?UTlpQ2hETmlpcFNodDNncjM0Wm5mTEd5Z0VOZnh5SWxDQ2RXeW9IUnJzREZ5?=
 =?utf-8?B?cEhXbEJNTTgrTnFEbE15YWl5RzNkMnh5NVA1OFVMUkVkYXlwN0MyZjZRVTZM?=
 =?utf-8?B?RDRUNldiMmhENWx0Zkl2dHVpTVM4N01VWXFIMmlZMFVnRStmU0FmekdmTVcz?=
 =?utf-8?B?RGxhMDZXZDNGQzNaTEE3b0NOWWh3K1FidUpHRVBUMTRXN1VUcjZpL2FFaUZj?=
 =?utf-8?B?MHBtQzhBVkRRZ09DdUdpMFpQSVhHMFlkRUJIbkNyM0ZtTG9zOHJsWW84TE03?=
 =?utf-8?B?UEtLbXgxWVFnOThtb25sVUFiMWdSYzgrVCtVVEwyNXNLai93TnQ4TzAraFVh?=
 =?utf-8?B?a005cHlKUjZNWDg1ekY0ZGhSZFV6NnM2TTVaVks0cnVBby81c3hBTGdDZVIr?=
 =?utf-8?B?NEMxZXpYYTI3Q1diWFIzNjNVM2cvaXhyNVJCanI4YXowM0hLT0J4RTlYa0o0?=
 =?utf-8?B?MkZmL005bTVMcnhIUlJMTHFMM0JUVm5DRHV1Szc1eVE5K1pkdTRidHp4TWxu?=
 =?utf-8?B?eXlMQmxVaTBzN2Q4RDlqdzhsYnpxaHIxalBLdnZjUnB2V0FzTXFCeTBlV3Bm?=
 =?utf-8?B?YVFhV3FHbVNIUmZYZkoxbzUxN0VEbHVGRWNXa1RiR1BtdWVTV1JmbzBNT0pS?=
 =?utf-8?B?VW50TldiMURNU0haTHN6ODJzRGV3T3pmdFJYeXpHeDU5aUJmeEE0QytwamVL?=
 =?utf-8?B?N3E1NWQ0MXVDNTByTmNQeCthUC9QMnhTeGl0S1RGN296czFjVE02R0t4TXBP?=
 =?utf-8?B?VTNWKzZHa05Hd3MrN1dkZkd1a0dRTzVJYUpYRWpjaGJFeXB3WnFPaW13dHBu?=
 =?utf-8?B?WGh4QkJRYkl6YTFwOGN0K0JrOWFiMEs0dWVacDJoaG5nUVoxOWkxOWc3MzIw?=
 =?utf-8?B?bGpNL0RhNXM2dmVWYnJBMHRUNHBGTFg4emJzSWp2YTFOZHBBRTBKYldnTjdx?=
 =?utf-8?B?OFY2SHM2YzgxR29LaXdVbTR6UEdhOVcreUhybkV0VWgwalU1Sm1yVklvVVVs?=
 =?utf-8?B?MVlPNFV0RXl5b2JjcWprVisxYkVRRTl6cDRkckFJdjl2LzhBN0dZOVJMWkVk?=
 =?utf-8?B?cWRDOXY2dmZCS09aUWZEQ0lITVJlOE91a2xKOGsrZnZIUThxeG9VbWd6MHFy?=
 =?utf-8?B?VmRnaXJDRHRZTFVPOTIwRlRUREI3ZitxaitUb0xYR0t0NDliK0hCYW16YnND?=
 =?utf-8?B?enFRT0lTY2JGbDJkTEdJc2RsUE9xTEIrbS9uVjB2N3k5Q2VEL0E5N2VFNjdI?=
 =?utf-8?B?R0o3OFJ6K2F2TmVueFgwK2Ryd2FocTdYWXhhL2k0YnVsNjZiUDF1d3o1KzNx?=
 =?utf-8?B?dHV0MlB5WXJrYU1CbW9IOXBRVCtJMU9rdWVubFBXMDRsRkgwbk9OeHdTdkk3?=
 =?utf-8?B?RVVMSTFwTHFFOGh0dGNIa2ordWgvMmgwUDlESnNCOFdHTHgvT083NVZnZ3g3?=
 =?utf-8?B?VTJndmhyNmUrZ2pUb1JXclJjbnJmNndOcTJuMUw1a0RwcUFObmdBRFNHQTlh?=
 =?utf-8?B?clBKUTd0ZXNGWUZIRzkyZE5vQmY4MVpoWXBJbDlYTmJyakdIUjZpbWxub3k3?=
 =?utf-8?B?dXhkN2s0MlFYbFVFbTdUU21aL29uSVoydVpIVXVua0FOamlNNXJLaVBORzh2?=
 =?utf-8?B?Um43NXhIbTllOEpxV2FZMmI4bWl2V2VDbThFaFlGRGlYZVdyNjBTYnNEcHZB?=
 =?utf-8?B?VTk4ZkxKRE4yY0ZHQ2FiNlZVUDU4WW5SWTZWd0ZGYXNzZm1NdUJtYzE2c3dJ?=
 =?utf-8?B?VUdiM2pLUDdLemJTWTErMnJWWlBmK01vdUU0bDlBbEhkdldPYzlFOW5NN0do?=
 =?utf-8?B?SVhBVkt5ZnZEVFpnckFScHRxZ3FPck9nc2hoT3JFemw5cysrQU1SeUdNcGV4?=
 =?utf-8?B?akVqRmQ2bk1KRk0zTi9xL0xGc0dIZkVPOGdDL1FkNlRGcHFWNjJKeVVOSG9h?=
 =?utf-8?B?OUJnbGhwQUFnQ21yRE80TVE0Rkg5eG14QXRNK2tpVi9QZDJRSUJOK1ZpbndO?=
 =?utf-8?B?OU12aFVCa2lsZjdXZ0xiNlFrR09PbDBOMkJid2JEWEpnT2hxVnJkNjZ3UXVt?=
 =?utf-8?B?dFE9PQ==?=
X-OriginatorOrg: seco.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 1cfb7a7a-d584-4d51-3eaa-08dab0552457
X-MS-Exchange-CrossTenant-AuthSource: DB7PR03MB4972.eurprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Oct 2022 15:34:55.8033
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: bebe97c3-6438-442e-ade3-ff17aa50e733
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: YuAarAyGJBiA/jVd9UarW9m6/GMrAV6/GMVotVQaF7xBwYUFkqpRsXMpvDz6lWthc5H3rZ9aPvFTdf9KPRdxPg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR03MB7999
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 10/17/22 11:15 AM, Geert Uytterhoeven wrote:
> Hi Sean,
> 
> On Sat, Sep 3, 2022 at 12:00 AM Sean Anderson <sean.anderson@seco.com> wrote:
>> We don't need to remap the base address from the resource twice (once in
>> mac_probe() and again in set_fman_mac_params()). We still need the
>> resource to get the end address, but we can use a single function call
>> to get both at once.
>>
>> While we're at it, use platform_get_mem_or_io and devm_request_resource
>> to map the resource. I think this is the more "correct" way to do things
>> here, since we use the pdev resource, instead of creating a new one.
>> It's still a bit tricky, since we need to ensure that the resource is a
>> child of the fman region when it gets requested.
>>
>> Signed-off-by: Sean Anderson <sean.anderson@seco.com>
>> Acked-by: Camelia Groza <camelia.groza@nxp.com>
> 
> Thanks for your patch, which is now commit 262f2b782e255b79
> ("net: fman: Map the base address once") in v6.1-rc1.
> 
>> --- a/drivers/net/ethernet/freescale/dpaa/dpaa_eth_sysfs.c
>> +++ b/drivers/net/ethernet/freescale/dpaa/dpaa_eth_sysfs.c
>> @@ -18,7 +18,7 @@ static ssize_t dpaa_eth_show_addr(struct device *dev,
>>
>>         if (mac_dev)
>>                 return sprintf(buf, "%llx",
>> -                               (unsigned long long)mac_dev->res->start);
>> +                               (unsigned long long)mac_dev->vaddr);
> 
> On 32-bit:
> 
>     warning: cast from pointer to integer of different size
> [-Wpointer-to-int-cast]
> 
> Obviously you should cast to "uintptr_t" or "unsigned long" instead,
> and change the "%llx" to "%p" or "%lx"...

Isn't there a %px for this purpose?

> However, taking a closer look:
>   1. The old code exposed a physical address to user space, the new
>      code exposes the mapped virtual address.
>      Is that change intentional?

No, this is not intentional. So to make this backwards-compatible, I
suppose I need a virt_to_phys?

>   2. Virtual addresses are useless in user space.
>      Moreover, addresses printed by "%p" are obfuscated, as this is
>      considered a security issue. Likewise for working around this by
>      casting to an integer.

Yes, you're right that this probably shouldn't be exposed to userspace.

> What's the real purpose of dpaa_eth_show_addr()?

I have no idea. This is a question for Madalin.

> Perhaps it should be removed?

That would be reasonable IMO.

--Sean

>>         else
>>                 return sprintf(buf, "none");
>>  }
> 
> Gr{oetje,eeting}s,
> 
>                         Geert
> 
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
> 
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
>                                 -- Linus Torvalds
>