Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Song Liu <songliubraving@meta.com>
To:     Christoph Hellwig <hch@lst.de>
CC:     Song Liu <song@kernel.org>, Linux-MM <linux-mm@kvack.org>,
        lkml <linux-kernel@vger.kernel.org>,
        Andrew Morton <akpm@linux-foundation.org>,
        X86 ML <x86@kernel.org>, Peter Zijlstra <peterz@infradead.org>,
        Kernel Team <Kernel-team@fb.com>,
        "Edgecombe, Rick P" <rick.p.edgecombe@intel.com>,
        "Hansen, Dave" <dave.hansen@intel.com>,
        "urezki@gmail.com" <urezki@gmail.com>
Subject: Re: [RFC v2 0/4] vmalloc_exec for modules and BPF programs
Thread-Topic: [RFC v2 0/4] vmalloc_exec for modules and BPF programs
Thread-Index: AQHY2qb9UHFHCXXpukKxiSq7OlxGX64SPiOAgACWPoA=
Date:   Mon, 17 Oct 2022 16:23:52 +0000
Message-ID: <E8A7DEAE-C1C6-4821-A3A3-FD4996414AFD@fb.com>
References: <20221007234315.2877365-1-song@kernel.org>
 <20221017072607.GA30977@lst.de>
In-Reply-To: <20221017072607.GA30977@lst.de>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?XZfmO3YBqZ2+2fFUo1zU59a3J4Ni0iW+y4qOlcTlT2WanJl9AEoaCWx4ZVql?=
 =?us-ascii?Q?16hTZ84JbPAVgBmNx+rWy4t4mS/Oz9EK+lrT02eFwfcTmnGtT8C1wndXWU29?=
 =?us-ascii?Q?PH701mGoMky4eFjn+7N1YdXtoRbnmMFtutq8hDG9E74sbaqrzHWMEBHCFLbs?=
 =?us-ascii?Q?/ii2P7kf7+UIruFLZs5JhgSaHOarkTqZQfOWOE1irqLfbDBVxTtsKECsMrft?=
 =?us-ascii?Q?1REBQAe2YoxfLD1shhHlTgvcrCv21cjZWGQ/LkRg3kbWSlzKVy4Heiwi7mve?=
 =?us-ascii?Q?nAvT8pb6tGgcLR2C0ZVot0OyL2rKq1QftxjSq7ciT0NntWGMuW1pkfH9aSX3?=
 =?us-ascii?Q?xpdlD4AbVx/voUUILdvQS8DN0spj5+9X+cBqe0w2B+zYXaFkdO8zzY3FxDXV?=
 =?us-ascii?Q?it6Z45frvycRd/34ffMh+2zqZeJSswSFIXw353AdT+Rwa8zzYcl/j4E4bAdN?=
 =?us-ascii?Q?utEdXWgVtZA4gY2yMhj3iKYbxTQbxgoYby6Kh8EOUaHGSB7hu5/oRbU4ronL?=
 =?us-ascii?Q?OrTfA815UT9jlhyV131PtnldQNVnQTSyRZvA1mfCHiqD1pQSXJZpoKXJkRLc?=
 =?us-ascii?Q?P3h7GjjrPSERHUPYEf3LjiMJTV7DmM0UujEhlr6Gh6R6yaPBhSgfBBzsqnFu?=
 =?us-ascii?Q?CzAuZZkXadKcg+9yCqpUhvSt+SbAby24TweU/6/skmzspmnenETMr/+aL1t4?=
 =?us-ascii?Q?5dLBaTTsehRapoE90qD5o+UDfJVaJgsxZNtDpbu7DHXdv/8H4JAGvwhxMMSB?=
 =?us-ascii?Q?iU1Spl92Df6o1+ITPlAgXrMfrC6hQ7r8reE3Ainem06GeRqLlTmJ7dFLEgpc?=
 =?us-ascii?Q?EiuTJiqqRGaRuNHU61p82SopmufFO7xO8fIIOknwhekAQZcVGLXGkXX4HFzx?=
 =?us-ascii?Q?imfLg5oMBRaK4HD84kG+vekBahrTq7kz4ppktg6SZ08uXNAt1itSxtKKHvMm?=
 =?us-ascii?Q?p6eGMHCcbl2YX0yCKU44JM4doPlr80zl9Dt9ehzfaA+gcZiKSjG++3YyYtAM?=
 =?us-ascii?Q?A6nTdvUgAbXPVH5IyjfmsM49j+R9m3vq7q7IgNBIS4yVZUuWXqLGXKc5dtGj?=
 =?us-ascii?Q?9UVf/VNC7i9ONTHWt8Io/UhnkUFBmVfiZm0EwpNT/XbpZSEJWnzuBUowhxuU?=
 =?us-ascii?Q?V2bn5gpAf+tV9jCZoIjkNuhlFoOw89GO27z7HQ6P5C+UBr9xVWMSnSrNNbUO?=
 =?us-ascii?Q?B0h6nxUSHez956m4SjfhTi7TIg8l/FzfPLePWc+DEpfW+l+WWjkCJpnV2w6q?=
 =?us-ascii?Q?H0qWH+nBJnuYYt+ExAajrHQOp7FBIdPWoP6zXKYZa2Jg1eiy+Hf3g15bTEN3?=
 =?us-ascii?Q?WIOwdHYrPz8o1/MXL8zQBo41Y6HvbjM9NqMk0NS3KYjBbWode4gSsZhP1vbj?=
 =?us-ascii?Q?K3nfxe4LL7IruNgLU2zxPN4qI+1/vyZ+TX1EMC4WoNSQon5v+2cCb5jthn1f?=
 =?us-ascii?Q?h6iyWq/1Nh7+M11psxzVMQ5+Z7CdI3Z68CZOfVb+H24envHMrPnBrJMJwH+u?=
 =?us-ascii?Q?mJ2OYBamr8p6z/GD4JCS3FSiyr0PHDG9j3W2PBAdWcUcmnboiQpmKeeIMIKn?=
 =?us-ascii?Q?WMlHdYvAEqvt2lr6WK3ToPZlxRqLWIK2FHoktFq15EouDAgudJHEDAm1pHKR?=
 =?us-ascii?Q?IH2C+S3J5w7jQW3Vi0v5Rloda02O7s31zhww6XKw78Nz?=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <7EA86F4E8C70DF4ABC9F1BE1BA590A7B@namprd15.prod.outlook.com>
MIME-Version: 1.0
X-OriginatorOrg: meta.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: SA1PR15MB5109.namprd15.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 0edb50a9-30d9-42cd-b077-08dab05bfaf1
X-MS-Exchange-CrossTenant-originalarrivaltime: 17 Oct 2022 16:23:52.4846
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 8ae927fe-1255-47a7-a2af-5f3a069daaa2
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 9O1eDnoXXKGXu+SasGluIPDQqOKaHBR7F0kzJ3txcf8Wb0rNZR6CNSRQWR+ofcgp10Q+9aHuAgwNcOmWrlVygw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR15MB4557
X-Proofpoint-ORIG-GUID: q4D9H2Bu0M_49poMJQYMYpEpO5BmBMEG
X-Proofpoint-GUID: q4D9H2Bu0M_49poMJQYMYpEpO5BmBMEG
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.895,Hydra:6.0.545,FMLib:17.11.122.1
 definitions=2022-10-17_13,2022-10-17_02,2022-06-22_01
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Chritoph, 

> On Oct 17, 2022, at 12:26 AM, Christoph Hellwig <hch@lst.de> wrote:
> 
> On Fri, Oct 07, 2022 at 04:43:11PM -0700, Song Liu wrote:
>> Changes RFC v1 => RFC v2:
>> 1. Major rewrite of the logic of vmalloc_exec and vfree_exec. They now
>>   work fine with BPF programs (patch 1, 2, 4). But module side (patch 3)
>>   still need some work.
> 
> Can you please move the changelog under the description of WTF the
> series actually does like the normal kernel process?  Explaining the
> changes from a previous version before you even describe what the series
> does is completely incoherent.

Will fix in the next version. 

> 
>> This set is a prototype that allows dynamic kernel text (modules, bpf
>> programs, various trampolines, etc.) to share huge pages. The idea is
>> similar to Peter's suggestion in [1]. Please refer to each patch for
>> more detais.
> 
> Well, nothing explains what the method is to avoid having memory
> that is mapped writable and executable at the same time, which really
> could use some explanation here (and in the main patch as well).

Thanks for the feedback. I will add this. 

Does the code look good to you? I personally think patch 1, 2, 4 could
ship with a little more work. 

Thanks,
Song