Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 17 Oct 2022 14:03:11 -0300
From:   Jason Gunthorpe <jgg@nvidia.com>
To:     Christian Schoenebeck <linux_oss@crudebyte.com>
Cc:     v9fs-developer@lists.sourceforge.net, linux-kernel@vger.kernel.org,
        netdev@vger.kernel.org,
        Dominique Martinet <asmadeus@codewreck.org>,
        Eric Van Hensbergen <ericvh@gmail.com>,
        Latchesar Ionkov <lucho@ionkov.net>,
        Nikolay Kichukov <nikolay@oldum.net>,
        Leon Romanovsky <leonro@nvidia.com>
Subject: Re: [PATCH v6 11/11] net/9p: allocate appropriate reduced message
 buffers
Message-ID: <Y02Kz2xuntFrKXhV@nvidia.com>
References: <cover.1657920926.git.linux_oss@crudebyte.com>
 <3f51590535dc96ed0a165b8218c57639cfa5c36c.1657920926.git.linux_oss@crudebyte.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <3f51590535dc96ed0a165b8218c57639cfa5c36c.1657920926.git.linux_oss@crudebyte.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?BpMlDZcESj5Ky3gdtz07V/6+rE4qFUhCzedopRZ8ss33PisdkQDat6vek5LS?=
 =?us-ascii?Q?LUnwo1LQ2A0EaEEd7OQN7ToCU8pjqbjrMKo563Fw3TxoPG1D1JFQAKlesMjH?=
 =?us-ascii?Q?UuQ0xTrM4jmxYoZZDpigIIo5pUVz7d7tBF6X9iEl08tg75EwezrNipdS7xMR?=
 =?us-ascii?Q?vauui+QFKsOsdCHqbJm7h3u70BVvdg1NYOhgJ/4iq+pmYyG5UqT6hvHe1iwZ?=
 =?us-ascii?Q?TP+oGmcZt26jwv14L5r9FLwtHExR7ioKbmveruvh0Welhyu7yNdxQifKPgin?=
 =?us-ascii?Q?JN97gb4R3UfqysgBojEd4GlLaJM8/dPF7Mk7qWpgQWySs0+iCIIBjCMs5a0k?=
 =?us-ascii?Q?6x2mBZL5ZXjJKVz0odLI4Hhv2/BmLbbWSJDfWlKF4UzZpkPheja44ndijs0V?=
 =?us-ascii?Q?O7h/MBhXv/RX/QldRwCTx/L2kq7b8F7dlXJUl1054OX1xti4jwfjT9w0tCi7?=
 =?us-ascii?Q?jheL7M4SHm4YzIeskfLaaE/N9iorGcUgqyJz5lpSSrq1ANnOTTWiEqtFiubH?=
 =?us-ascii?Q?Ys2b0zkbfiQUWFntwNzob88ZPAVZSa9CkOvpXwYcfBkM7l4zx+kKNq2G+ZOa?=
 =?us-ascii?Q?6L4VxgSQ7B0adlUgYdWDQ8+1wKJV52fRs0V2+qP/BddVZsQf1XTTleENFYff?=
 =?us-ascii?Q?6M8p5auH1/5xPBpRHFjaHjxMOMVqxrlonuq6U0k+tzo2kW1Z81SAvgEDw0Ds?=
 =?us-ascii?Q?SRwbd2H2GWn4RGGvs+BwA1dyT843TpWHzcJVwumYLzpRh3GlPVc/IvKCKDlo?=
 =?us-ascii?Q?ScM1EUi7sx8liITiUXqftUOn1rVHukkKNrvTcYdaCErZsImR0W0P14xO4ojW?=
 =?us-ascii?Q?dlWXDEsf0hIyBbJzkd6tZpcvPlbWbX20NiHCwLWrhIKoyDsF3GrOfa6FG1iI?=
 =?us-ascii?Q?p/xclC5exJhQNq1F8klmTvNF+5ASDWlzXyZ/x7QhDonfK47HGHOrgPYem00X?=
 =?us-ascii?Q?w/di/mcHqb3i5q8hajKbvEIcjiDe+WVZ1fjURNieSqmDhf5caXMl4+8Df0u0?=
 =?us-ascii?Q?masFN5glEiZsn/LmDqY/Md8jT3Bic1Q/9Zho+djZiXHzd2wSdIB5tBMhJnRo?=
 =?us-ascii?Q?ponpQfCwpIM2R6N+ctNj2yjeujBm4nUFPJ4IMcF+63+peMDVMUvr5D3Emtpe?=
 =?us-ascii?Q?KdiSIGoNOkJGOZRYw6IB8WPD2HqVm8SPvHbClpXOQKPMzOklK28qDCNwo1Dp?=
 =?us-ascii?Q?w/QPsc4R5CiqkRZnMBKT3OZTKWuaKKn26p0znBsYGfgoTT0WcdSqtDSVET9O?=
 =?us-ascii?Q?X3m4ezlFZw2vLiEPG+ymBR4xb0rVx/65cPm+j/zSImRXWKkfYbn6pohgrKXN?=
 =?us-ascii?Q?CQhDdWY1kqSHf/XuLr3FKJCaY5JdUVrJEJ6j19+BQJKtMqQlxNTgGc+Htyo3?=
 =?us-ascii?Q?dc/AK86dM/I1oH7rgUOydZuVno6aUDPEQPWTTPbTWXh3leWNRcE8iZWauu6d?=
 =?us-ascii?Q?z25uoJBS3tYTLiPstd+0CisMz1i6cppjm8TMBXOkRZaR/LMSIY4WJRxazdqA?=
 =?us-ascii?Q?465p69kncQQ8nwpGPRoOzLcr0QlwMVM7suzbS0gU8P713O9lkermxfJnILEd?=
 =?us-ascii?Q?WCuxwMpc3iH66JC2MDg=3D?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 84275d8c-183a-472e-708c-08dab0617adb
X-MS-Exchange-CrossTenant-AuthSource: LV2PR12MB5869.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Oct 2022 17:03:14.7895
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: ZRqX8ZoZfxqil7IyCoYZfYygBWNvdxic3fmetTNJ8OzeCdbFgOtbrb/4m5zhsEIY
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN9PR12MB5384
X-Spam-Status: No, score=-1.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE
        autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Jul 15, 2022 at 11:33:56PM +0200, Christian Schoenebeck wrote:
> So far 'msize' was simply used for all 9p message types, which is far
> too much and slowed down performance tremendously with large values
> for user configurable 'msize' option.
> 
> Let's stop this waste by using the new p9_msg_buf_size() function for
> allocating more appropriate, smaller buffers according to what is
> actually sent over the wire.
> 
> Only exception: RDMA transport is currently excluded from this message
> size optimization - for its response buffers that is - as RDMA transport
> would not cope with it, due to its response buffers being pulled from a
> shared pool. [1]
> 
> Link: https://lore.kernel.org/all/Ys3jjg52EIyITPua@codewreck.org/ [1]
> Signed-off-by: Christian Schoenebeck <linux_oss@crudebyte.com>
> ---
>  net/9p/client.c | 42 +++++++++++++++++++++++++++++++++++-------
>  1 file changed, 35 insertions(+), 7 deletions(-)

It took me a while to sort out, but for any others - this patch is
incompatible with qemu 5.0. It starts working again after this qemu
patch:

commit cf45183b718f02b1369e18c795dc51bc1821245d
Author: Stefano Stabellini <stefano.stabellini@xilinx.com>
Date:   Thu May 21 12:26:25 2020 -0700

    Revert "9p: init_in_iov_from_pdu can truncate the size"
    
    This reverts commit 16724a173049ac29c7b5ade741da93a0f46edff7.
    It causes https://bugs.launchpad.net/bugs/1877688.
    
    Signed-off-by: Stefano Stabellini <stefano.stabellini@xilinx.com>
    Reviewed-by: Christian Schoenebeck <qemu_oss@crudebyte.com>
    Message-Id: <20200521192627.15259-1-sstabellini@kernel.org>
    Signed-off-by: Greg Kurz <groug@kaod.org>

It causes something like this:

# modprobe ib_cm
qemu-system-x86_64: VirtFS reply type 117 needs 17 bytes, buffer has 17, less than minimum

Jason