Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 17 Oct 2022 20:19:16 +0300
From:   Vladimir Oltean <olteanv@gmail.com>
To:     Arun Ramadoss <arun.ramadoss@microchip.com>
Cc:     linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
        woojung.huh@microchip.com, UNGLinuxDriver@microchip.com,
        andrew@lunn.ch, vivien.didelot@gmail.com, f.fainelli@gmail.com,
        davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
        pabeni@redhat.com, linux@armlinux.org.uk,
        Tristram.Ha@microchip.com, richardcochran@gmail.com,
        ceggers@arri.de, b.hutchman@gmail.com
Subject: Re: [RFC Patch net-next 0/6] net: dsa: microchip: add gPTP support
 for LAN937x switch
Message-ID: <20221017171916.oszpyxfnblezee6u@skbuf>
References: <20221014152857.32645-1-arun.ramadoss@microchip.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20221014152857.32645-1-arun.ramadoss@microchip.com>
Precedence: bulk

Hi Arun,

On Fri, Oct 14, 2022 at 08:58:51PM +0530, Arun Ramadoss wrote:
> The LAN937x switch has capable for supporting IEEE 1588 PTP protocol. This
> patch series add gPTP profile support and tested using the ptp4l application.
> LAN937x has the same PTP register set similar to KSZ9563, hence the
> implementation has been made common for the ksz switches. But the testing is
> done only for lan937x switch.

Would it be possible to actually test these patches on KSZ9563?

Christian Eggers tried to add PTP support for this switch a while ago,
and he claims that two-step TX timestamping was de-featured for KSZ95xx
due to hardware errata.
https://patchwork.ozlabs.org/project/netdev/patch/20201019172435.4416-8-ceggers@arri.de/

> 
> Arun Ramadoss (6):
>   net: dsa: microchip: adding the posix clock support
>   net: dsa: microchip: Initial hardware time stamping support
>   net: dsa: microchip: Manipulating absolute time using ptp hw clock
>   net: dsa: microchip: enable the ptp interrupt for timestamping
>   net: dsa: microchip: Adding the ptp packet reception logic
>   net: dsa: microchip: add the transmission tstamp logic
> 
>  drivers/net/dsa/microchip/Kconfig       |  10 +
>  drivers/net/dsa/microchip/Makefile      |   1 +
>  drivers/net/dsa/microchip/ksz_common.c  |  43 +-
>  drivers/net/dsa/microchip/ksz_common.h  |  31 +
>  drivers/net/dsa/microchip/ksz_ptp.c     | 755 ++++++++++++++++++++++++
>  drivers/net/dsa/microchip/ksz_ptp.h     |  84 +++
>  drivers/net/dsa/microchip/ksz_ptp_reg.h |  68 +++
>  include/linux/dsa/ksz_common.h          |  53 ++
>  net/dsa/tag_ksz.c                       | 156 ++++-
>  9 files changed, 1192 insertions(+), 9 deletions(-)
>  create mode 100644 drivers/net/dsa/microchip/ksz_ptp.c
>  create mode 100644 drivers/net/dsa/microchip/ksz_ptp.h
>  create mode 100644 drivers/net/dsa/microchip/ksz_ptp_reg.h
>  create mode 100644 include/linux/dsa/ksz_common.h
> 
> 
> base-commit: 66ae04368efbe20eb8951c9a76158f99ce672f25
> -- 
> 2.36.1
>