Received: by 2002:a05:6358:1087:b0:cb:c9d3:cd90 with SMTP id j7csp4835765rwi; Mon, 17 Oct 2022 11:23:58 -0700 (PDT) X-Google-Smtp-Source: AMsMyM6cUzLWXu5c7Tt67c9Thqg7xxJJGGck2FDpb/vR2PcjajTn+c+vr5eHDLIVkA9ibBD7+dcl X-Received: by 2002:a17:902:ced0:b0:17f:92d6:f5ec with SMTP id d16-20020a170902ced000b0017f92d6f5ecmr12831765plg.34.1666031027578; Mon, 17 Oct 2022 11:23:47 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1666031027; cv=none; d=google.com; s=arc-20160816; b=ZsZUpgVxmDiEMgb80F69VXNR6BvKTCgKcfiK9yGwr811ol1TTNqXSFYkFnhtGlLPQH 6pBT8gGmX+12CSBc7M6rOy/qIBaRSh4KJH4wa98/RV3VpZ28mCL+QzCNZlU/k1c6w5Mn eTsYqpq6fCqbaCWva9QHfWllXZMYr//CeRLcWS/V6+psOmUojA/Fz1ipYXpOhWqwchlf fiVTvvMslSAg1gYgCV9P2gZRGkzX9bPV/5/7/YhfGQpe2nSwqHTNgm45VeF4ejpLbE+p mFD7b7RnmRnqnQUJFx0Cbs+E3F0P29PLaJ31ed9LsU9SWGmqLRdsl+XyESi/NpmfFWXl 8/Cw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=IUidW8NItaDXNEWCUfPFKo7TadH14Rb3mgSUQBIql2o=; b=iaZBnd95yHXD56ImSmjYWkE9M4j/WWvsY4guYnBsyDPp4AD+ZvGV4gcSAqG1Eqv5/V vka+B7VqV0go/Hhs0w9prc4W0Z3t+xmQomwiCJ9VXSfjBYS+1iMrt84itUhPM5LOD6hh W+bx75DPXGO4FEQR0LUovM0LAb7nu7s8ttcRqAly92t09tjkQuFgqGRGMekxSN+Wtuvx Af16bHycoon8IyAcNGuf2co8qGhGlmyxxTWOjZUsaZHHFWrhW540ndnoFo6sFx10av7d NCT0gpMdzf0i9uCHY2YTKaZaL7qQgyTPkqY7LpQXV5+5HPGBGeWMHOY1trymCghBx8y8 QZMg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@zx2c4.com header.s=20210105 header.b=C17OfLTV; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=zx2c4.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id m26-20020a6562da000000b0045cbd4e43a1si11995749pgv.57.2022.10.17.11.23.34; Mon, 17 Oct 2022 11:23:47 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@zx2c4.com header.s=20210105 header.b=C17OfLTV; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=zx2c4.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230159AbiJQR2u (ORCPT + 99 others); Mon, 17 Oct 2022 13:28:50 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39310 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229980AbiJQR2o (ORCPT ); Mon, 17 Oct 2022 13:28:44 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 70EF86BD5D for ; Mon, 17 Oct 2022 10:28:40 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 31B39611EC for ; Mon, 17 Oct 2022 17:26:41 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5BC03C433B5 for ; Mon, 17 Oct 2022 17:26:40 +0000 (UTC) Authentication-Results: smtp.kernel.org; dkim=pass (1024-bit key) header.d=zx2c4.com header.i=@zx2c4.com header.b="C17OfLTV" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=zx2c4.com; s=20210105; t=1666027597; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=IUidW8NItaDXNEWCUfPFKo7TadH14Rb3mgSUQBIql2o=; b=C17OfLTVAcbSc8ni9sfKd+c6UoqAxYU0EQaj/2eMikZyQG1iZLMRMkLVHK42SY13XDcnoR dUWSNw2z6WGAbH3RrHfqA+QFD9kDHiG2Fr3qpcsSGeScz4qTJHxfWQpTxi6X2wmAP+qM8k Z0g+RdFZD9fHMBmf+6qYkKdcT1AlpAA= Received: by mail.zx2c4.com (ZX2C4 Mail Server) with ESMTPSA id 513d9858 (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO) for ; Mon, 17 Oct 2022 17:26:37 +0000 (UTC) Received: by mail-vs1-f45.google.com with SMTP id 63so12211876vse.2 for ; Mon, 17 Oct 2022 10:26:37 -0700 (PDT) X-Gm-Message-State: ACrzQf1oFCl0cGz3qx7/z7BZJCeXwDhsl5Ze/Ky6tYL8/NB0GMl0chnU j7XzCnsHnrUf6mUsEPBSzGAPARG+bfne3syU3Vk= X-Received: by 2002:a67:ed9a:0:b0:3a7:718a:7321 with SMTP id d26-20020a67ed9a000000b003a7718a7321mr4013100vsp.55.1666027596776; Mon, 17 Oct 2022 10:26:36 -0700 (PDT) MIME-Version: 1.0 References: <20221017044345.15496-1-Jason@zx2c4.com> In-Reply-To: From: "Jason A. Donenfeld" Date: Mon, 17 Oct 2022 11:26:25 -0600 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH] kcsan: remove rng selftest To: Marco Elver Cc: dvyukov@google.com, kasan-dev@googlegroups.com, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-6.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, RCVD_IN_DNSWL_HI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Oct 16, 2022 at 11:09 PM Marco Elver wrote: > > On Sun, 16 Oct 2022 at 22:07, Marco Elver wrote: > > > > On Sun, 16 Oct 2022 at 21:43, Jason A. Donenfeld wrote: > > > > > > The first test of the kcsan selftest appears to test if get_random_u32() > > > returns two zeros in a row, and requires that it doesn't. This seems > > > like a bogus critera. Remove it. > > > > > > Signed-off-by: Jason A. Donenfeld > > > > Acked-by: Marco Elver > > > > Looks pretty redundant at this point (I think some early version had > > it because somehow I managed to run the test too early and wanted to > > avoid that accidentally happening again). > > > > And kindly queue it in your tree with all the rng related changes. Thanks! Okay sure, will do. Jason