Received: by 2002:a05:6358:1087:b0:cb:c9d3:cd90 with SMTP id j7csp4845355rwi; Mon, 17 Oct 2022 11:32:25 -0700 (PDT) X-Google-Smtp-Source: AMsMyM7EkwTMXQBf3zr1ZjfoHiq5yY9VRgBxRhanKbNjERE9DNs7rI3Eg2XSR9wcWoBtSzK7T5Qn X-Received: by 2002:a63:2212:0:b0:43b:f03d:856a with SMTP id i18-20020a632212000000b0043bf03d856amr11794745pgi.192.1666031544983; Mon, 17 Oct 2022 11:32:24 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1666031544; cv=none; d=google.com; s=arc-20160816; b=1KuREVhh8Z245cEWCFW4FYihDKV7cyvTQHS0cM9mAO5Zo3uvGCfUOVSLygzoHu/0de 0Bc1v4qUUBbE++MW30mypUpFdAVZW0GSXgtOpKKtHHh1KVELVmG0bjLZV42wtXOu4kYO J5I9QkbWviRLZmIDs/oYlvmEXXnPdrD1F58GmJxZokMc0QlBRK5M5O1WhsdzSNsLXXJE m7QFCTb5GjtG0wE5Px9DoERJWEURyxoxq5ZT8PkoqdKaT60k9+vyvfRjVOW59soQLF1L 898x+TH93Lm/MweSn03jcNL53tJ7XKg658B1MdnnlrEG+NTIP55q2dRvevfjroGHHgCm aHyQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date; bh=49JT0DSMSY8r0dgKjxYOcFbH3FWm7+kogdqHh+hmphg=; b=TVlRXqTJH6jKAqDBhPfE4hWptHS8mHTo3qQGTqRc+BuAm4096dNBa9tV3E4cpXFKXh rJv8ugy/Tly6jmk7LBTLVz4MMgbrl0Rf3GPQeH1SX89DU/Y0ts48O1NVzxhL6FrwzFux dpLJrkV8eX+LwxpOOAbVtLb38yWdRLXktMKxs7q93IWFgem0x3Y+IILnIJq2xCC4xGct /HhnuenFOrUKWL7y/YPX3tVI/wGySx4diCcvYXDpJcx8Yrqvol2v6H4jzDv7MIWWJwdx O7gcVacA7VDqVglJA7fqZKclcqhyYKVH+iAxmpxCtO17TEVi35Ha8BmkBNJbbnp/VHhq QIWw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=arm.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id o10-20020a056a0015ca00b00557a43656c6si12478713pfu.109.2022.10.17.11.32.11; Mon, 17 Oct 2022 11:32:24 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=arm.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229867AbiJQSUo (ORCPT + 99 others); Mon, 17 Oct 2022 14:20:44 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52392 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230118AbiJQSUl (ORCPT ); Mon, 17 Oct 2022 14:20:41 -0400 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 1C7A61A3A9; Mon, 17 Oct 2022 11:20:39 -0700 (PDT) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 1D90B1042; Mon, 17 Oct 2022 11:20:45 -0700 (PDT) Received: from bogus (unknown [10.57.36.55]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id D9A7B3F792; Mon, 17 Oct 2022 11:20:37 -0700 (PDT) Date: Mon, 17 Oct 2022 19:20:35 +0100 From: Sudeep Holla To: Manank Patel Cc: rafael@kernel.org, lenb@kernel.org, linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] Fixes: 91cefefb6991 ("ACPI: PCC: replace wait_for_completion()") Message-ID: <20221017182035.3g67uudttl6k5gag@bogus> References: <20221013130311.1433314-1-pmanank200502@gmail.com> <20221017174915.45916-1-pmanank200502@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221017174915.45916-1-pmanank200502@gmail.com> X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_LOW, SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Oct 17, 2022 at 11:19:15PM +0530, Manank Patel wrote: > Fixed unintentional u32 overflow by changing PCC_CMD_WAIT_RETRIES_NUM to 500ULL > You just need to add the below fixes line above Signed-off tag. You seemed to have changed the $subject. Please retain the origin subject Please post it again cleanly marking it as v2(as in the subject must be [PATCH v2] "ACPI: PCC: Fix unintentional integer overflow" Fixes: 91cefefb6991 ("ACPI: PCC: replace wait_for_completion()") > Signed-off-by: Manank Patel > --- > > Sorry for the spam, I made a mistake in the previous patch (I had a confusion > in your suggestion about the Fixes tag).As you would have realised, i'm new > to this, and not so familiar with the workflow (Though I have read the > Documentation). Let me know if you have any suggestions. > Add a text here pointing what changed from v1->v2 v1->v2: Change the macro itself ULL instead typecasting in the code Hope this helps. With all these changes incorporated in v2, you can add my Acked-by: Sudeep Holla -- Regards, Sudeep