Received: by 2002:a05:6358:1087:b0:cb:c9d3:cd90 with SMTP id j7csp4857335rwi; Mon, 17 Oct 2022 11:43:19 -0700 (PDT) X-Google-Smtp-Source: AMsMyM7FJ5LskoWpEP8Oa0VOjde2QQR6gMXwI1lWye8iTgx3EkXLnU0gbduVbqZkOvEw/ZFkLLTV X-Received: by 2002:a63:1e5a:0:b0:43c:b966:e2d6 with SMTP id p26-20020a631e5a000000b0043cb966e2d6mr11594079pgm.569.1666032199064; Mon, 17 Oct 2022 11:43:19 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1666032199; cv=none; d=google.com; s=arc-20160816; b=j3LRIy7kVPSE9u8q+OBiTb3z8ItcQTSTWEtUvi+e2yxFrEhlslMMHCC/lmz6MEWAlZ tqNPn7d5itZ/1qeB3vu2AlbEnbU1Fx2OfhAXMCIaaTQphKo7mLNgBw7nE9o9kEWIb9yh Gr9kiM4IIk+qnPhZbDftkKcjw1SIYMZ9vwgpxL12p5HI3uTMS133Tl10+25CSszZmLaC CNTmaJpuWQ9M7xXYIK5USinr7ZPkGfm8GQKrrP6CqLXa0md1lftZN33QFI25oVujHpES 8FX8Q4IRf9hMAWzeYMnZo34s5Jw/oI6Sl0HxKO3VTAXPKVE8VVXKM760KIJ33KuUna2I SVTQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=zmaKaOskyDEP07VNlz3xmfh/tqhUu/L+2TquVBpNhZY=; b=K80IprxGwVXyA3oXi/PawIqG+bd+jkWnA78gi8O3DfqkOpe2dJlQm6fmEm48Wpm+TU C2Ar4agvft0BNxwKODeXZb5+URbdCjIs2PgvP5YmoSg0QxisVTJYk/4dcWNZctyZ9IIF i5cBNtE/FS9eSL9DoS0bvcD0hIekVzwv8QjhW6IVtM2XYIFFAGaST97TT7zokBFlCdmr UOvpIkAKiiYvbCgSIxexCKCnEncozH1Q5FoVCFAzZ+FSAWW2RKFJq84gZm9KR7zwTPts KI6w2a5zkdHJJbcfLc5ecv/rqJdQpXeqOWgtjs02OsyOGmtevj5OjNysTtXrdc576182 w81A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@toxicpanda-com.20210112.gappssmtp.com header.s=20210112 header.b=irazOzM4; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id h189-20020a6383c6000000b0045feab44f0dsi11823331pge.693.2022.10.17.11.43.06; Mon, 17 Oct 2022 11:43:19 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@toxicpanda-com.20210112.gappssmtp.com header.s=20210112 header.b=irazOzM4; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230445AbiJQS1b (ORCPT + 99 others); Mon, 17 Oct 2022 14:27:31 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36118 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230453AbiJQS11 (ORCPT ); Mon, 17 Oct 2022 14:27:27 -0400 Received: from mail-qt1-x832.google.com (mail-qt1-x832.google.com [IPv6:2607:f8b0:4864:20::832]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 170BD74DEF for ; Mon, 17 Oct 2022 11:27:21 -0700 (PDT) Received: by mail-qt1-x832.google.com with SMTP id w3so8250461qtv.9 for ; Mon, 17 Oct 2022 11:27:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=toxicpanda-com.20210112.gappssmtp.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=zmaKaOskyDEP07VNlz3xmfh/tqhUu/L+2TquVBpNhZY=; b=irazOzM4ASvlywgucqMF4REBu2/swLVa43rA8LaqSR7jySzDQIligyjApbjGDuRMnS vQ9T4lVgXghfnASSDN1i8Xm5LuOSSmKrQeI+6Q3lSUMmcQ+S1ZMTwud4rwmdl2bKdUJb 5A06jqIl6l0Q2ioGWFm1rgsyyv4+WVSI4vYkLYIuU7cq4ky+UG4BGvxh1YPFxlUM/mIS Aw95Uxl1xiMYZ1r6HA1cYcy6yLf9NSiyJC6i/20sgvkT64Wy2hfytLqNbB9lJrafEKAJ uYrMCySQfhbY4F4nodfn5APsYFVG5AQ69EqSfJVLIC4k3huk52b7fymAHztEqux5yncf 8vfw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=zmaKaOskyDEP07VNlz3xmfh/tqhUu/L+2TquVBpNhZY=; b=W8a1dLZ2DVmjTln0bTZOHgGe0QGTpj1cetuRPFd7ufOiG8b6viCQG6K1VZsi10O6Fr MyXkSLfdv8JsGizkaLZlCbCG7TX+asvJY+zWI+ZqSCJUEVI40tiu+36NRajOZ/mLpVtK f/9aoEZJ5taWh79jPAgwaxEWD4weybkgM8chhI42Uui7vV6Yr6bWAnP/jLWs1hI0Ytyi lQKpsbniancLQ1EKCr1///QwgQaiEEUCz4nV5MWqdjPfF/JnaAaPaktAWmOJOoVCKjj4 3vzobLN3/Jmbh0uXzdoURK0m9d5NBX7Z8bCnVhm9tvOBhESxgwLtVm806+4NwBmZpIZa S/Nw== X-Gm-Message-State: ACrzQf1MHadhz4bNSfsDkhY56O2CEAROoJYXUQd9xHu6PvOWlahstvZK pBntSFIbezFlfnsqXQAo93he9w== X-Received: by 2002:a05:622a:209:b0:39c:d88f:20ed with SMTP id b9-20020a05622a020900b0039cd88f20edmr9863627qtx.131.1666031240047; Mon, 17 Oct 2022 11:27:20 -0700 (PDT) Received: from localhost (cpe-174-109-170-245.nc.res.rr.com. [174.109.170.245]) by smtp.gmail.com with ESMTPSA id dt27-20020a05620a479b00b006b9c9b7db8bsm388323qkb.82.2022.10.17.11.27.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 17 Oct 2022 11:27:19 -0700 (PDT) Date: Mon, 17 Oct 2022 14:27:18 -0400 From: Josef Bacik To: Kemeng Shi Cc: tj@kernel.org, axboe@kernel.dk, cgroups@vger.kernel.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 3/3] block: Replace struct rq_depth with unsigned int in struct iolatency_grp Message-ID: References: <20220929074055.30080-1-shikemeng@huawei.com> <20220929074055.30080-4-shikemeng@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220929074055.30080-4-shikemeng@huawei.com> X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_NONE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Sep 29, 2022 at 03:40:55PM +0800, Kemeng Shi wrote: > We only need a max queue depth for every iolatency to limit the inflight io > number. Replace struct rq_depth with unsigned int to simplfy "struct > iolatency_grp" and save memory. > > Signed-off-by: Kemeng Shi Reviewed-by: Josef Bacik Thanks, Josef